From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 References: <1522759385-17661-1-git-send-email-ykaneko0929@gmail.com> <1522759385-17661-3-git-send-email-ykaneko0929@gmail.com> <20180409212129.w55kgl6s6fz4pi6v@rob-hp-laptop> <20180509180950.b35wrl35sxunjmpg@verge.net.au> In-Reply-To: <20180509180950.b35wrl35sxunjmpg@verge.net.au> From: Yoshihiro Kaneko Date: Mon, 14 May 2018 05:55:43 +0900 Message-ID: Subject: Re: [PATCH/RFT v3 2/3] dt-bindings: thermal: rcar-thermal: add R8A77995 support Content-Type: multipart/alternative; boundary="000000000000599816056c1c988b" To: Simon Horman Cc: Eduardo Valentin , Rob Herring , Zhang Rui , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-renesas-soc@vger.kernel.org List-ID: --000000000000599816056c1c988b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Simon-san, 2018=E5=B9=B45=E6=9C=8810=E6=97=A5(=E6=9C=A8) 3:10 Simon Horman : > On Mon, Apr 09, 2018 at 04:21:29PM -0500, Rob Herring wrote: > > On Tue, Apr 03, 2018 at 09:43:04PM +0900, Yoshihiro Kaneko wrote: > > > Signed-off-by: Yoshihiro Kaneko > > > Reviewed-by: Geert Uytterhoeven > > > --- > > > Documentation/devicetree/bindings/thermal/rcar-thermal.txt | 7 +++++= -- > > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > > > diff --git > a/Documentation/devicetree/bindings/thermal/rcar-thermal.txt > b/Documentation/devicetree/bindings/thermal/rcar-thermal.txt > > > index 349e635..5ab5fcd 100644 > > > --- a/Documentation/devicetree/bindings/thermal/rcar-thermal.txt > > > +++ b/Documentation/devicetree/bindings/thermal/rcar-thermal.txt > > > @@ -3,7 +3,8 @@ > > > Required properties: > > > - compatible : "renesas,thermal-", > > > "renesas,rcar-gen2-thermal" (with thermal-zone= ) > or > > > - "renesas,rcar-thermal" (without thermal-zone) > as fallback. > > > + "renesas,rcar-thermal" (without thermal-zone) = as > > > + fallback except R-Car D3. > > > Examples with soctypes are: > > > - "renesas,thermal-r8a73a4" (R-Mobile APE6) > > > - "renesas,thermal-r8a7743" (RZ/G1M) > > > @@ -12,13 +13,15 @@ Required properties: > > > - "renesas,thermal-r8a7791" (R-Car M2-W) > > > - "renesas,thermal-r8a7792" (R-Car V2H) > > > - "renesas,thermal-r8a7793" (R-Car M2-N) > > > + - "renesas,thermal-r8a77995" (R-Car D3) > > > - reg : Address range of the thermal registers. > > > The 1st reg will be recognized as common regist= er > > > if it has "interrupts". > > > > > > Option properties: > > > > > > -- interrupts : use interrupt > > > +- interrupts : use interrupt. > > > + Should contain 3 interrupts for R-Car D3. > > > > And how many for other chips? > > How about this? > > If present should contain 3 interrupts fo= r > R-Car D3 or 1 interrupt otherwise. Thanks! I will update the patch with your suggestion. > > > > > > > Example (non interrupt support): > > > > > > -- > > > 1.9.1 > > > > > > --000000000000599816056c1c988b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Simon-san,

2018=E5=B9=B45=E6=9C=8810=E6=97=A5(=E6=9C=A8) 3:10 Simon Ho= rman <horms@verge.net.au>:<= br>
On Mon, Apr 09, 2018 at 04:21:29PM = -0500, Rob Herring wrote:
> On Tue, Apr 03, 2018 at 09:43:04PM +0900, Yoshihiro Kaneko wrote:
> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> >=C2=A0 Documentation/devicetree/bindings/thermal/rcar-thermal.txt = | 7 +++++--
> >=C2=A0 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/thermal/rcar-therm= al.txt b/Documentation/devicetree/bindings/thermal/rcar-thermal.txt
> > index 349e635..5ab5fcd 100644
> > --- a/Documentation/devicetree/bindings/thermal/rcar-thermal.txt<= br> > > +++ b/Documentation/devicetree/bindings/thermal/rcar-thermal.txt<= br> > > @@ -3,7 +3,8 @@
> >=C2=A0 Required properties:
> >=C2=A0 - compatible=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0: "renesas,thermal-<soctype>",
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 "renesas,rcar-gen2-thermal" (with thermal-zone)= or
> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 "renesas,rcar-thermal" (without thermal-zone) as fa= llback.
> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 "renesas,rcar-thermal" (without thermal-zone) as > > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0fallback except R-Car D3.
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0Examples with soctypes are:
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0- "renesas,thermal-r8a73a4" (R-Mobile APE= 6)
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0- "renesas,thermal-r8a7743" (RZ/G1M)
> > @@ -12,13 +13,15 @@ Required properties:
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0- "renesas,thermal-r8a7791" (R-Car M2-W)<= br> > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0- "renesas,thermal-r8a7792" (R-Car V2H) > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0- "renesas,thermal-r8a7793" (R-Car M2-N)<= br> > > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0- "renesas,thermal-r8a77995" (R-Car D3)
> >=C2=A0 - reg=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 : Address range of the thermal registers.
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0The 1st reg will be recognized as common register
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0if it has "interrupts".
> >=C2=A0
> >=C2=A0 Option properties:
> >=C2=A0
> > -- interrupts=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0: use interrupt
> > +- interrupts=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0: use interrupt.
> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 Should contain 3 interrupts for R-Car D3.
>
> And how many for other chips?

How about this?

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 If present should contain 3 interrup= ts for
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 R-Car D3 or 1 interrupt otherwise.

Thanks!
I will update the patch with your suggestion.



> >=C2=A0
> >=C2=A0 Example (non interrupt support):
> >=C2=A0
> > --
> > 1.9.1
> >
>
--000000000000599816056c1c988b--