From: Steve French <smfrench@gmail.com>
To: Rohith Surabattula <rohiths.msft@gmail.com>
Cc: Shyam Prasad N <nspmangalore@gmail.com>,
CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH] cifs: update new ACE pointer after populate_new_aces.
Date: Wed, 10 Mar 2021 12:08:38 -0600 [thread overview]
Message-ID: <CAH2r5ms7zTQ-GXPPPbe+3HoucDE3NvbT7K7JPcCAzr6=nNs28Q@mail.gmail.com> (raw)
In-Reply-To: <CACdtm0Z4Qj1ehiPs7nu+aVDsoLob0GXTe7SGqmrkeTA=WWZhKg@mail.gmail.com>
Test 317 will require additional changes for test 317 when run with
cifsacl (to map ownership) or will need to be run with winbind or sssd
- but I verified that it does fix test 317 for idsfromsid,modefromsid
On Wed, Mar 10, 2021 at 11:58 AM Rohith Surabattula
<rohiths.msft@gmail.com> wrote:
>
> Looks good to me.
> Reviewed-by: Rohith Surabattula <rohiths@microsoft.com>
>
> On Wed, Mar 10, 2021 at 11:14 PM Shyam Prasad N <nspmangalore@gmail.com> wrote:
> >
> > Hi Steve,
> >
> > Please consider this fix for the failing generic/317 test for cifsacl
> > and idsfromsid,modefromsid.
> > This is exposed on certain combinations of default ACEs on the file.
> >
> > --
> > Regards,
> > Shyam
--
Thanks,
Steve
prev parent reply other threads:[~2021-03-10 18:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 17:44 [PATCH] cifs: update new ACE pointer after populate_new_aces Shyam Prasad N
2021-03-10 17:57 ` Rohith Surabattula
2021-03-10 18:08 ` Steve French [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH2r5ms7zTQ-GXPPPbe+3HoucDE3NvbT7K7JPcCAzr6=nNs28Q@mail.gmail.com' \
--to=smfrench@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=rohiths.msft@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.