From: Steve French <smfrench@gmail.com>
To: Stefan Metzmacher <metze@samba.org>
Cc: CIFS <linux-cifs@vger.kernel.org>,
samba-technical <samba-technical@lists.samba.org>,
COMMON INTERNET FILE SYSTEM SERVER
<linux-cifsd-devel@lists.sourceforge.net>
Subject: Re: [PATCH] smb3.1.1: allow dumping GCM256 keys to improve debugging of encrypted shares
Date: Thu, 6 May 2021 22:18:13 -0500 [thread overview]
Message-ID: <CAH2r5msBg3g4w0L6ngAqf9XKe3jFFFjDdE5hKH2_MgyUgNZnNA@mail.gmail.com> (raw)
In-Reply-To: <c2b84e56-87c6-469d-c272-02731cb0937c@samba.org>
On Thu, May 6, 2021 at 7:17 PM Stefan Metzmacher <metze@samba.org> wrote:
>
> Hi Steve,
>
> > +/*
> > + * Dump full key (32 byte encrypt/decrypt keys instead of 16 bytes)
> > + * is needed if GCM256 (stronger encryption) negotiated
> > + */
> > +struct smb3_full_key_debug_info {
> > + __u64 Suid;
> > + __u16 cipher_type;
> > + __u8 auth_key[16]; /* SMB2_NTLMV2_SESSKEY_SIZE */
>
> Why this? With kerberos the authentication key can be 32 bytes too.
>
> Why are you exporting it at all?
I don't remember the original reason for why it was thought wireshark
could use this.
Aurelien,
Do you remember the context/reasons for each of the exported fields?
--
Thanks,
Steve
next prev parent reply other threads:[~2021-05-07 3:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 22:19 [PATCH] smb3.1.1: allow dumping GCM256 keys to improve debugging of encrypted shares Steve French
2021-05-01 4:00 ` ronnie sahlberg
2021-05-01 4:17 ` Steve French
2021-05-01 10:53 ` Shyam Prasad N
2021-05-01 20:49 ` ronnie sahlberg
2021-05-02 4:05 ` Steve French
2021-05-02 23:02 ` Steve French
2021-05-07 13:48 ` Aurélien Aptel
2021-05-07 0:17 ` Stefan Metzmacher
2021-05-07 3:18 ` Steve French [this message]
2021-05-07 10:28 ` Aurélien Aptel
2021-05-07 12:43 ` Stefan Metzmacher
2021-05-07 13:23 ` Aurélien Aptel
2021-05-07 13:33 ` Aurélien Aptel
2021-05-07 14:16 ` Stefan Metzmacher
2021-05-07 15:37 ` Aurélien Aptel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH2r5msBg3g4w0L6ngAqf9XKe3jFFFjDdE5hKH2_MgyUgNZnNA@mail.gmail.com \
--to=smfrench@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-cifsd-devel@lists.sourceforge.net \
--cc=metze@samba.org \
--cc=samba-technical@lists.samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.