From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D35DC433FE for ; Thu, 30 Sep 2021 15:54:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25AE660F5B for ; Thu, 30 Sep 2021 15:54:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346597AbhI3P43 (ORCPT ); Thu, 30 Sep 2021 11:56:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346577AbhI3P42 (ORCPT ); Thu, 30 Sep 2021 11:56:28 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0C0AC06176A; Thu, 30 Sep 2021 08:54:45 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id i4so27713049lfv.4; Thu, 30 Sep 2021 08:54:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8LuCj9+8GFiHaMYgM8A65UudQg+qoOQQ2QUvcQ4XJ6s=; b=PXKNBxqcRYxhwIV2v2X64yZJayzFfGuPEaFJcRpO4WCNqMpCZwI1df/zPBhLNhmRG9 7YWtoaofqurtGMdx0tYBEI6UfndHKtDaw4PBX49q9qi3J9QTKWYVNSDazJnLhCwGhWpW sQyH53wtu7PQHWXKpw0IKJFLkzoLewsXUWMxyWUFA0GoZc/geWBr365BCc9DFKmEuqTx QD1UXjg8vOB88FTGI55O4xvrqxi80eDmibsD2swnwubvtT8jN+7r24raClw1eWxICIMn Xqc+xF7xzZT7TnBUA1RA5nmOrLjD64wC+WGfBcYeYx3rm7565L5ZdR6xyKgYS9WfGChU NdlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8LuCj9+8GFiHaMYgM8A65UudQg+qoOQQ2QUvcQ4XJ6s=; b=XbBmZKylOYkv9SoXviPKr9BWXkZnTMEhN/fJ51HYr7LvZ50SCBNVHrOfV5SWpjYM2r Y2qiC9CZ/lZsMRA6GQqL2/yNfuvwmt01k+raQ/914z/0iuApGZgUMbKUALfvCbUniGRI gSalxO6Z+kngZPgLhCAU9cS1ehUiZTvEswwuJASnjNdOIUR0Z+riW4QpL82Pr+TXguTS 2fDK3wKyn6cI/dVyVPlz5oC6323Y0CaVOJqjzh8gwILnBViU/sGrMjSLtCdVqkbFx6bt 8hDoqhoj9aXS9t5aF9sa3JGdoOav5Q8f/6EcjMIWu/mSG6lZ8XF7xAHIVtuMFICV5S9y uQUg== X-Gm-Message-State: AOAM530xbUXEPedn3z2RSBSh4SRFgiu7yX3y79mfdsl/iauHJLStOASh TzYK5mmp8+9+DBjHeQ/cTbqVveEdVpYvTtbgkUjRp9WQ X-Google-Smtp-Source: ABdhPJyOHnVmMylaeGdsSDUQCs/a7NstziQ8gAm3Iq6Rldf9w/4qe7wGWECjl3a+7RS3TZsUTx6/zgFOVy33MH5VI2M= X-Received: by 2002:a05:6512:32c5:: with SMTP id f5mr7091563lfg.234.1633017283958; Thu, 30 Sep 2021 08:54:43 -0700 (PDT) MIME-Version: 1.0 References: <163250387273.2330363.13240781819520072222.stgit@warthog.procyon.org.uk> <163279868982.18792.10448745714922373194@noble.neil.brown.name> In-Reply-To: <163279868982.18792.10448745714922373194@noble.neil.brown.name> From: Steve French Date: Thu, 30 Sep 2021 10:54:32 -0500 Message-ID: Subject: Re: [RFC][PATCH v3 0/9] mm: Use DIO for swap and fix NFS swapfiles To: NeilBrown Cc: David Howells , Matthew Wilcox , Christoph Hellwig , Trond Myklebust , "Theodore Ts'o" , linux-block@vger.kernel.org, ceph-devel , Trond Myklebust , "Darrick J. Wong" , Jeff Layton , Andreas Dilger , Anna Schumaker , linux-mm , Bob Liu , "Darrick J. Wong" , Josef Bacik , Seth Jennings , Jens Axboe , linux-fsdevel , linux-xfs , linux-ext4 , CIFS , Chris Mason , David Sterba , Minchan Kim , Steve French , Dan Magenheimer , linux-nfs , Ilya Dryomov , linux-btrfs , Al Viro , Linus Torvalds , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Sep 27, 2021 at 10:12 PM NeilBrown wrote: > > On Sat, 25 Sep 2021, David Howells wrote: > > Whilst trying to make this work, I found that NFS's support for swapfiles > > seems to have been non-functional since Aug 2019 (I think), so the first > > patch fixes that. Question is: do we actually *want* to keep this > > functionality, given that it seems that no one's tested it with an upstream > > kernel in the last couple of years? > > SUSE definitely want to keep this functionality. We have customers > using it. > I agree it would be good if it was being tested somewhere.... > I am trying to work through the testing of swap over SMB3 mounts since there are use cases where you need to expand the swap space to remote storage and so this requirement comes up. The main difficulty I run into is forgetting to mount with the mount options (to store mode bits) (so swap file has the right permissions) and debugging some of the xfstests relating to swap can be a little confusing. -- Thanks, Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B612DC4332F for ; Thu, 30 Sep 2021 15:54:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 509FD61440 for ; Thu, 30 Sep 2021 15:54:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 509FD61440 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C2BDF9400B9; Thu, 30 Sep 2021 11:54:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BDBAB94003A; Thu, 30 Sep 2021 11:54:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7D669400B9; Thu, 30 Sep 2021 11:54:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id 980A594003A for ; Thu, 30 Sep 2021 11:54:49 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 43625181CAC63 for ; Thu, 30 Sep 2021 15:54:49 +0000 (UTC) X-FDA: 78644687898.18.AEE63AD Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf05.hostedemail.com (Postfix) with ESMTP id 0C997506A677 for ; Thu, 30 Sep 2021 15:54:48 +0000 (UTC) Received: by mail-lf1-f46.google.com with SMTP id g41so27091799lfv.1 for ; Thu, 30 Sep 2021 08:54:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8LuCj9+8GFiHaMYgM8A65UudQg+qoOQQ2QUvcQ4XJ6s=; b=PXKNBxqcRYxhwIV2v2X64yZJayzFfGuPEaFJcRpO4WCNqMpCZwI1df/zPBhLNhmRG9 7YWtoaofqurtGMdx0tYBEI6UfndHKtDaw4PBX49q9qi3J9QTKWYVNSDazJnLhCwGhWpW sQyH53wtu7PQHWXKpw0IKJFLkzoLewsXUWMxyWUFA0GoZc/geWBr365BCc9DFKmEuqTx QD1UXjg8vOB88FTGI55O4xvrqxi80eDmibsD2swnwubvtT8jN+7r24raClw1eWxICIMn Xqc+xF7xzZT7TnBUA1RA5nmOrLjD64wC+WGfBcYeYx3rm7565L5ZdR6xyKgYS9WfGChU NdlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8LuCj9+8GFiHaMYgM8A65UudQg+qoOQQ2QUvcQ4XJ6s=; b=VO2RKqjmlj00OrZuv0ldXVpdJhkvVENoCHpMWCd4o5S/94EwLjg/Hr40qnXlo9s+hP 2NeL5eDp4FP4imDxHRGmppjFEvjV/tyeC0ejj/oa0uKqbf1xD4XybxUEFPrRZA+mBblJ /wC708W1nUhvXd+lKlODFi5aWRpyIktTUPqC/95JwW0AQgzA+/XW1ibz1tBsERlUnIOr 5glnDfT6ScuyQzIxWt6pkhoaNuzWIyQ5KNyVi5dcTorEXojsip6HX5HZLUAbREEJaNYx Q/dcCvBOdFrop4fNLqn08LJMGeJycTOadH+5rPtC2TVIHpNnr0vx5gYAXuCSny1FrqHc dc4w== X-Gm-Message-State: AOAM531UROqtEXd8S11Z1akCgluaw6GiUTtLvpfCVBSsU7Xhs3arMAH9 nhbKvj74xxTeAtescu6aGzGso/GeXupHSpvtMPc= X-Google-Smtp-Source: ABdhPJyOHnVmMylaeGdsSDUQCs/a7NstziQ8gAm3Iq6Rldf9w/4qe7wGWECjl3a+7RS3TZsUTx6/zgFOVy33MH5VI2M= X-Received: by 2002:a05:6512:32c5:: with SMTP id f5mr7091563lfg.234.1633017283958; Thu, 30 Sep 2021 08:54:43 -0700 (PDT) MIME-Version: 1.0 References: <163250387273.2330363.13240781819520072222.stgit@warthog.procyon.org.uk> <163279868982.18792.10448745714922373194@noble.neil.brown.name> In-Reply-To: <163279868982.18792.10448745714922373194@noble.neil.brown.name> From: Steve French Date: Thu, 30 Sep 2021 10:54:32 -0500 Message-ID: Subject: Re: [RFC][PATCH v3 0/9] mm: Use DIO for swap and fix NFS swapfiles To: NeilBrown Cc: David Howells , Matthew Wilcox , Christoph Hellwig , Trond Myklebust , "Theodore Ts'o" , linux-block@vger.kernel.org, ceph-devel , Trond Myklebust , "Darrick J. Wong" , Jeff Layton , Andreas Dilger , Anna Schumaker , linux-mm , Bob Liu , "Darrick J. Wong" , Josef Bacik , Seth Jennings , Jens Axboe , linux-fsdevel , linux-xfs , linux-ext4 , CIFS , Chris Mason , David Sterba , Minchan Kim , Steve French , Dan Magenheimer , linux-nfs , Ilya Dryomov , linux-btrfs , Al Viro , Linus Torvalds , LKML Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=PXKNBxqc; spf=pass (imf05.hostedemail.com: domain of smfrench@gmail.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=smfrench@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0C997506A677 X-Stat-Signature: nqsw1934pk5sypi7wd69hxx4wtndfudm X-HE-Tag: 1633017288-11313 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 27, 2021 at 10:12 PM NeilBrown wrote: > > On Sat, 25 Sep 2021, David Howells wrote: > > Whilst trying to make this work, I found that NFS's support for swapfiles > > seems to have been non-functional since Aug 2019 (I think), so the first > > patch fixes that. Question is: do we actually *want* to keep this > > functionality, given that it seems that no one's tested it with an upstream > > kernel in the last couple of years? > > SUSE definitely want to keep this functionality. We have customers > using it. > I agree it would be good if it was being tested somewhere.... > I am trying to work through the testing of swap over SMB3 mounts since there are use cases where you need to expand the swap space to remote storage and so this requirement comes up. The main difficulty I run into is forgetting to mount with the mount options (to store mode bits) (so swap file has the right permissions) and debugging some of the xfstests relating to swap can be a little confusing. -- Thanks, Steve