From: Steve French <smfrench@gmail.com>
To: CIFS <linux-cifs@vger.kernel.org>
Cc: samba-technical <samba-technical@lists.samba.org>
Subject: Common headers kernel client and server
Date: Tue, 31 Aug 2021 18:33:10 -0500 [thread overview]
Message-ID: <CAH2r5msVD=ySXysQoVvDsw+d4+2sVjybMKYSh2fBC7YDcVfp1w@mail.gmail.com> (raw)
Looks like a good opportunity to move a few of the kernel headers used
by the kernel client (cifs.ko) and new kernel server (ksmbd.ko) into
common subdirectory ...
Some have diverged a lot, but others like "smbfsctl.h" would be fairly
easy to make common (and has value as well, as a few of the additions
made in the client version will help the server in the future and vice
versa). In general, I lean toward having common headers for anything
defined in MS-SMB2, MS-FSCC, MS-SWN, MS-DTYP, MS-SMBD etc. and to try
to use the "official" names for fields and #defines so it is easy to
cross reference the code and the protocol documentation (even when
those field names in PDUs (protocol definitions) and infolevels etc.
use camelCase)
--
Thanks,
Steve
reply other threads:[~2021-08-31 23:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH2r5msVD=ySXysQoVvDsw+d4+2sVjybMKYSh2fBC7YDcVfp1w@mail.gmail.com' \
--to=smfrench@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.