From: Steve French <smfrench@gmail.com>
To: XiaoLi Feng <xifeng@redhat.com>, fstests@vger.kernel.org
Subject: Re: [PATCH v2] common/rc: add global mounted option for _scratch_remount
Date: Mon, 1 Apr 2019 10:29:24 -0500 [thread overview]
Message-ID: <CAH2r5mspi108y=4wkKWxQno+WGJnEOrWOGWL9KqSucF6fULG0g@mail.gmail.com> (raw)
In-Reply-To: <20190331123130.14922-1-xifeng@redhat.com>
I also verified that test 452 now works to cifs (SMB3 mounts to
multiple types of test targets, Azure, Windows etc.)
On Sun, Mar 31, 2019 at 7:31 AM XiaoLi Feng <xifeng@redhat.com> wrote:
>
> From: Xiaoli Feng <xifeng@redhat.com>
>
> When call _scratch_remount for cifs , it always requires to input
> password. This will make generic/306 generic/452 failed because
> cifs remount failed.
> ---
> common/rc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/rc b/common/rc
> index 1c42515f..ea1eaf6a 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -357,7 +357,7 @@ _scratch_remount()
> local opts="$1"
>
> if test -n "$opts"; then
> - mount -o "remount,$opts" $SCRATCH_MNT
> + mount $MOUNT_OPTIONS -o "remount,$opts" $SCRATCH_MNT
> fi
> }
>
> --
> 2.18.1
>
--
Thanks,
Steve
next prev parent reply other threads:[~2019-04-01 15:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 12:31 [PATCH v2] common/rc: add global mounted option for _scratch_remount XiaoLi Feng
2019-04-01 11:15 ` Eryu Guan
2019-04-02 8:58 ` Xiaoli Feng
2019-04-06 12:16 ` Eryu Guan
2019-04-01 15:29 ` Steve French [this message]
2019-04-02 0:33 ` Steve French
2019-04-02 8:29 ` Xiaoli Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH2r5mspi108y=4wkKWxQno+WGJnEOrWOGWL9KqSucF6fULG0g@mail.gmail.com' \
--to=smfrench@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=xifeng@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.