All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve French <smfrench@gmail.com>
To: Tom Talpey <tom@talpey.com>
Cc: Namjae Jeon <linkinjeon@kernel.org>, CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH] ksmbd: add default data stream name in FILE_STREAM_INFORMATION
Date: Sun, 19 Sep 2021 23:53:48 -0500	[thread overview]
Message-ID: <CAH2r5mtf443CyrFgDR+S51ZfG8qPSGWn+pS7O9oZo=ey8i4v8g@mail.gmail.com> (raw)
In-Reply-To: <CAH2r5msa4XeaLy=_HY9RrLpK0NyS9n3iMdYnvX7F4n2zNQNXgQ@mail.gmail.com>

Patch looks correct - tentatively merged pending testing (and additional review)

On Sun, Sep 19, 2021 at 11:47 PM Steve French <smfrench@gmail.com> wrote:
>
> On Sat, Sep 18, 2021 at 9:06 PM Tom Talpey <tom@talpey.com> wrote:
> >
> > This doesn't appear to be what's documented in MS-FSA section 2.1.5.11.29.
> > There, it appears to call for returning an empty stream list,
> > and STATUS_SUCCESS, when no streams are present.
>
> I tried a quick test to Windows and it does appear to return $DATA
> stream by default:
>
> # ./smbinfo filestreaminfo /mnt/junk
> Name: ::$DATA
> Size: 179765 bytes
> Allocation size: 196608 bytes
>
> when I tried the same thing to a directory on a share mounted to Windows 10
> (NTFS), I get no streams returned.
>
> So it does look like default stream ($DATA) is only returned for files
>
> > Also, why does the code special-case directories? The conditionals
> > on StreamSize and StreamAllocation size are entirely redundant,
> > after the top-level if (!S_ISDIR...), btw.
> >
> > I'd suggest asking Microsoft dochelp for clarification before
> > implementing this.
> >
> > Tom.
> >
> > On 9/18/2021 8:02 AM, Namjae Jeon wrote:
> > > Windows client expect to get default stream name(::DATA) in
> > > FILE_STREAM_INFORMATION response even if there is no stream data in file.
> > > This patch fix update failure when writing ppt or doc files.
>
>
>
>
> --
> Thanks,
>
> Steve



-- 
Thanks,

Steve

  reply	other threads:[~2021-09-20  4:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-18 12:02 [PATCH] ksmbd: add default data stream name in FILE_STREAM_INFORMATION Namjae Jeon
2021-09-18 12:39 ` Tom Talpey
2021-09-18 21:36   ` Namjae Jeon
2021-09-20  4:47   ` Steve French
2021-09-20  4:53     ` Steve French [this message]
2021-09-20 16:08     ` Tom Talpey
2021-09-20 16:34       ` Namjae Jeon
2021-09-21 18:19         ` Tom Talpey
2021-09-21 19:17           ` Steve French
2021-09-20 16:36       ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH2r5mtf443CyrFgDR+S51ZfG8qPSGWn+pS7O9oZo=ey8i4v8g@mail.gmail.com' \
    --to=smfrench@gmail.com \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.