From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve French Subject: Re: [PATCH 20/31] fs/cifs: use kmemdup rather than duplicating its implementation Date: Thu, 17 Sep 2015 00:00:18 -0500 Message-ID: References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-21-git-send-email-a.hajda@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Steve French , Bartlomiej Zolnierkiewicz , Marek Szyprowski , LKML , "linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" To: Andrzej Hajda Return-path: In-Reply-To: <1438934377-4922-21-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: loooks reasonable to me - isn't this part of a larger patch series though? Did you want it merged distinctly into cifs-2.6.git? On Fri, Aug 7, 2015 at 2:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > --- > fs/cifs/smb2pdu.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c > index 070fb2a..2d6b72f 100644 > --- a/fs/cifs/smb2pdu.c > +++ b/fs/cifs/smb2pdu.c > @@ -1394,14 +1394,13 @@ SMB2_ioctl(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, > goto ioctl_exit; > } > > - *out_data = kmalloc(*plen, GFP_KERNEL); > + *out_data = kmemdup(rsp->hdr.ProtocolId + le32_to_cpu(rsp->OutputOffset), > + *plen, GFP_KERNEL); > if (*out_data == NULL) { > rc = -ENOMEM; > goto ioctl_exit; > } > > - memcpy(*out_data, rsp->hdr.ProtocolId + le32_to_cpu(rsp->OutputOffset), > - *plen); > ioctl_exit: > free_rsp_buf(resp_buftype, rsp); > return rc; > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Thanks, Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752975AbbIQFAk (ORCPT ); Thu, 17 Sep 2015 01:00:40 -0400 Received: from mail-ig0-f171.google.com ([209.85.213.171]:35047 "EHLO mail-ig0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751857AbbIQFAi (ORCPT ); Thu, 17 Sep 2015 01:00:38 -0400 MIME-Version: 1.0 In-Reply-To: <1438934377-4922-21-git-send-email-a.hajda@samsung.com> References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-21-git-send-email-a.hajda@samsung.com> From: Steve French Date: Thu, 17 Sep 2015 00:00:18 -0500 Message-ID: Subject: Re: [PATCH 20/31] fs/cifs: use kmemdup rather than duplicating its implementation To: Andrzej Hajda Cc: Steve French , Bartlomiej Zolnierkiewicz , Marek Szyprowski , LKML , "linux-cifs@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org loooks reasonable to me - isn't this part of a larger patch series though? Did you want it merged distinctly into cifs-2.6.git? On Fri, Aug 7, 2015 at 2:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > --- > fs/cifs/smb2pdu.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c > index 070fb2a..2d6b72f 100644 > --- a/fs/cifs/smb2pdu.c > +++ b/fs/cifs/smb2pdu.c > @@ -1394,14 +1394,13 @@ SMB2_ioctl(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, > goto ioctl_exit; > } > > - *out_data = kmalloc(*plen, GFP_KERNEL); > + *out_data = kmemdup(rsp->hdr.ProtocolId + le32_to_cpu(rsp->OutputOffset), > + *plen, GFP_KERNEL); > if (*out_data == NULL) { > rc = -ENOMEM; > goto ioctl_exit; > } > > - memcpy(*out_data, rsp->hdr.ProtocolId + le32_to_cpu(rsp->OutputOffset), > - *plen); > ioctl_exit: > free_rsp_buf(resp_buftype, rsp); > return rc; > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Thanks, Steve