From: Steve French <smfrench@gmail.com>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
CIFS <linux-cifs@vger.kernel.org>,
Shyam Prasad N <sprasad@microsoft.com>,
Steve French <stfrench@microsoft.com>
Subject: Re: [PATCH -next] cifs: fix wrong unlock before return from cifs_tree_connect()
Date: Fri, 29 Jul 2022 10:34:26 -0500 [thread overview]
Message-ID: <CAH2r5muo6yBej4J_2P+09WNmDoCSW3vbgR4JwM-42B0SQoUotA@mail.gmail.com> (raw)
In-Reply-To: <20220729074935.115072-1-yangyingliang@huawei.com>
merged into cifs-2.6.git for-next
On Fri, Jul 29, 2022 at 2:45 AM Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> It should unlock 'tcon->tc_lock' before return from cifs_tree_connect().
>
> Fixes: fe67bd563ec2 ("cifs: avoid use of global locks for high contention data")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> fs/cifs/connect.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 931d4b6fafc8..1362210f3ece 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -4583,7 +4583,7 @@ int cifs_tree_connect(const unsigned int xid, struct cifs_tcon *tcon, const stru
> if (tcon->ses->ses_status != SES_GOOD ||
> (tcon->status != TID_NEW &&
> tcon->status != TID_NEED_TCON)) {
> - spin_unlock(&tcon->ses->ses_lock);
> + spin_unlock(&tcon->tc_lock);
> return 0;
> }
> tcon->status = TID_IN_TCON;
> --
> 2.25.1
>
--
Thanks,
Steve
next prev parent reply other threads:[~2022-07-29 15:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 7:49 [PATCH -next] cifs: fix wrong unlock before return from cifs_tree_connect() Yang Yingliang
2022-07-29 15:34 ` Steve French [this message]
2022-08-01 2:32 ` Shyam Prasad N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH2r5muo6yBej4J_2P+09WNmDoCSW3vbgR4JwM-42B0SQoUotA@mail.gmail.com \
--to=smfrench@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sprasad@microsoft.com \
--cc=stfrench@microsoft.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.