From: Steve French <smfrench@gmail.com>
To: Andrew Walker <awalker@ixsystems.com>
Cc: Paulo Alcantara <pc@manguebit.com>, linux-cifs@vger.kernel.org
Subject: Re: Nested NTFS volumes within Windows SMB share may result in inode collisions in linux client
Date: Wed, 1 Mar 2023 19:49:13 -0600 [thread overview]
Message-ID: <CAH2r5mv52koGnKbvtRKE95c_JwwtitTXFaRc6mcM8nwLmWNo9A@mail.gmail.com> (raw)
In-Reply-To: <CAB5c7xrdKSO4YE_vUQ6tg+p=WwxEdquj+VrRpwKxi8Jd0vPyAQ@mail.gmail.com>
I would expect when the inode collision is noted that
"cifs_autodisable_serverino()" will get called in the Linux client and
you should see: "Autodisabling the user of server inode numbers on
..."
"Consider mounting with noserverino to silence this message"
If this is easy to setup we could try some tricks when we encounter
such a reparse point - do you have patch ideas for the client to fake
up inode numbers in this case?
On Wed, Mar 1, 2023 at 7:39 PM Andrew Walker <awalker@ixsystems.com> wrote:
>
> On Wed, Mar 1, 2023 at 5:37 PM Paulo Alcantara <pc@manguebit.com> wrote:
> >
> > Andrew Walker <awalker@ixsystems.com> writes:
> >
> > > On my Windows server I mounted multiple NTFS volumes within the same
> > > share and played around until I was able to create directories with
> > > the same fileid number.
> >
> > Did you try it with 'noserverino' mount option? For more information,
> > see mount.cifs(8).
>
> Yes. In this case I get a unique inode number
>
> > Did it work with older kernels?
> I only tested with 5.15 kernel. Was there a different algorithm in
> older kernels that's worth testing?
>
> > Perhaps we could conditionally stop trusting file ids sent by the server
> > as we currently do for hardlinks when we see these reparse points as
> > well.
>
> Maybe fail chdir with EXDEV unless mount is with noserverino?
--
Thanks,
Steve
next prev parent reply other threads:[~2023-03-02 1:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 22:07 Nested NTFS volumes within Windows SMB share may result in inode collisions in linux client Andrew Walker
2023-03-01 22:37 ` Paulo Alcantara
2023-03-02 1:33 ` Andrew Walker
2023-03-02 1:49 ` Steve French [this message]
2023-03-02 4:12 ` Andrew Walker
2023-03-02 19:18 ` Tom Talpey
2023-03-02 19:23 ` Steve French
2023-03-02 19:32 ` Tom Talpey
2023-03-02 19:38 ` Andrew Walker
2023-03-02 19:42 ` ronnie sahlberg
2023-03-02 18:00 ` Paulo Alcantara
2023-08-21 18:57 ` Paulo Alcantara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH2r5mv52koGnKbvtRKE95c_JwwtitTXFaRc6mcM8nwLmWNo9A@mail.gmail.com \
--to=smfrench@gmail.com \
--cc=awalker@ixsystems.com \
--cc=linux-cifs@vger.kernel.org \
--cc=pc@manguebit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.