All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve French <smfrench@gmail.com>
To: Pavel Shilovsky <piastryyy@gmail.com>
Cc: "Aurélien Aptel" <aaptel@suse.com>,
	"Shyam Prasad N" <nspmangalore@gmail.com>,
	CIFS <linux-cifs@vger.kernel.org>,
	"ronnie sahlberg" <ronniesahlberg@gmail.com>
Subject: Re: [PATCH 4/4] cifs: Reformat DebugData and index connections by conn_id.
Date: Tue, 16 Feb 2021 14:18:49 -0600	[thread overview]
Message-ID: <CAH2r5mvDkOLAo2YQbEDGRERt2Z5wdnqHzfZaQ6+kdftkc8-E-A@mail.gmail.com> (raw)
In-Reply-To: <CAKywueRoFL17DiMzmorZcd=OJvDY_8+P8WxGqKDx-tdnJrr_HQ@mail.gmail.com>

On Thu, Feb 11, 2021 at 11:12 AM Pavel Shilovsky <piastryyy@gmail.com> wrote:
>
> Hi Shyam,
>
> The output looks very informative! I have one comment:
>
> Servers:
> 1) ConnectionId: 0x1
> Number of credits: 326 Dialect 0x311
> TCP status: 1 Instance: 1
> Local Users To Server: 1 SecMode: 0x1 Req On Wire: 0
> In Send: 0 In MaxReq Wait: 0
>
> Sessions:
> 1) Name: 10.229.158.38 Uses: 1 Capability: 0x300077 Session Status: 1
>                      ^^^^
> Isn't this name (or hostname) a property of the connection? I would
> expect an IP or a hostname to be printed in the connection settings
> above.

The "Name:" (actually the IPv4 or IPv6 address, not the name) is from
ses->serverName not from the connection (tcp socket).  We should
probably change from "Name" to "Address" or equivalent in
/proc/fs/cifs/DebugData

See fs/cifs/connect.c lines 1841 and 1843

The "name" field could be added to the /proc/fs/cifs/DebugData output
for the TCP_Server_Info struct by e.g. dumping the "hostname" and/or
"server_RFC1001_name" fields.


-- 
Thanks,

Steve

      parent reply	other threads:[~2021-02-16 20:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04  8:11 [PATCH 4/4] cifs: Reformat DebugData and index connections by conn_id Shyam Prasad N
2021-02-04 10:17 ` Aurélien Aptel
2021-02-04 12:03   ` Shyam Prasad N
2021-02-04 14:45     ` Aurélien Aptel
2021-02-07  4:14       ` Shyam Prasad N
2021-02-07  4:22         ` Steve French
2021-02-08 11:36           ` Aurélien Aptel
2021-02-11 13:13             ` Shyam Prasad N
2021-02-11 14:24               ` Aurélien Aptel
2021-02-11 17:12                 ` Pavel Shilovsky
2021-02-11 19:41                   ` Tom Talpey
2021-02-16 12:29                     ` Shyam Prasad N
2021-02-16 19:56                       ` Steve French
2021-02-16 20:48                         ` Tom Talpey
2021-02-16 22:30                       ` Steve French
2021-02-16 20:18                   ` Steve French [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAH2r5mvDkOLAo2YQbEDGRERt2Z5wdnqHzfZaQ6+kdftkc8-E-A@mail.gmail.com \
    --to=smfrench@gmail.com \
    --cc=aaptel@suse.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=nspmangalore@gmail.com \
    --cc=piastryyy@gmail.com \
    --cc=ronniesahlberg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.