From: Steve French <smfrench@gmail.com>
To: Cyrille Mucchietto <cmucchietto@wallix.com>
Cc: Pavel Shilovsky <pavel.shilovsky@gmail.com>,
Sebastien Tisserant <stisserant@wallix.com>,
Steve French <sfrench@samba.org>,
"linux-cifs@vger.kernel.org" <linux-cifs@vger.kernel.org>,
"samba-technical@lists.samba.org"
<samba-technical@lists.samba.org>,
Cristian Popi <cpopi@wallix.com>
Subject: Re: PROBLEM: Kernel oops when mounting a encryptData CIFS share with CONFIG_DEBUG_VIRTUAL
Date: Mon, 29 Jul 2019 16:02:07 -0500 [thread overview]
Message-ID: <CAH2r5mva1S6Z=4fiQ986Hv8dA81Liy1C7FGK7UoyvNmt5ZqWoA@mail.gmail.com> (raw)
In-Reply-To: <e6246145-8143-ea69-6471-6cc593c95324@wallix.com>
If the patch is an improvement - I am ok with it. Unless one of the
mm experts has better idea
On Fri, Jul 26, 2019 at 1:28 AM Cyrille Mucchietto
<cmucchietto@wallix.com> wrote:
>
> On 7/25/19 10:35 PM, Pavel Shilovsky wrote:
> ...
> >> mount works without CONFIG_DEBUG_VIRTUAL
> >>
> >> If we don't set CONFIG_VMAP_STACK mount works with CONFIG_DEBUG_VIRTUAL
> >> We have the following (very quick and dirty) patch :
> >> ...
> > Thanks for reporting this. The patch looks good to me. Did you test
> > your scenario all together with it (not only mounting)?
> >
> >
> > Best regards,
> > Pavel Shilovskiy
>
> We've done some tests (mount/unmount, copy/delete/move files) and it seems
> to be OK.
>
> We aren't sure that our patch corrects the root cause of this issue, as
> for our
> understanding, kernel stack with VMAP_STACK enabled might not be contiguous.
> If the stack is too big to be on one page and data are splitted accross non
> contiguous pages it might not work.
>
> Regards
>
> Cyrille Mucchietto
>
>
--
Thanks,
Steve
next prev parent reply other threads:[~2019-07-29 21:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <380e1b86-1911-b8a5-6b02-276b6d4be4fe@wallix.com>
2019-07-25 20:35 ` PROBLEM: Kernel oops when mounting a encryptData CIFS share with CONFIG_DEBUG_VIRTUAL Pavel Shilovsky
2019-07-26 6:28 ` Cyrille Mucchietto
2019-07-29 21:02 ` Steve French [this message]
2019-08-01 17:13 ` Steve French
2019-08-02 6:58 ` Cyrille Mucchietto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH2r5mva1S6Z=4fiQ986Hv8dA81Liy1C7FGK7UoyvNmt5ZqWoA@mail.gmail.com' \
--to=smfrench@gmail.com \
--cc=cmucchietto@wallix.com \
--cc=cpopi@wallix.com \
--cc=linux-cifs@vger.kernel.org \
--cc=pavel.shilovsky@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=stisserant@wallix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.