All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Seymour <jon.seymour@gmail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: Johannes Sixt <j6t@kdbg.org>, Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org
Subject: Re: [RFC 0/9] bisect: allow git bisect to be used with repos containing damaged trees.
Date: Tue, 26 Jul 2011 23:28:15 +1000	[thread overview]
Message-ID: <CAH3AnroGQML+FV_Zh9u35bOBed00bk3qcQ1qA==RpmtTv1zz2w@mail.gmail.com> (raw)
In-Reply-To: <m3ei1dsd1x.fsf@localhost.localdomain>

> Which means that it works in this case:
>
>
>                        bad bad bad
>                   BAD
>   good good good
>
>
> but won't work in this case:
>
>
>
>   good good good               good good good
>                   bad bad bad
>

Of course, this doesn't mean that bisection is useless, only that you
have to choose the right kind of test!

So, while it is true that a commit local test such as those I was
proposing (e.g. git ls-tree or even my suggested tweak git rev-list
--objects --max-count=1) will be useless unless you happen to start
with the tip at the bad commit, it is not true that bisection in
general is useless.

For example, Junio's unconstrained git rev-list --objects | git
pack-objects test will be sufficient because a history that is

    good good good bad bad bad good good good

according to a commit local test, will be:

     bad bad bad bad bad bad bad good good good

from the point of view of a test that reaches the entire graph
reachable from a commit.

It will still be beneficial to do log(N) executions of git rev-list
--objects instead of  N executions of the same.

jon.

      parent reply	other threads:[~2011-07-26 13:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-24  5:57 [RFC 0/9] bisect: allow git bisect to be used with repos containing damaged trees Jon Seymour
2011-07-24  5:57 ` [PATCH 1/9] bisect: add tests to document expected behaviour in presence of broken trees Jon Seymour
2011-07-24  5:57 ` [PATCH 2/9] bisect: introduce a --ignore-checkout-failure option to bisect--helper Jon Seymour
2011-07-24  5:57 ` [PATCH 3/9] bisect: implement support for --ignore-checkout-failure option Jon Seymour
2011-07-24  5:57 ` [PATCH 4/9] bisect: introduce a helper function to tolerate checkout failures Jon Seymour
2011-07-24  5:57 ` [PATCH 5/9] bisect: replace existing calls to git checkout with bisect_checkout_with_ignore Jon Seymour
2011-07-24  5:57 ` [PATCH 6/9] bisect: enable --ignore-checkout-failure in the porcelain Jon Seymour
2011-07-24  5:57 ` [PATCH 7/9] bisect: better diagnostics, in case of mis-typed option Jon Seymour
2011-07-24  5:57 ` [PATCH 8/9] bisect: add tests for --ignore-checkout-failure option Jon Seymour
2011-07-24  5:57 ` [PATCH 9/9] bisect: add documentation " Jon Seymour
2011-07-24  8:05 ` [RFC 0/9] bisect: allow git bisect to be used with repos containing damaged trees Johannes Sixt
2011-07-24  8:54   ` Jon Seymour
2011-07-24 18:35 ` Junio C Hamano
2011-07-25  9:28   ` Jon Seymour
2011-07-25 18:14     ` Junio C Hamano
2011-07-25 23:27       ` Jon Seymour
2011-07-25 18:48     ` Johannes Sixt
2011-07-25 23:38       ` Jon Seymour
2011-07-26  7:43         ` Jakub Narebski
2011-07-26  8:26           ` Jon Seymour
2011-07-26 13:28           ` Jon Seymour [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH3AnroGQML+FV_Zh9u35bOBed00bk3qcQ1qA==RpmtTv1zz2w@mail.gmail.com' \
    --to=jon.seymour@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j6t@kdbg.org \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.