From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugeniu Rosca Date: Fri, 14 Jun 2019 15:56:57 +0200 Subject: [U-Boot] [PATCH v4 1/2] cmd: part: Add 'number' sub-command In-Reply-To: References: <20190614130454.26797-1-igor.opaniuk@gmail.com> <20190614130454.26797-2-igor.opaniuk@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Roman, On Fri, Jun 14, 2019 at 3:26 PM Roman Stratiienko wrote: > > On Fri, Jun 14, 2019 at 4:04 PM Igor Opaniuk wrote: > > From: Ruslan Trofymenko [..] > > This sub-command serves for getting the partition index from [..] > > + CMD_PART_INFO_NUMBER [..] > > + "part number \n" [..] > Hello Igor, > > It would be nice if you would address Eugeniy Rosca comment ( > https://patchwork.ozlabs.org/patch/1044151/ ), > and rename 'number' to 'index' I believe the author and reviewers lean towards "partition number" instead of "partition index" (even if the two are used intermixed in the patch). I won't argue against that. Thanks for your comment. -- Best regards, Eugeniu.