All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH bpf-next] tools: bpftool: doc, add text about feature-subcommand
@ 2019-02-06  1:45 Prashant Bhole
  2019-02-06  6:26 ` Y Song
  2019-02-06  9:42 ` Quentin Monnet
  0 siblings, 2 replies; 3+ messages in thread
From: Prashant Bhole @ 2019-02-06  1:45 UTC (permalink / raw)
  To: Alexei Starovoitov, Daniel Borkmann; +Cc: Prashant Bhole, netdev

This patch adds missing information about feature-subcommand in
bpftool.rst

Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
---
 tools/bpf/bpftool/Documentation/bpftool.rst | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/bpf/bpftool/Documentation/bpftool.rst b/tools/bpf/bpftool/Documentation/bpftool.rst
index 27153bb816ac..0685d5ada3ce 100644
--- a/tools/bpf/bpftool/Documentation/bpftool.rst
+++ b/tools/bpf/bpftool/Documentation/bpftool.rst
@@ -16,7 +16,7 @@ SYNOPSIS
 
 	**bpftool** **version**
 
-	*OBJECT* := { **map** | **program** | **cgroup** | **perf** | **net** }
+	*OBJECT* := { **map** | **program** | **cgroup** | **perf** | **net** | **feature** }
 
 	*OPTIONS* := { { **-V** | **--version** } | { **-h** | **--help** }
 	| { **-j** | **--json** } [{ **-p** | **--pretty** }] }
@@ -34,6 +34,8 @@ SYNOPSIS
 
 	*NET-COMMANDS* := { **show** | **list** | **help** }
 
+        *FEATURE-COMMANDS* := { **probe** | **help** }
+
 DESCRIPTION
 ===========
 	*bpftool* allows for inspection and simple modification of BPF objects
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH bpf-next] tools: bpftool: doc, add text about feature-subcommand
  2019-02-06  1:45 [PATCH bpf-next] tools: bpftool: doc, add text about feature-subcommand Prashant Bhole
@ 2019-02-06  6:26 ` Y Song
  2019-02-06  9:42 ` Quentin Monnet
  1 sibling, 0 replies; 3+ messages in thread
From: Y Song @ 2019-02-06  6:26 UTC (permalink / raw)
  To: Prashant Bhole; +Cc: Alexei Starovoitov, Daniel Borkmann, netdev

On Tue, Feb 5, 2019 at 6:25 PM Prashant Bhole
<bhole_prashant_q7@lab.ntt.co.jp> wrote:
>
> This patch adds missing information about feature-subcommand in
> bpftool.rst
>
> Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>

Acked-by: Yonghong Song <yhs@fb.com>

> ---
>  tools/bpf/bpftool/Documentation/bpftool.rst | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/bpf/bpftool/Documentation/bpftool.rst b/tools/bpf/bpftool/Documentation/bpftool.rst
> index 27153bb816ac..0685d5ada3ce 100644
> --- a/tools/bpf/bpftool/Documentation/bpftool.rst
> +++ b/tools/bpf/bpftool/Documentation/bpftool.rst
> @@ -16,7 +16,7 @@ SYNOPSIS
>
>         **bpftool** **version**
>
> -       *OBJECT* := { **map** | **program** | **cgroup** | **perf** | **net** }
> +       *OBJECT* := { **map** | **program** | **cgroup** | **perf** | **net** | **feature** }
>
>         *OPTIONS* := { { **-V** | **--version** } | { **-h** | **--help** }
>         | { **-j** | **--json** } [{ **-p** | **--pretty** }] }
> @@ -34,6 +34,8 @@ SYNOPSIS
>
>         *NET-COMMANDS* := { **show** | **list** | **help** }
>
> +        *FEATURE-COMMANDS* := { **probe** | **help** }
> +
>  DESCRIPTION
>  ===========
>         *bpftool* allows for inspection and simple modification of BPF objects
> --
> 2.20.1
>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH bpf-next] tools: bpftool: doc, add text about feature-subcommand
  2019-02-06  1:45 [PATCH bpf-next] tools: bpftool: doc, add text about feature-subcommand Prashant Bhole
  2019-02-06  6:26 ` Y Song
@ 2019-02-06  9:42 ` Quentin Monnet
  1 sibling, 0 replies; 3+ messages in thread
From: Quentin Monnet @ 2019-02-06  9:42 UTC (permalink / raw)
  To: Prashant Bhole, Alexei Starovoitov, Daniel Borkmann; +Cc: netdev

2019-02-06 10:45 UTC+0900 ~ Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
> This patch adds missing information about feature-subcommand in
> bpftool.rst
> 
> Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>

My bad, thanks a lot for the update!

> ---
>   tools/bpf/bpftool/Documentation/bpftool.rst | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/bpf/bpftool/Documentation/bpftool.rst b/tools/bpf/bpftool/Documentation/bpftool.rst
> index 27153bb816ac..0685d5ada3ce 100644
> --- a/tools/bpf/bpftool/Documentation/bpftool.rst
> +++ b/tools/bpf/bpftool/Documentation/bpftool.rst
> @@ -16,7 +16,7 @@ SYNOPSIS
>   
>   	**bpftool** **version**
>   
> -	*OBJECT* := { **map** | **program** | **cgroup** | **perf** | **net** }
> +	*OBJECT* := { **map** | **program** | **cgroup** | **perf** | **net** | **feature** }
>   
>   	*OPTIONS* := { { **-V** | **--version** } | { **-h** | **--help** }
>   	| { **-j** | **--json** } [{ **-p** | **--pretty** }] }
> @@ -34,6 +34,8 @@ SYNOPSIS
>   
>   	*NET-COMMANDS* := { **show** | **list** | **help** }
>   
> +        *FEATURE-COMMANDS* := { **probe** | **help** }

Could you please fix this line to use a tab instead of spaces for 
indent, as for the rest of the file?

> +
>   DESCRIPTION
>   ===========
>   	*bpftool* allows for inspection and simple modification of BPF objects
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-02-06  9:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-06  1:45 [PATCH bpf-next] tools: bpftool: doc, add text about feature-subcommand Prashant Bhole
2019-02-06  6:26 ` Y Song
2019-02-06  9:42 ` Quentin Monnet

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.