From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5312C43381 for ; Thu, 7 Mar 2019 01:34:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B250120663 for ; Thu, 7 Mar 2019 01:34:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IzZU7h/D" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726525AbfCGBe5 (ORCPT ); Wed, 6 Mar 2019 20:34:57 -0500 Received: from mail-io1-f66.google.com ([209.85.166.66]:39271 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726010AbfCGBe5 (ORCPT ); Wed, 6 Mar 2019 20:34:57 -0500 Received: by mail-io1-f66.google.com with SMTP id x3so12022333ior.6 for ; Wed, 06 Mar 2019 17:34:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iFrfnd7Zssg80ApVk7U6z7sTDyvFHT98GMfWWVM/79U=; b=IzZU7h/DFwq4ph7CSZ1UB07LFoJgJrIC3iGZUHrSGdn7Xa1pnRmMOeD3Eb/J0uE7LK tmOUorMspPTXM4yCNRnHz1v9oaCofVZO7DQbQAja+hZt7EE1NMG4Lvks/1Hh2UXDsDuB gLVgIVh+hQrH7VuXZfO6q8jv6hGUtKFdy9gkR/wePeih9XOvvu2JvI2exXRZCoFtm7eH rRurnC1n12t/Vkvkyr2QAZk2erEEvieo3cH9NZ+FHRZ+SjtNB1Tx/iZB70g1fe//rrJ/ HzCQFIacv2On2aBQiBxPEsAtzp4PPW/gD8jF9Gs6BNfICBWRAAjQrIllwwlJCJhy2sqs LSLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iFrfnd7Zssg80ApVk7U6z7sTDyvFHT98GMfWWVM/79U=; b=GAxgKrH+DWDuFDvm8t7oJ/QD1u0Naf8TfcCAZdd6w1JtwqPQHObOPmk6uJ7i82IYIh HpdA/iBF55G1My5MDj7BXwGZh4EsWIuBx5R875GQXPtXaIW9WkGmFaBOAASVERqcuN1w RbtnDXppYKQItGGmGsnSilzDsRWmuOMd8XVWBqHfJ84+VXnzG8OzFpv7XGm3NGsW08fE u2Y1GgKm06KvUOSjERycykk3yxkFADq3Yypr9uG4g0Z0z6IpIt+We0m4suKx7Q1buabY Ewug5tg4OHkYUVLDstFgYhwarKG2v7oa6xdRL+4wr+BgcmvjqfW6j9B4S+yhKr4cVP4z ms9A== X-Gm-Message-State: APjAAAXjapcxMHBLEzLXYOb+B4If7jhavpBEKyaR97k0XBjwg4s6zIWE Mt5HmwjurYS7mzbLBprdAZw/kHSTpmOyjoRe7s8= X-Google-Smtp-Source: APXvYqzSiZli9DbvCGye/4W7qPiZ49LIDSyduvtlPERniQxNIV6W8NqdjPW+6/Z/KF+x7wjcC2giakaMtP/by6blENs= X-Received: by 2002:a5d:8784:: with SMTP id f4mr4813671ion.89.1551922496093; Wed, 06 Mar 2019 17:34:56 -0800 (PST) MIME-Version: 1.0 References: <20190306193515.125072-1-willemdebruijn.kernel@gmail.com> In-Reply-To: <20190306193515.125072-1-willemdebruijn.kernel@gmail.com> From: Y Song Date: Wed, 6 Mar 2019 17:34:20 -0800 Message-ID: Subject: Re: [PATCH bpf] bpf: only test gso type on gso packets To: Willem de Bruijn Cc: netdev , Alexei Starovoitov , Daniel Borkmann , Willem de Bruijn Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Mar 6, 2019 at 1:15 PM Willem de Bruijn wrote: > > From: Willem de Bruijn > > BPF can adjust gso only for tcp bytestreams. Fail on other gso types. > > But only on gso packets. It does not touch this field if !gso_size. Could you specify which field you are referring here? gso_type, gso_segs, gso_size? > > Fixes: b90efd225874 ("bpf: only adjust gso_size on bytestream protocols") > Signed-off-by: Willem de Bruijn Other than the above commit message suggestion, Acked-by: Yonghong Song