From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerome Glisse <j.glisse@gmail.com>
Subject: Re: Fix GPU triggering random system read after VRAM start change
Date: Tue, 31 Jul 2012 11:15:14 -0400
Message-ID: <CAH3drwZAtM-FCEZ=086MB7xKcQE2fjk7zKSfatFtNd9xL1TTdg@mail.gmail.com>
References: <1343421145-14257-1-git-send-email-j.glisse@gmail.com>
	<CADnq5_M5-y1ZxTUyhyu-kv8CXcv5D6dYhX7G9hca1Ti3G8NzZg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mail-qc0-f177.google.com (mail-qc0-f177.google.com
	[209.85.216.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id B5B7D9EC15
	for <dri-devel@lists.freedesktop.org>;
	Tue, 31 Jul 2012 08:15:14 -0700 (PDT)
Received: by qcsu28 with SMTP id u28so3705521qcs.36
	for <dri-devel@lists.freedesktop.org>;
	Tue, 31 Jul 2012 08:15:14 -0700 (PDT)
In-Reply-To: <CADnq5_M5-y1ZxTUyhyu-kv8CXcv5D6dYhX7G9hca1Ti3G8NzZg@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Alex Deucher <alexdeucher@gmail.com>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Tue, Jul 31, 2012 at 10:56 AM, Alex Deucher <alexdeucher@gmail.com> wrote:
> On Fri, Jul 27, 2012 at 4:32 PM,  <j.glisse@gmail.com> wrote:
>> So first patch is a fix in itself, smallest possible and should go to
>> stable. Second patch is an improvement as a first step to flicker free
>> boot.
>
> First patch looks ok.  In mc_stop we should disable the crtc and then
> poll CRTC_CONTROL.CRTC_CURRENT_MASTER_EN_STATE until it goes to 0 to
> make sure the crtc has actually stopped reading before we change the
> mc config.  Other than that,

In all my test is was instantaneous, ie less than 1us to take effect,
so i did not wanted to make the patch bigger than it is. But if you
really think we should do that i can readd that code in patch 1.

Cheers,
Jerome

>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>
>>
>> I have yet extensively tested second patch, especialy not on AGP but
>> so far on few GPU/motherboard it looks good. It can probably wait 3.7.
>> Will test it more and report.
>
> Looks good as well.  A nice clean up to boot.
>
>>
>> I have a third patch that is a step closer to flicker free boot on uefi,
>> waiting ack to release a reg.
>>
>> Cheers,
>> Jerome
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel