From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58990)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <a.rigo@virtualopensystems.com>) id 1a8qWC-000404-6H
	for qemu-devel@nongnu.org; Tue, 15 Dec 2015 09:23:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <a.rigo@virtualopensystems.com>) id 1a8qW6-0004dS-Gb
	for qemu-devel@nongnu.org; Tue, 15 Dec 2015 09:23:56 -0500
Received: from mail-ig0-x229.google.com ([2607:f8b0:4001:c05::229]:33187)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <a.rigo@virtualopensystems.com>) id 1a8qW6-0004dM-Bd
	for qemu-devel@nongnu.org; Tue, 15 Dec 2015 09:23:50 -0500
Received: by mail-ig0-x229.google.com with SMTP id mv3so103977985igc.0
	for <qemu-devel@nongnu.org>; Tue, 15 Dec 2015 06:23:50 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <566E9685.4030606@redhat.com>
References: <1450082498-27109-1-git-send-email-a.rigo@virtualopensystems.com>
	<1450082498-27109-7-git-send-email-a.rigo@virtualopensystems.com>
	<566E9685.4030606@redhat.com>
Date: Tue, 15 Dec 2015 15:23:49 +0100
Message-ID: <CAH47eN18QJTXeobzgvV9puJqffKoyt-W0qQ4AE3yr0Xx67Q_vQ@mail.gmail.com>
From: alvise rigo <a.rigo@virtualopensystems.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [RFC v6 06/14] configure: Use slow-path for atomic
 only when the softmmu is enabled
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <lvivier@redhat.com>
Cc: mttcg@greensocs.com, Claudio Fontana <claudio.fontana@huawei.com>, QEMU Developers <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>, Jani Kokkonen <jani.kokkonen@huawei.com>, VirtualOpenSystems Technical Team <tech@virtualopensystems.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, Richard Henderson <rth@twiddle.net>

Hi,

On Mon, Dec 14, 2015 at 11:14 AM, Laurent Vivier <lvivier@redhat.com> wrote:
>
>
> On 14/12/2015 09:41, Alvise Rigo wrote:
>> Use the new slow path for atomic instruction translation when the
>> softmmu is enabled.
>>
>> Suggested-by: Jani Kokkonen <jani.kokkonen@huawei.com>
>> Suggested-by: Claudio Fontana <claudio.fontana@huawei.com>
>> Signed-off-by: Alvise Rigo <a.rigo@virtualopensystems.com>
>> ---
>>  configure | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/configure b/configure
>> index b9552fd..cc3891a 100755
>> --- a/configure
>> +++ b/configure
>> @@ -4794,6 +4794,7 @@ echo "Install blobs     $blobs"
>>  echo "KVM support       $kvm"
>>  echo "RDMA support      $rdma"
>>  echo "TCG interpreter   $tcg_interpreter"
>> +echo "use ld/st excl    $softmmu"
>>  echo "fdt support       $fdt"
>>  echo "preadv support    $preadv"
>>  echo "fdatasync         $fdatasync"
>> @@ -5186,6 +5187,9 @@ fi
>>  if test "$tcg_interpreter" = "yes" ; then
>>    echo "CONFIG_TCG_INTERPRETER=y" >> $config_host_mak
>>  fi
>> +if test "$softmmu" = "yes" ; then
>> +  echo "CONFIG_TCG_USE_LDST_EXCL=y" >> $config_host_mak
>> +fi
>
> why is this "$softmmu" and not "$target_softmmu" ?

I see now that is $target_softmmu setting CONFIG_SOFTMMU=y.
So for my understanding, which are the cases where $softmmu is set
while $target_softmmu is not?

Thank you,
alvise

>
>>  if test "$fdatasync" = "yes" ; then
>>    echo "CONFIG_FDATASYNC=y" >> $config_host_mak
>>  fi
>>