From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIabP-0004oM-5u for qemu-devel@nongnu.org; Wed, 26 Feb 2014 04:16:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WIabJ-0003VJ-Qn for qemu-devel@nongnu.org; Wed, 26 Feb 2014 04:16:31 -0500 Received: from mail-ie0-f180.google.com ([209.85.223.180]:41970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIabJ-0003VF-LQ for qemu-devel@nongnu.org; Wed, 26 Feb 2014 04:16:25 -0500 Received: by mail-ie0-f180.google.com with SMTP id ar20so433258iec.11 for ; Wed, 26 Feb 2014 01:16:24 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <1393347170-28502-1-git-send-email-a.rigo@virtualopensystems.com> <1393347170-28502-3-git-send-email-a.rigo@virtualopensystems.com> Date: Wed, 26 Feb 2014 10:16:24 +0100 Message-ID: From: alvise rigo Content-Type: multipart/alternative; boundary=90e6ba6e8820ac0bd804f34ba8dd Subject: Re: [Qemu-devel] [RFC 2/4] Added flag in ARMCPU to track last execution mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "tech@virtualopensystems.com" , QEMU Developers --90e6ba6e8820ac0bd804f34ba8dd Content-Type: text/plain; charset=ISO-8859-1 I see, but how can we know the type of migration (KVM to TCG or TCG to KVM) which is taking place only looking at the incoming data? Of course, I'm supposing that the two cases will require different handling and so that distinguish the migration type (at the destination) has to be part of the process. thanks, alvise On Tue, Feb 25, 2014 at 7:19 PM, Peter Maydell wrote: > On 25 February 2014 16:52, Alvise Rigo > wrote: > > The value of this flag indicates the execution mode of the CPU prior the > > migration. It is used to handle the KVM <-> TCG migration. > > > > Signed-off-by: Alvise Rigo > > --- > > target-arm/cpu-qom.h | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/target-arm/cpu-qom.h b/target-arm/cpu-qom.h > > index afbd422..6819bfc 100644 > > --- a/target-arm/cpu-qom.h > > +++ b/target-arm/cpu-qom.h > > @@ -102,6 +102,9 @@ typedef struct ARMCPU { > > */ > > uint32_t kvm_target; > > > > + /* true if this cpu is using KVM. Read and set in cpu_pre/post_load > */ > > + bool running_kvm; > > This is definitely wrong. We should not care whether either > end of the migration connection is using KVM. > > thanks > -- PMM > --90e6ba6e8820ac0bd804f34ba8dd Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
I see, but how can we know the type of migration (KVM= to TCG or TCG to
KVM) which is taking place only looking at the incomin= g data? Of course,
I'm supposing that the two cases will require dif= ferent handling and so
that distinguish the migration type (at the destination) has to = be part
of the process.

thanks,
alvise



On Tue, Feb 25, 2014 at 7:19 PM, Peter Maydell <= span dir=3D"ltr"><peter.maydell@linaro.org> wrote:
On 25 February 2014 16:52, Alvise Rigo <a.rigo@virtualopensystems.com> wrot= e:
> The value of this flag indicates the execution mode of the CPU prior t= he
> migration. It is used to handle the KVM <-> TCG migration.
>
> Signed-off-by: Alvise Rigo <a.rigo@virtualopensystems.com>
> ---
> =A0target-arm/cpu-qom.h | 3 +++
> =A01 file changed, 3 insertions(+)
>
> diff --git a/target-arm/cpu-qom.h b/target-arm/cpu-qom.h
> index afbd422..6819bfc 100644
> --- a/target-arm/cpu-qom.h
> +++ b/target-arm/cpu-qom.h
> @@ -102,6 +102,9 @@ typedef struct ARMCPU {
> =A0 =A0 =A0 */
> =A0 =A0 =A0uint32_t kvm_target;
>
> + =A0 =A0/* true if this cpu is using KVM. Read and set in cpu_pre/pos= t_load */
> + =A0 =A0bool running_kvm;

This is definitely wrong. We should not care whether either
end of the migration connection is using KVM.

thanks
-- PMM

--90e6ba6e8820ac0bd804f34ba8dd--