From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757923AbbFQHgP (ORCPT ); Wed, 17 Jun 2015 03:36:15 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:36772 "EHLO mail-wg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757753AbbFQHgM (ORCPT ); Wed, 17 Jun 2015 03:36:12 -0400 MIME-Version: 1.0 In-Reply-To: <1434515761-14796-1-git-send-email-maninder1.s@samsung.com> References: <1434515761-14796-1-git-send-email-maninder1.s@samsung.com> Date: Wed, 17 Jun 2015 09:36:11 +0200 Message-ID: Subject: Re: [RESUBMIT Patch 1/1] net: replace if()/BUG with BUG_ON From: Frans Klaver To: Maninder Singh Cc: davem@davemloft.net, willemb@google.com, dborkman@redhat.com, al.drozdov@gmail.com, Al Viro , eyal.birger@gmail.com, mst@redhat.com, netdev , "linux-kernel@vger.kernel.org" , pankaj.m@samsung.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 17, 2015 at 6:36 AM, Maninder Singh wrote: > Use BUG_ON(condition) instead of if(condition)/BUG() . > > Signed-off-by: Maninder Singh > Reviewed-by: Akhilesh Kumar > --- > net/packet/af_packet.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c > index b5989c6..c91d405 100644 > --- a/net/packet/af_packet.c > +++ b/net/packet/af_packet.c > @@ -547,8 +547,7 @@ static void prb_setup_retire_blk_timer(struct packet_sock *po, int tx_ring) > { > struct tpacket_kbdq_core *pkc; > > - if (tx_ring) > - BUG(); > + BUG_ON(tx_ring); > > pkc = tx_ring ? GET_PBDQC_FROM_RB(&po->tx_ring) : > GET_PBDQC_FROM_RB(&po->rx_ring); I don't get this. We're not allowed to be using tx_ring, but we can and do handle it? Does that still warrant a BUG() or BUG_ON()? It's been in since the function introduction[0]. Can somebody explain? Thanks, Frans [0] f6fb8f100b80 (af-packet: TPACKET_V3 flexible buffer implementation.)