From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frans Klaver Subject: Re: [PATCH 14/14] staging: ccree: fix block comment style Date: Thu, 29 Jun 2017 16:38:14 +0200 Message-ID: References: <1498548449-10803-1-git-send-email-gilad@benyossef.com> <1498548449-10803-15-git-send-email-gilad@benyossef.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: driverdevel , Greg Kroah-Hartman , driverdev-devel@linuxdriverproject.org, "linux-kernel@vger.kernel.org" , linux-crypto@vger.kernel.org, Ofir Drang To: Gilad Ben-Yossef Return-path: In-Reply-To: <1498548449-10803-15-git-send-email-gilad@benyossef.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: linux-crypto.vger.kernel.org On Tue, Jun 27, 2017 at 9:27 AM, Gilad Ben-Yossef wrote: > Align block comments according to coding style. > > Signed-off-by: Gilad Ben-Yossef > --- > drivers/staging/ccree/cc_hw_queue_defs.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h > index f11487a..e6b8cea 100644 > --- a/drivers/staging/ccree/cc_hw_queue_defs.h > +++ b/drivers/staging/ccree/cc_hw_queue_defs.h > @@ -23,8 +23,8 @@ > #include > > /****************************************************************************** > -* DEFINITIONS > -******************************************************************************/ > + * DEFINITIONS > + ******************************************************************************/ I think if you change to the preferred block comment format, you should also drop these lines full of asterisks. I'm not sure why a multi-line comment is warranted here, anyway. Frans From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753375AbdF2OiZ (ORCPT ); Thu, 29 Jun 2017 10:38:25 -0400 Received: from mail-ua0-f196.google.com ([209.85.217.196]:36709 "EHLO mail-ua0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753115AbdF2OiQ (ORCPT ); Thu, 29 Jun 2017 10:38:16 -0400 MIME-Version: 1.0 In-Reply-To: <1498548449-10803-15-git-send-email-gilad@benyossef.com> References: <1498548449-10803-1-git-send-email-gilad@benyossef.com> <1498548449-10803-15-git-send-email-gilad@benyossef.com> From: Frans Klaver Date: Thu, 29 Jun 2017 16:38:14 +0200 Message-ID: Subject: Re: [PATCH 14/14] staging: ccree: fix block comment style To: Gilad Ben-Yossef Cc: Greg Kroah-Hartman , linux-crypto@vger.kernel.org, driverdev-devel@linuxdriverproject.org, driverdevel , "linux-kernel@vger.kernel.org" , Ofir Drang Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 27, 2017 at 9:27 AM, Gilad Ben-Yossef wrote: > Align block comments according to coding style. > > Signed-off-by: Gilad Ben-Yossef > --- > drivers/staging/ccree/cc_hw_queue_defs.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h > index f11487a..e6b8cea 100644 > --- a/drivers/staging/ccree/cc_hw_queue_defs.h > +++ b/drivers/staging/ccree/cc_hw_queue_defs.h > @@ -23,8 +23,8 @@ > #include > > /****************************************************************************** > -* DEFINITIONS > -******************************************************************************/ > + * DEFINITIONS > + ******************************************************************************/ I think if you change to the preferred block comment format, you should also drop these lines full of asterisks. I'm not sure why a multi-line comment is warranted here, anyway. Frans From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 9DC101C04A3 for ; Thu, 29 Jun 2017 14:38:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 93BA087835 for ; Thu, 29 Jun 2017 14:38:16 +0000 (UTC) Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BDO-QqwlRnV9 for ; Thu, 29 Jun 2017 14:38:16 +0000 (UTC) Received: from mail-ua0-f193.google.com (mail-ua0-f193.google.com [209.85.217.193]) by whitealder.osuosl.org (Postfix) with ESMTPS id D7F4B87821 for ; Thu, 29 Jun 2017 14:38:15 +0000 (UTC) Received: by mail-ua0-f193.google.com with SMTP id w19so6840273uac.0 for ; Thu, 29 Jun 2017 07:38:15 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1498548449-10803-15-git-send-email-gilad@benyossef.com> References: <1498548449-10803-1-git-send-email-gilad@benyossef.com> <1498548449-10803-15-git-send-email-gilad@benyossef.com> From: Frans Klaver Date: Thu, 29 Jun 2017 16:38:14 +0200 Message-ID: Subject: Re: [PATCH 14/14] staging: ccree: fix block comment style List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Gilad Ben-Yossef Cc: driverdevel , Greg Kroah-Hartman , driverdev-devel@linuxdriverproject.org, "linux-kernel@vger.kernel.org" , linux-crypto@vger.kernel.org, Ofir Drang On Tue, Jun 27, 2017 at 9:27 AM, Gilad Ben-Yossef wrote: > Align block comments according to coding style. > > Signed-off-by: Gilad Ben-Yossef > --- > drivers/staging/ccree/cc_hw_queue_defs.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h > index f11487a..e6b8cea 100644 > --- a/drivers/staging/ccree/cc_hw_queue_defs.h > +++ b/drivers/staging/ccree/cc_hw_queue_defs.h > @@ -23,8 +23,8 @@ > #include > > /****************************************************************************** > -* DEFINITIONS > -******************************************************************************/ > + * DEFINITIONS > + ******************************************************************************/ I think if you change to the preferred block comment format, you should also drop these lines full of asterisks. I'm not sure why a multi-line comment is warranted here, anyway. Frans _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel