From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964868AbbDOGdD (ORCPT ); Wed, 15 Apr 2015 02:33:03 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:37228 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932535AbbDOGc5 (ORCPT ); Wed, 15 Apr 2015 02:32:57 -0400 MIME-Version: 1.0 In-Reply-To: References: <20150414203303.702062272@linutronix.de> <20150414203500.645454122@linutronix.de> Date: Wed, 15 Apr 2015 08:32:56 +0200 Message-ID: Subject: Re: [patch 02/39] hrtimer: Get rid of the resolution field in hrtimer_clock_base From: Frans Klaver To: Thomas Gleixner Cc: LKML , Peter Zijlstra , Ingo Molnar , Preeti U Murthy , Viresh Kumar , Marcelo Tosatti , Frederic Weisbecker Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 15, 2015 at 8:29 AM, Frans Klaver wrote: > On Tue, Apr 14, 2015 at 11:08 PM, Thomas Gleixner wrote: >> The field has no value because all clock bases have the same >> resolution. The resolution only changes when we switch to high >> resolution timer mode. We can evaluate that from a single static >> variable as well. In the !HIGHRES case its simply a constant. >> >> Export the variable, so we can simplify the usage sites. > > There seems to be only one usage site outside hrtimer.c itself. That > one only reads the value. OK, this is incorrect. Still, if it's only meant to be read from outside hrtimer.c: > Wouldn't it make sense to keep the variable > from the interface and use a read function instead? Thanks, Frans