From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com ([209.85.128.194]:42534 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751809AbeDZTTT (ORCPT ); Thu, 26 Apr 2018 15:19:19 -0400 Received: by mail-wr0-f194.google.com with SMTP id v5-v6so7087904wrf.9 for ; Thu, 26 Apr 2018 12:19:18 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180426183707.GA24867@kroah.com> References: <20180426183707.GA24867@kroah.com> From: Dmitry Shmidt Date: Thu, 26 Apr 2018 12:19:17 -0700 Message-ID: Subject: Re: console: Drop added "static" for newport_con To: Greg KH Cc: stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: stable-owner@vger.kernel.org List-ID: On Thu, Apr 26, 2018 at 11:37 AM, Greg KH wrote: > On Thu, Apr 26, 2018 at 10:46:50AM -0700, Dmitry Shmidt wrote: >> Please add this patch to stable 4.14 >> >> commit f54450ad1942287cc76b38021c0441fc4901d2de >> Author: Kees Cook >> Date: Tue Feb 27 13:11:21 2018 -0800 >> >> console: Drop added "static" for newport_con >> >> Commit 4fe505119778 ("console: Expand dummy functions for CFI") accidentally >> added "static" to newport_con instance of struct consw, while trying to >> normalize the declarations. This, however, needed to stay non-static as it >> has an extern. >> >> Reported-by: kbuild test robot >> Fixes: 4fe505119778 ("console: Expand dummy functions for CFI") >> Signed-off-by: Kees Cook >> Signed-off-by: Greg Kroah-Hartman > > > Why does 4.14.y need it? https://kernelci.org/build/android/branch/android-4.14/kernel/ASB-2018-04-05_4.14-637-gbb60f28e486c/ Errors Summary 2drivers/video/console/newport_con.c:683:27: error: static declaration of 'newport_con' follows non-static declaration > It really fixes commit c396a5bf457f ("console: Expand dummy functions > for CFI") which only showed up in 4.17-rc1. > > Why would 4.14.y need it? > > confused, > > greg k-h