From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeffrey Walton Subject: Re: [lkp-robot] [x86/kconfig] 81d3871900: BUG:unable_to_handle_kernel Date: Fri, 13 Oct 2017 16:17:45 -0400 Message-ID: References: <20171010121513.GC5445@yexl-desktop> <20171011023106.izaulhwjcoam55jt@treble> <20171011170120.7flnk6r77dords7a@treble> <20171013044521.662ck56gkwaw3xog@treble> <9a1c3232-86e3-7301-23f8-50116abf37d3@virtuozzo.com> Reply-To: noloader@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Andrey Ryabinin , Josh Poimboeuf , Christopher Lameter , kernel test robot , Ingo Molnar , Andy Lutomirski , Borislav Petkov , Brian Gerst , Denys Vlasenko , "H. Peter Anvin" , Jiri Slaby , Mike Galbraith , Peter Zijlstra , Thomas Gleixner , LKML , LKP , linux-mm , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Megha Dey To: Linus Torvalds Return-path: Received: from mail-oi0-f65.google.com ([209.85.218.65]:38304 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750973AbdJMURq (ORCPT ); Fri, 13 Oct 2017 16:17:46 -0400 In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: On Fri, Oct 13, 2017 at 3:09 PM, Linus Torvalds wrote: > On Fri, Oct 13, 2017 at 6:56 AM, Andrey Ryabinin > wrote: >> >> This could be fixed by s/vmovdqa/vmovdqu change like bellow, but maybe the right fix >> would be to align the data properly? > > I suspect anything that has the SHA extensions should also do > unaligned loads efficiently. The whole "aligned only" model is broken. > It's just doing two loads from the state pointer, there's likely no > point in trying to align it. +1, good engineering. AVX2 requires 32-byte buffer alignment in some places. It is trickier than this use case because __BIGGEST_ALIGNMENT__ doubled, but a lot of code still assumes 16-bytes. Jeff From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751952AbdJMURs (ORCPT ); Fri, 13 Oct 2017 16:17:48 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:38304 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750973AbdJMURq (ORCPT ); Fri, 13 Oct 2017 16:17:46 -0400 X-Google-Smtp-Source: AOwi7QBDVYWBjCWSaoet63bbseeU9mjPUXBlv9SjZsgYjOdqhwo1PXQm1OglkTJ+xb+nyDJP2fun8Qq1eJuVEqaal1I= MIME-Version: 1.0 Reply-To: noloader@gmail.com In-Reply-To: References: <20171010121513.GC5445@yexl-desktop> <20171011023106.izaulhwjcoam55jt@treble> <20171011170120.7flnk6r77dords7a@treble> <20171013044521.662ck56gkwaw3xog@treble> <9a1c3232-86e3-7301-23f8-50116abf37d3@virtuozzo.com> From: Jeffrey Walton Date: Fri, 13 Oct 2017 16:17:45 -0400 Message-ID: Subject: Re: [lkp-robot] [x86/kconfig] 81d3871900: BUG:unable_to_handle_kernel To: Linus Torvalds Cc: Andrey Ryabinin , Josh Poimboeuf , Christopher Lameter , kernel test robot , Ingo Molnar , Andy Lutomirski , Borislav Petkov , Brian Gerst , Denys Vlasenko , "H. Peter Anvin" , Jiri Slaby , Mike Galbraith , Peter Zijlstra , Thomas Gleixner , LKML , LKP , linux-mm , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Megha Dey , Herbert Xu , "David S. Miller" , Linux Crypto Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 13, 2017 at 3:09 PM, Linus Torvalds wrote: > On Fri, Oct 13, 2017 at 6:56 AM, Andrey Ryabinin > wrote: >> >> This could be fixed by s/vmovdqa/vmovdqu change like bellow, but maybe the right fix >> would be to align the data properly? > > I suspect anything that has the SHA extensions should also do > unaligned loads efficiently. The whole "aligned only" model is broken. > It's just doing two loads from the state pointer, there's likely no > point in trying to align it. +1, good engineering. AVX2 requires 32-byte buffer alignment in some places. It is trickier than this use case because __BIGGEST_ALIGNMENT__ doubled, but a lot of code still assumes 16-bytes. Jeff From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f72.google.com (mail-oi0-f72.google.com [209.85.218.72]) by kanga.kvack.org (Postfix) with ESMTP id 2E81F6B026D for ; Fri, 13 Oct 2017 16:17:47 -0400 (EDT) Received: by mail-oi0-f72.google.com with SMTP id l5so6834936oib.0 for ; Fri, 13 Oct 2017 13:17:47 -0700 (PDT) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id k22sor702000otb.94.2017.10.13.13.17.46 for (Google Transport Security); Fri, 13 Oct 2017 13:17:46 -0700 (PDT) MIME-Version: 1.0 Reply-To: noloader@gmail.com In-Reply-To: References: <20171010121513.GC5445@yexl-desktop> <20171011023106.izaulhwjcoam55jt@treble> <20171011170120.7flnk6r77dords7a@treble> <20171013044521.662ck56gkwaw3xog@treble> <9a1c3232-86e3-7301-23f8-50116abf37d3@virtuozzo.com> From: Jeffrey Walton Date: Fri, 13 Oct 2017 16:17:45 -0400 Message-ID: Subject: Re: [lkp-robot] [x86/kconfig] 81d3871900: BUG:unable_to_handle_kernel Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org List-ID: To: Linus Torvalds Cc: Andrey Ryabinin , Josh Poimboeuf , Christopher Lameter , kernel test robot , Ingo Molnar , Andy Lutomirski , Borislav Petkov , Brian Gerst , Denys Vlasenko , "H. Peter Anvin" , Jiri Slaby , Mike Galbraith , Peter Zijlstra , Thomas Gleixner , LKML , LKP , linux-mm , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Megha Dey , Herbert Xu , "David S. Miller" , Linux Crypto Mailing List On Fri, Oct 13, 2017 at 3:09 PM, Linus Torvalds wrote: > On Fri, Oct 13, 2017 at 6:56 AM, Andrey Ryabinin > wrote: >> >> This could be fixed by s/vmovdqa/vmovdqu change like bellow, but maybe the right fix >> would be to align the data properly? > > I suspect anything that has the SHA extensions should also do > unaligned loads efficiently. The whole "aligned only" model is broken. > It's just doing two loads from the state pointer, there's likely no > point in trying to align it. +1, good engineering. AVX2 requires 32-byte buffer alignment in some places. It is trickier than this use case because __BIGGEST_ALIGNMENT__ doubled, but a lot of code still assumes 16-bytes. Jeff -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org