* [U-Boot] [PATCH 1/2] config_fallback: update CONFIG_SYS_BAUDRATE_TABLE
@ 2018-09-06 7:41 Christian Gmeiner
2018-09-06 7:41 ` [U-Boot] [PATCH 2/2] x86_common: drop custom CONFIG_SYS_BAUDRATE_TABLE Christian Gmeiner
2018-09-06 7:58 ` [U-Boot] [PATCH 1/2] config_fallback: update CONFIG_SYS_BAUDRATE_TABLE Bin Meng
0 siblings, 2 replies; 5+ messages in thread
From: Christian Gmeiner @ 2018-09-06 7:41 UTC (permalink / raw)
To: u-boot
Take the values from x86-common.h as inspiration.
Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
---
include/config_fallbacks.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/config_fallbacks.h b/include/config_fallbacks.h
index c18f19a550..4c1bdf5ee5 100644
--- a/include/config_fallbacks.h
+++ b/include/config_fallbacks.h
@@ -26,7 +26,8 @@
#endif
#ifndef CONFIG_SYS_BAUDRATE_TABLE
-#define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 }
+#define CONFIG_SYS_BAUDRATE_TABLE { 300, 600, 1200, 2400, 4800, \
+ 9600, 19200, 38400, 57600, 115200 }
#endif
/* Console I/O Buffer Size */
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 2/2] x86_common: drop custom CONFIG_SYS_BAUDRATE_TABLE
2018-09-06 7:41 [U-Boot] [PATCH 1/2] config_fallback: update CONFIG_SYS_BAUDRATE_TABLE Christian Gmeiner
@ 2018-09-06 7:41 ` Christian Gmeiner
2018-09-06 7:59 ` Bin Meng
2018-09-06 7:58 ` [U-Boot] [PATCH 1/2] config_fallback: update CONFIG_SYS_BAUDRATE_TABLE Bin Meng
1 sibling, 1 reply; 5+ messages in thread
From: Christian Gmeiner @ 2018-09-06 7:41 UTC (permalink / raw)
To: u-boot
Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
---
include/configs/x86-common.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h
index f0b027e69c..78c382de0c 100644
--- a/include/configs/x86-common.h
+++ b/include/configs/x86-common.h
@@ -47,8 +47,6 @@
/*-----------------------------------------------------------------------
* Serial Configuration
*/
-#define CONFIG_SYS_BAUDRATE_TABLE {300, 600, 1200, 2400, 4800, \
- 9600, 19200, 38400, 115200}
#define CONFIG_SYS_NS16550_PORT_MAPPED
/*-----------------------------------------------------------------------
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 1/2] config_fallback: update CONFIG_SYS_BAUDRATE_TABLE
2018-09-06 7:41 [U-Boot] [PATCH 1/2] config_fallback: update CONFIG_SYS_BAUDRATE_TABLE Christian Gmeiner
2018-09-06 7:41 ` [U-Boot] [PATCH 2/2] x86_common: drop custom CONFIG_SYS_BAUDRATE_TABLE Christian Gmeiner
@ 2018-09-06 7:58 ` Bin Meng
2018-09-06 10:50 ` Christian Gmeiner
1 sibling, 1 reply; 5+ messages in thread
From: Bin Meng @ 2018-09-06 7:58 UTC (permalink / raw)
To: u-boot
Hi Christian,
On Thu, Sep 6, 2018 at 3:41 PM Christian Gmeiner
<christian.gmeiner@gmail.com> wrote:
>
> Take the values from x86-common.h as inspiration.
>
> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> ---
> include/config_fallbacks.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/config_fallbacks.h b/include/config_fallbacks.h
> index c18f19a550..4c1bdf5ee5 100644
> --- a/include/config_fallbacks.h
> +++ b/include/config_fallbacks.h
> @@ -26,7 +26,8 @@
> #endif
>
> #ifndef CONFIG_SYS_BAUDRATE_TABLE
> -#define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 }
> +#define CONFIG_SYS_BAUDRATE_TABLE { 300, 600, 1200, 2400, 4800, \
I don't see a value to bring in 300/600/1200 etc .
> + 9600, 19200, 38400, 57600, 115200 }
> #endif
>
> /* Console I/O Buffer Size */
> --
Regards,
Bin
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 2/2] x86_common: drop custom CONFIG_SYS_BAUDRATE_TABLE
2018-09-06 7:41 ` [U-Boot] [PATCH 2/2] x86_common: drop custom CONFIG_SYS_BAUDRATE_TABLE Christian Gmeiner
@ 2018-09-06 7:59 ` Bin Meng
0 siblings, 0 replies; 5+ messages in thread
From: Bin Meng @ 2018-09-06 7:59 UTC (permalink / raw)
To: u-boot
On Thu, Sep 6, 2018 at 3:41 PM Christian Gmeiner
<christian.gmeiner@gmail.com> wrote:
>
I would use "x86" instead of "x86_common" in the commit title.
> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> ---
> include/configs/x86-common.h | 2 --
> 1 file changed, 2 deletions(-)
>
Regards,
Bin
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 1/2] config_fallback: update CONFIG_SYS_BAUDRATE_TABLE
2018-09-06 7:58 ` [U-Boot] [PATCH 1/2] config_fallback: update CONFIG_SYS_BAUDRATE_TABLE Bin Meng
@ 2018-09-06 10:50 ` Christian Gmeiner
0 siblings, 0 replies; 5+ messages in thread
From: Christian Gmeiner @ 2018-09-06 10:50 UTC (permalink / raw)
To: u-boot
Am Do., 6. Sep. 2018 um 09:58 Uhr schrieb Bin Meng <bmeng.cn@gmail.com>:
>
> Hi Christian,
>
> On Thu, Sep 6, 2018 at 3:41 PM Christian Gmeiner
> <christian.gmeiner@gmail.com> wrote:
> >
> > Take the values from x86-common.h as inspiration.
> >
> > Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> > ---
> > include/config_fallbacks.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/config_fallbacks.h b/include/config_fallbacks.h
> > index c18f19a550..4c1bdf5ee5 100644
> > --- a/include/config_fallbacks.h
> > +++ b/include/config_fallbacks.h
> > @@ -26,7 +26,8 @@
> > #endif
> >
> > #ifndef CONFIG_SYS_BAUDRATE_TABLE
> > -#define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 }
> > +#define CONFIG_SYS_BAUDRATE_TABLE { 300, 600, 1200, 2400, 4800, \
>
> I don't see a value to bring in 300/600/1200 etc .
>
I just copied the table from x86 - I am fine with dropping these baud
rates them.
> > + 9600, 19200, 38400, 57600, 115200 }
> > #endif
> >
> > /* Console I/O Buffer Size */
> > --
>
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-09-06 10:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-06 7:41 [U-Boot] [PATCH 1/2] config_fallback: update CONFIG_SYS_BAUDRATE_TABLE Christian Gmeiner
2018-09-06 7:41 ` [U-Boot] [PATCH 2/2] x86_common: drop custom CONFIG_SYS_BAUDRATE_TABLE Christian Gmeiner
2018-09-06 7:59 ` Bin Meng
2018-09-06 7:58 ` [U-Boot] [PATCH 1/2] config_fallback: update CONFIG_SYS_BAUDRATE_TABLE Bin Meng
2018-09-06 10:50 ` Christian Gmeiner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.