From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Gmeiner Subject: Re: [PATCH RFC 024/111] staging: etnaviv: fix multiple command buffer submission in etnaviv_buffer_queue() Date: Sun, 5 Apr 2015 20:36:59 +0200 Message-ID: References: <1427988653-754-1-git-send-email-l.stach@pengutronix.de> <1427988653-754-25-git-send-email-l.stach@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53]) by gabe.freedesktop.org (Postfix) with ESMTP id B0CC76E354 for ; Sun, 5 Apr 2015 11:37:20 -0700 (PDT) Received: by wgra20 with SMTP id a20so12278993wgr.3 for ; Sun, 05 Apr 2015 11:37:19 -0700 (PDT) In-Reply-To: <1427988653-754-25-git-send-email-l.stach@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Lucas Stach Cc: Russell King , Sascha Hauer , DRI mailing list List-Id: dri-devel@lists.freedesktop.org SXMgdGhlcmUgYSByZWFsIHVzZSBjYXNlIHRvIG1ha2UgdXNlIG9mIG11bHRpcGxlIGNvbW1hbmQg YnVmZmVycyBwZXIKb25lIHN1Ym1pdCBpb2N0bD8gSSBoYXZlIHJlbW92ZWQKaXQgZnJvbSBteSBr ZXJuZWwgdHJlZS4KCjIwMTUtMDQtMDIgMTc6MjkgR01UKzAyOjAwIEx1Y2FzIFN0YWNoIDxsLnN0 YWNoQHBlbmd1dHJvbml4LmRlPjoKPiBGcm9tOiBSdXNzZWxsIEtpbmcgPHJtaytrZXJuZWxAYXJt LmxpbnV4Lm9yZy51az4KPgo+IGV0bmF2aXZfYnVmZmVyX3F1ZXVlKCkgY291bGQgbm90IGhhbmRs ZSBtdWx0aXBsZSBjb21tYW5kIGJ1ZmZlcnMuICBXZQo+IGNhbiBoYW5kbGUgdGhpcyB0cml2aWFs bHkgYnkgYWRhcHRpbmcgdGhlIGV4aXN0aW5nIGNvZGUgLSB3ZSByZWNvcmQKPiB3aGVyZSB3ZSB3 YW50IHRvIGxpbmsgdG8sIGFuZCB3YWxrIHRoZSBzdWJtaXR0ZWQgY29tbWFuZCBidWZmZXJzIGlu Cj4gcmV2ZXJzZSBvcmRlciwgYXBwZW5kaW5nIGEgTElOSyBjb21tYW5kIHRvIHRoZSBwcmV2aW91 cyB0YXJnZXQuCj4KPiBUaGlzIGFsc28gbWVhbnMgdGhhdCB3ZSBjb252ZW5pZW50bHkgZW5kIHVw IHdpdGggdGhlIGFkZHJlc3MgYW5kIHNpemUKPiB0byBsaW5rIHRvIHdoZW4gY2hhbmdpbmcgdGhl IHByZXZpb3VzIFdBSVQgY29tbWFuZC4KPgo+IFNpZ25lZC1vZmYtYnk6IFJ1c3NlbGwgS2luZyA8 cm1rK2tlcm5lbEBhcm0ubGludXgub3JnLnVrPgo+IC0tLQo+ICBkcml2ZXJzL3N0YWdpbmcvZXRu YXZpdi9ldG5hdml2X2J1ZmZlci5jIHwgNDUgKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0t LS0KPiAgMSBmaWxlIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDIxIGRlbGV0aW9ucygtKQo+ Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvc3RhZ2luZy9ldG5hdml2L2V0bmF2aXZfYnVmZmVyLmMg Yi9kcml2ZXJzL3N0YWdpbmcvZXRuYXZpdi9ldG5hdml2X2J1ZmZlci5jCj4gaW5kZXggOTQ1YWYy MmRiM2YxLi5iZTJiMDJjZTlhNDYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9zdGFnaW5nL2V0bmF2 aXYvZXRuYXZpdl9idWZmZXIuYwo+ICsrKyBiL2RyaXZlcnMvc3RhZ2luZy9ldG5hdml2L2V0bmF2 aXZfYnVmZmVyLmMKPiBAQCAtMTQ4LDcgKzE0OCw3IEBAIHZvaWQgZXRuYXZpdl9idWZmZXJfcXVl dWUoc3RydWN0IGV0bmF2aXZfZ3B1ICpncHUsIHVuc2lnbmVkIGludCBldmVudCwgc3RydWN0IGV0 Cj4gICAgICAgICBzdHJ1Y3QgZXRuYXZpdl9nZW1fb2JqZWN0ICpidWZmZXIgPSB0b19ldG5hdml2 X2JvKGdwdS0+YnVmZmVyKTsKPiAgICAgICAgIHN0cnVjdCBldG5hdml2X2dlbV9vYmplY3QgKmNt ZDsKPiAgICAgICAgIHUzMiAqbHcgPSBidWZmZXItPnZhZGRyICsgKChidWZmZXItPm9mZnNldCAt IDQpICogNCk7Cj4gLSAgICAgICB1MzIgYmFjazsKPiArICAgICAgIHUzMiBiYWNrLCBsaW5rX3Rh cmdldCwgbGlua19zaXplOwo+ICAgICAgICAgdTMyIGk7Cj4KPiAgICAgICAgIGlmIChkcm1fZGVi dWcgJiBEUk1fVVRfRFJJVkVSKQo+IEBAIC0xNTYsNiArMTU2LDggQEAgdm9pZCBldG5hdml2X2J1 ZmZlcl9xdWV1ZShzdHJ1Y3QgZXRuYXZpdl9ncHUgKmdwdSwgdW5zaWduZWQgaW50IGV2ZW50LCBz dHJ1Y3QgZXQKPgo+ICAgICAgICAgLyogc2F2ZSBvZmZzZXQgYmFjayBpbnRvIG1haW4gYnVmZmVy ICovCj4gICAgICAgICBiYWNrID0gYnVmZmVyLT5vZmZzZXQ7Cj4gKyAgICAgICBsaW5rX3Rhcmdl dCA9IGJ1ZmZlci0+cGFkZHIgKyBidWZmZXItPm9mZnNldCAqIDQ7Cj4gKyAgICAgICBsaW5rX3Np emUgPSA2Owo+Cj4gICAgICAgICAvKiB0cmlnZ2VyIGV2ZW50ICovCj4gICAgICAgICBDTURfTE9B RF9TVEFURShidWZmZXIsIFZJVlNfR0xfRVZFTlQsIFZJVlNfR0xfRVZFTlRfRVZFTlRfSUQoZXZl bnQpIHwgVklWU19HTF9FVkVOVF9GUk9NX1BFKTsKPiBAQCAtMTY1LDI3ICsxNjcsMjggQEAgdm9p ZCBldG5hdml2X2J1ZmZlcl9xdWV1ZShzdHJ1Y3QgZXRuYXZpdl9ncHUgKmdwdSwgdW5zaWduZWQg aW50IGV2ZW50LCBzdHJ1Y3QgZXQKPiAgICAgICAgIENNRF9MSU5LKGJ1ZmZlciwgMiwgYnVmZmVy LT5wYWRkciArICgoYnVmZmVyLT5vZmZzZXQgLSAxKSAqIDQpKTsKPgo+ICAgICAgICAgLyogdXBk YXRlIG9mZnNldCBmb3IgZXZlcnkgY21kIHN0cmVhbSAqLwo+IC0gICAgICAgZm9yIChpID0gMDsg aSA8IHN1Ym1pdC0+bnJfY21kczsgaSsrKQo+IC0gICAgICAgICAgICAgICBzdWJtaXQtPmNtZFtp XS5vYmotPm9mZnNldCA9IHN1Ym1pdC0+Y21kW2ldLm9mZnNldCArCj4gLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3VibWl0LT5jbWRbaV0uc2l6ZTsKPiArICAg ICAgIGZvciAoaSA9IHN1Ym1pdC0+bnJfY21kczsgaS0tOyApIHsKPiArICAgICAgICAgICAgICAg Y21kID0gc3VibWl0LT5jbWRbaV0ub2JqOwo+Cj4gLSAgICAgICAvKiBUT0RPOiBpbnRlci1jb25u ZWN0IGFsbCBjbWQgYnVmZmVycyAqLwo+ICsgICAgICAgICAgICAgICBjbWQtPm9mZnNldCA9IHN1 Ym1pdC0+Y21kW2ldLm9mZnNldCArIHN1Ym1pdC0+Y21kW2ldLnNpemU7Cj4KPiAtICAgICAgIC8q IGp1bXAgYmFjayBmcm9tIGxhc3QgY21kIHRvIG1haW4gYnVmZmVyICovCj4gLSAgICAgICBjbWQg PSBzdWJtaXQtPmNtZFtzdWJtaXQtPm5yX2NtZHMgLSAxXS5vYmo7Cj4gLSAgICAgICBDTURfTElO SyhjbWQsIDQsIGJ1ZmZlci0+cGFkZHIgKyAoYmFjayAqIDQpKTsKPiArICAgICAgICAgICAgICAg aWYgKGRybV9kZWJ1ZyAmIERSTV9VVF9EUklWRVIpCj4gKyAgICAgICAgICAgICAgICAgICAgICAg cHJfaW5mbygic3RyZWFtIGxpbmsgZnJvbSBidWZmZXIgJXUgdG8gMHglMDh4IEAgMHglMDh4ICVw XG4iLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaSwgbGlua190YXJnZXQsCj4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjbWQtPnBhZGRyICsgY21kLT5vZmZzZXQg KiA0LAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY21kLT52YWRkciArIGNtZC0+ b2Zmc2V0ICogNCk7Cj4KPiAtICAgICAgIC8qIHVwZGF0ZSB0aGUgc2l6ZSAqLwo+IC0gICAgICAg Zm9yIChpID0gMDsgaSA8IHN1Ym1pdC0+bnJfY21kczsgaSsrKQo+IC0gICAgICAgICAgICAgICBz dWJtaXQtPmNtZFtpXS5zaXplID0gc3VibWl0LT5jbWRbaV0ub2JqLT5vZmZzZXQgLQo+IC0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3VibWl0LT5jbWRbaV0ub2Zmc2V0Owo+ ICsgICAgICAgICAgICAgICAvKiBqdW1wIGJhY2sgZnJvbSBsYXN0IGNtZCB0byBtYWluIGJ1ZmZl ciAqLwo+ICsgICAgICAgICAgICAgICBDTURfTElOSyhjbWQsIGxpbmtfc2l6ZSwgbGlua190YXJn ZXQpOwo+Cj4gLSAgICAgICBpZiAoZHJtX2RlYnVnICYgRFJNX1VUX0RSSVZFUikgewo+IC0gICAg ICAgICAgICAgICBwcl9pbmZvKCJzdHJlYW0gbGluayBAIDB4JTA4eFxuIiwKPiAtICAgICAgICAg ICAgICAgICAgICAgICBjbWQtPnBhZGRyICsgKChjbWQtPm9mZnNldCAtIDEpICogNCkpOwo+IC0g ICAgICAgICAgICAgICBwcl9pbmZvKCJzdHJlYW0gbGluayBAICVwXG4iLAo+IC0gICAgICAgICAg ICAgICAgICAgICAgIGNtZC0+dmFkZHIgKyAoKGNtZC0+b2Zmc2V0IC0gMSkgKiA0KSk7Cj4gKyAg ICAgICAgICAgICAgIC8qIHVwZGF0ZSB0aGUgc2l6ZSAqLwo+ICsgICAgICAgICAgICAgICBzdWJt aXQtPmNtZFtpXS5zaXplID0gY21kLT5vZmZzZXQgLSBzdWJtaXQtPmNtZFtpXS5vZmZzZXQ7Cj4g Kwo+ICsgICAgICAgICAgICAgICBsaW5rX3RhcmdldCA9IGNtZC0+cGFkZHIgKyBzdWJtaXQtPmNt ZFtpXS5vZmZzZXQgKiA0Owo+ICsgICAgICAgICAgICAgICBsaW5rX3NpemUgPSBzdWJtaXQtPmNt ZFtpXS5zaXplICogMjsKPiArICAgICAgIH0KPgo+ICsgICAgICAgaWYgKGRybV9kZWJ1ZyAmIERS TV9VVF9EUklWRVIpIHsKPiAgICAgICAgICAgICAgICAgZm9yIChpID0gMDsgaSA8IHN1Ym1pdC0+ bnJfY21kczsgaSsrKSB7Cj4gICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGV0bmF2aXZf Z2VtX29iamVjdCAqb2JqID0gc3VibWl0LT5jbWRbaV0ub2JqOwo+Cj4gQEAgLTE5NSwxNiArMTk4 LDE2IEBAIHZvaWQgZXRuYXZpdl9idWZmZXJfcXVldWUoc3RydWN0IGV0bmF2aXZfZ3B1ICpncHUs IHVuc2lnbmVkIGludCBldmVudCwgc3RydWN0IGV0Cj4KPiAgICAgICAgICAgICAgICAgcHJfaW5m bygibGluayBvcDogJXBcbiIsIGx3KTsKPiAgICAgICAgICAgICAgICAgcHJfaW5mbygibGluayBh ZGRyOiAlcFxuIiwgbHcgKyAxKTsKPiAtICAgICAgICAgICAgICAgcHJfaW5mbygiYWRkcjogMHgl MDh4XG4iLCBzdWJtaXQtPmNtZFswXS5vYmotPnBhZGRyKTsKPiArICAgICAgICAgICAgICAgcHJf aW5mbygiYWRkcjogMHglMDh4XG4iLCBsaW5rX3RhcmdldCk7Cj4gICAgICAgICAgICAgICAgIHBy X2luZm8oImJhY2s6IDB4JTA4eFxuIiwgYnVmZmVyLT5wYWRkciArIChiYWNrICogNCkpOwo+ICAg ICAgICAgICAgICAgICBwcl9pbmZvKCJldmVudDogJWRcbiIsIGV2ZW50KTsKPiAgICAgICAgIH0K Pgo+ICAgICAgICAgLyogQ2hhbmdlIFdBSVQgaW50byBhIExJTksgY29tbWFuZDsgd3JpdGUgdGhl IGFkZHJlc3MgZmlyc3QuICovCj4gLSAgICAgICBpID0gVklWX0ZFX0xJTktfSEVBREVSX09QX0xJ TksgfCBWSVZfRkVfTElOS19IRUFERVJfUFJFRkVUQ0goc3VibWl0LT5jbWRbMF0uc2l6ZSAqIDIp Owo+IC0gICAgICAgKihsdyArIDEpID0gc3VibWl0LT5jbWRbMF0ub2JqLT5wYWRkciArIHN1Ym1p dC0+Y21kWzBdLm9mZnNldCAqIDQ7Cj4gKyAgICAgICAqKGx3ICsgMSkgPSBsaW5rX3RhcmdldDsK PiAgICAgICAgIG1iKCk7Cj4gLSAgICAgICAqKGx3KT0gaTsKPiArICAgICAgICoobHcpID0gVklW X0ZFX0xJTktfSEVBREVSX09QX0xJTksgfAo+ICsgICAgICAgICAgICAgICBWSVZfRkVfTElOS19I RUFERVJfUFJFRkVUQ0gobGlua19zaXplKTsKPiAgICAgICAgIG1iKCk7Cj4KPiAgICAgICAgIGlm IChkcm1fZGVidWcgJiBEUk1fVVRfRFJJVkVSKQo+IC0tCj4gMi4xLjQKPgoKLS0KQ2hyaXN0aWFu IEdtZWluZXIsIE1TYwoKaHR0cHM6Ly9zb3VuZGNsb3VkLmNvbS9jaHJpc3RpYW4tZ21laW5lcgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=