From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E2C4C6FD1C for ; Fri, 24 Mar 2023 12:54:54 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1D5BC857DC; Fri, 24 Mar 2023 13:54:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="GSDi9UoN"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9FA5A85750; Fri, 24 Mar 2023 08:05:36 +0100 (CET) Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BB95C85714 for ; Fri, 24 Mar 2023 08:05:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bhupesh.sharma@linaro.org Received: by mail-wm1-x32a.google.com with SMTP id m6-20020a05600c3b0600b003ee6e324b19so346908wms.1 for ; Fri, 24 Mar 2023 00:05:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679641533; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bz0Uy1nSoKERHi3sSdx9N53XL9agXp7B/A03WyEasgU=; b=GSDi9UoN3DcBXhkhQro4sZonlPm6NcwE2g9UsfYV1S2fiK61ixlCmaWYd4spgH4K1P enoI0lByro1lFJBcT8Zo7EhREz+JwtPsBUOO/pzZK2Nuin+Ovey1Jm7O01FqQZelqGwx Q39BEEjJiKUc4js56tgyEotukn8OlQrJYvJiTar1vyTQmRwAgVDibk2waBF8ROrH1smc P5Nx+Ripk4mFXFgpSxh9x4T6XBnfIgCQLylbeqA9aRCFuhHFJWeEOKbTMLFGKLHiJkad /R6iJdS2U3ln6dDBjb4WT/0ZhhkghYPdMJ4OtIFEa4v0fZNa2C4p506P2d7oHq9szL2G Ruqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679641533; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bz0Uy1nSoKERHi3sSdx9N53XL9agXp7B/A03WyEasgU=; b=Qb9d06zooNQZuBBZQWITRFk4TCWlm4Qjvp84MG9AilRH4u/EKHzCHcmANP8v8WPF5F 0pexA1Aq4tdAHl7xkkZUZSIU4KVCof27iFN+cPkYdDE9OWa/ESPQqyUE4ZZ4saIDG6aY aql2qczm2kYlzHU0p5yibLNnamZasrF+1tCgPls8q4uGIHooOZErbingeVWZdapN4mZe i8a5GpoSH42r0Zk1PYkpIoLhlHgKCX68XyvrZjXWGJeee11kAWciWJlrHF/oavgNn3tw 9u69NMYR/eYBYOEI8deh8eoMjcOz/FSAUcsscr6Wh4g7zG7Mb4OOR/P8mvH1xSa1nob7 NMSg== X-Gm-Message-State: AO0yUKVc42pOK791Ot7DBA31LpkR3yjdGEveo1j6DGFi+HCGML1e8J02 FMZh6KTuZxOtM7Eu20PGio8wpowIEz3tAaAbLjJeew== X-Google-Smtp-Source: AK7set+5RRoAxC8ZPGQoZrWpvir+/sXQtPm+PD1/ZuJrgBTrH42Xx3bgiEOT8bq22nArqLLl8neaIaY3DGzHne7G8ZQ= X-Received: by 2002:a7b:ca4a:0:b0:3ed:7664:6d7b with SMTP id m10-20020a7bca4a000000b003ed76646d7bmr481510wml.8.1679641533039; Fri, 24 Mar 2023 00:05:33 -0700 (PDT) MIME-Version: 1.0 References: <20230324004040.572525-1-konrad.dybcio@linaro.org> In-Reply-To: <20230324004040.572525-1-konrad.dybcio@linaro.org> From: Bhupesh Sharma Date: Fri, 24 Mar 2023 12:35:21 +0530 Message-ID: Subject: Re: [PATCH 1/7] mmc: msm_sdhci: Match clocks through "clocks" property To: Konrad Dybcio Cc: u-boot@lists.denx.de, Jaehoon Chung , Peng Fan , Ramon Fried Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Fri, 24 Mar 2023 13:54:51 +0100 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Konrad, On Fri, 24 Mar 2023 at 06:10, Konrad Dybcio wrote: > > "clocks" is the standard property used in Linux, "clock" seems to be > an U-Boot invention. Use the one that's more standardized. > > Signed-off-by: Konrad Dybcio > --- > > drivers/mmc/msm_sdhci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/msm_sdhci.c b/drivers/mmc/msm_sdhci.c > index 604f9c3ff99c..174435f01f68 100644 > --- a/drivers/mmc/msm_sdhci.c > +++ b/drivers/mmc/msm_sdhci.c > @@ -63,7 +63,7 @@ static int msm_sdc_clk_init(struct udevice *dev) > struct clk clk; > int ret; > > - ret = fdtdec_get_int_array(gd->fdt_blob, node, "clock", clkd, 2); > + ret = fdtdec_get_int_array(gd->fdt_blob, node, "clocks", clkd, 2); > if (ret) > return ret; This would break existing msm platforms like qcs404 and rb3. So, please send the changed dts for those platforms with the driver changes. We would also need to test the changes on those platforms first. Same is valid for other driver patches which alter the dts properties without changing the actual dtsi/dts first. Thanks, Bhupesh