From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D953FC433EF for ; Sun, 24 Oct 2021 13:34:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C087760FD7 for ; Sun, 24 Oct 2021 13:34:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231670AbhJXNhF (ORCPT ); Sun, 24 Oct 2021 09:37:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231524AbhJXNhE (ORCPT ); Sun, 24 Oct 2021 09:37:04 -0400 Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21066C061764 for ; Sun, 24 Oct 2021 06:34:44 -0700 (PDT) Received: by mail-oi1-x231.google.com with SMTP id g125so11794761oif.9 for ; Sun, 24 Oct 2021 06:34:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZT5fAPNyma5e8WyOr3A/N0atEQZClP4tTp5HN0LYpNU=; b=pus/LjZ4Z8Uirsug0xo7ImF4DBZk6R688dmmvvXAqXfgj1hDPomu/UBKljPuTJAV94 X8fiCSxBQziChqPRPDhRvOiB7o/fFUSoZxnbz927sXDnCKV0P3uITNT80A6Lf7yopguU g3kWkCaeGmwenOfQPS+J3W1cYuzCVFTYBbaH70cRvwrCBDuCjFsZnz9Bd5W0PPJEgNQ9 deCidFezCiIh89PfAv0Fj/JYXqOHTyJ7oOgWOBXzCE98R3hRsdv4dWD5wxWAphgTFZfU aGRtp7abMFk47nKdNqsSjQ7i1TBzmc4KhIZpej8jgrs/MAwzmdz+aOw7dD+Aezlp/NvO FR7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZT5fAPNyma5e8WyOr3A/N0atEQZClP4tTp5HN0LYpNU=; b=ph4G8ZKvFBwmdMkUqYXdHUe7+AknzSHIgEDaurspRlEE1Uh2wjH0lFkfzRVUobmmIZ /hgUvrckENQSH+OcfBBRWiJDst6eagDPOTisirLX5Tr0OIAo773f5SB5heG/tcMxRGlR e9dA0VEnbn4ncNUJhwXnfhxp1pDC/1qZdZrTWujXKevG8k7vAWd2QoP3V5Nu58KQwYFy FaAuHYr2Mit0G3MHL1ECa5OtH47/vWWawRyVQk4ydYLLhyqreUU75Yo/RuiqsgdGaSOf nNRKux1agN0EZZ6HQYFIYPY8OqHicIypSTFQNa1/2wAV2+/VLHQCnlS6uLHRzjYYqgPA 1NxA== X-Gm-Message-State: AOAM532EXyZzdKTZOAuL3SrxwmvDJ967ZNooCNG0a55hJcclePXY4rv1 H8lZvJ2bxi7UeER1oLKmllvYZxGCfzmBB2lCdInNeQ== X-Google-Smtp-Source: ABdhPJw6MtPfZNRBtb5CTwISKGRCnQMN0HVMf5dU8udAdvoGUoEQeJDigLYoasCwbfbNEh6DyJ9w8rMN2i9KfCY1QwQ= X-Received: by 2002:a05:6808:1686:: with SMTP id bb6mr8188043oib.40.1635082483473; Sun, 24 Oct 2021 06:34:43 -0700 (PDT) MIME-Version: 1.0 References: <20211013105541.68045-1-bhupesh.sharma@linaro.org> <20211013105541.68045-17-bhupesh.sharma@linaro.org> <5f69019a-86c7-fac5-2758-1be9a9092678@linaro.org> In-Reply-To: <5f69019a-86c7-fac5-2758-1be9a9092678@linaro.org> From: Bhupesh Sharma Date: Sun, 24 Oct 2021 19:04:32 +0530 Message-ID: Subject: Re: [PATCH v4 16/20] crypto: qce: core: Make clocks optional To: Vladimir Zapolskiy Cc: MSM , linux-crypto@vger.kernel.org, bhupesh.linux@gmail.com, Linux Kernel Mailing List , devicetree , Rob Herring , Andy Gross , Herbert Xu , "David S . Miller" , Thara Gopinath Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi Vladimir, On Thu, 14 Oct 2021 at 00:53, Vladimir Zapolskiy wrote: > > Hi Bhupesh, > > On 10/13/21 1:55 PM, Bhupesh Sharma wrote: > > From: Thara Gopinath > > > > On certain Snapdragon processors, the crypto engine clocks are enabled by > > default by security firmware and the driver need not/ should not handle the > > clocks. Make acquiring of all the clocks optional in crypto enginer driver > > typo, s/enginer/engine/ > > > so that the driver intializes properly even if no clocks are specified in > > typo, s/intializes/initializes/ Thanks, I will fix these typos in v5. Regards, Bhupesh > > the dt. > > > > Signed-off-by: Thara Gopinath > > --- > > drivers/crypto/qce/core.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c > > index 2ab0b97d718c..576c416461f9 100644 > > --- a/drivers/crypto/qce/core.c > > +++ b/drivers/crypto/qce/core.c > > @@ -213,19 +213,19 @@ static int qce_crypto_probe(struct platform_device *pdev) > > if (IS_ERR(qce->mem_path)) > > return PTR_ERR(qce->mem_path); > > > > - qce->core = devm_clk_get(qce->dev, "core"); > > + qce->core = devm_clk_get_optional(qce->dev, "core"); > > if (IS_ERR(qce->core)) { > > ret = PTR_ERR(qce->core); > > goto err_mem_path_put; > > } > > > > - qce->iface = devm_clk_get(qce->dev, "iface"); > > + qce->iface = devm_clk_get_optional(qce->dev, "iface"); > > if (IS_ERR(qce->iface)) { > > ret = PTR_ERR(qce->iface); > > goto err_mem_path_put; > > } > > > > - qce->bus = devm_clk_get(qce->dev, "bus"); > > + qce->bus = devm_clk_get_optional(qce->dev, "bus"); > > if (IS_ERR(qce->bus)) { > > ret = PTR_ERR(qce->bus); > > goto err_mem_path_put; > > > > -- > Best wishes, > Vladimir