From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E23F2C48BDF for ; Tue, 15 Jun 2021 17:00:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD39861923 for ; Tue, 15 Jun 2021 17:00:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230459AbhFORC4 (ORCPT ); Tue, 15 Jun 2021 13:02:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230346AbhFORC4 (ORCPT ); Tue, 15 Jun 2021 13:02:56 -0400 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDC52C06175F for ; Tue, 15 Jun 2021 10:00:51 -0700 (PDT) Received: by mail-oi1-x22c.google.com with SMTP id d19so14898215oic.7 for ; Tue, 15 Jun 2021 10:00:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OrHpiQTn+IqOBIYO5Pq4UHsLozqCibN36fNoW8gNRD0=; b=w4V+qXiieefOcxwFgrf2VCnoMsgBVXMXyzgY8AURZ60wzDRJPA5ZnwPqtLaoxik+Bm 8fnW4ktgfh9cmf77AhchNONIO460nlmJi998joD1MZiXXz+lBlSKrWuuh6cWa0VNUaKt cJo9nMufzTPQtClv0yJ6GGnfXW+Lvgf7eA+50GrQ9RaFKRB8CcvWvPGfrimQZMjCvIpg nd6LJ7BRNrhnS5LCuSvMmbkFwQpdZ0fqcKsMrJpENRAsYEXBvTZOfcFmIb9PlkTLLznc QtEQLqmr1Ywhf6CfQPYZt5aTGvs4fUbh+RRzbexCiMePG6hm9X+TzZoqJ93FFwndXj49 HNzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OrHpiQTn+IqOBIYO5Pq4UHsLozqCibN36fNoW8gNRD0=; b=niVFjuAeZPrteg6oFj/bY67rBg/XkWfzSHjUAOmekbiALhhhsz28CtGZyE/DUh7Ggu Xd6IPATOl1GodyADgcxKfXBZCxLLJScu65V7hS0HVaCLVhE6WFuaov3+P8SKxe+0S+ly uVOeZ+JUoN2AAG6alIImuRFrkD0mYgnov5JdNWujJ5ZUZuyOhEhJGwBgwVvr+BdwYCDc 4JVplOU3BGm0GBH2vImvHg70VRWAZ9E3Ay2P8EGgdXuZ8pNrQNE9g798w6Eb5bFl7K4L AzJYDgmKAdMQQ1pstjiNPkitWwO9kw8Abycb/AtmEQwLnL7X64fwe0Uji8iR2OTmh9G9 d+Vg== X-Gm-Message-State: AOAM533Gi33XYBH+k9JAinOMiYbc6ku/IkUpWiqFZwlMfoYNZb9o+6tN L0Hq7j8nqdz2eO+drGBNjlSVUidTkarxxjY/CW6kxw== X-Google-Smtp-Source: ABdhPJxCnnNnCWSfH0VDaXkPF/u1L+nchxayekHp7hO0jMhZ49QfQK6sS4x7wI7zPaj50rP+V4rbyDHzeAJ3rdd9dHA= X-Received: by 2002:aca:4bd7:: with SMTP id y206mr117111oia.40.1623776450766; Tue, 15 Jun 2021 10:00:50 -0700 (PDT) MIME-Version: 1.0 References: <20210615074543.26700-1-bhupesh.sharma@linaro.org> <20210615074543.26700-11-bhupesh.sharma@linaro.org> <0b012d77-8d61-f852-f455-8b6cceb03ebf@somainline.org> In-Reply-To: <0b012d77-8d61-f852-f455-8b6cceb03ebf@somainline.org> From: Bhupesh Sharma Date: Tue, 15 Jun 2021 22:30:39 +0530 Message-ID: Subject: Re: [PATCH v2 10/10] arm64: dts: qcom: sa8155p-adp: Add base dts file To: Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, bhupesh.linux@gmail.com, "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , devicetree , Linus Walleij , Liam Girdwood , Mark Brown , Bjorn Andersson , Vinod Koul , Rob Herring , Andy Gross Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Konrad, Thanks for the review. On Tue, 15 Jun 2021 at 20:23, Konrad Dybcio wrote: > > Hi, > > > > + > > + reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>; > > + > > + vcc-supply = <&vreg_l10a_2p96>; > > + vcc-max-microamp = <750000>; > > + vccq-supply = <&vreg_l5c_1p2>; > > + vccq-max-microamp = <700000>; > > + vccq2-supply = <&vreg_s4a_1p8>; > > + vccq2-max-microamp = <750000>; > > You need to add "regulator-allow-set-load;" to the mentioned supplies, > > as you're controlling the amperage here. Ok, I will fix this in v3. > > +}; > > + > > +&ufs_mem_phy { > > + status = "okay"; > > + > > + vdda-phy-supply = <&vreg_l8c_1p2>; > > + vdda-max-microamp = <87100>; > > + vdda-pll-supply = <&vreg_l5a_0p88>; > > + vdda-pll-max-microamp = <18300>; > > Ditto Sure, I will fix it in v3. Thanks, Bhupesh