All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <cwang@twopensource.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev <netdev@vger.kernel.org>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	David Miller <davem@davemloft.net>
Subject: Re: Why do we prefer skb->priority to tc filters?
Date: Thu, 12 Mar 2015 10:25:56 -0700	[thread overview]
Message-ID: <CAHA+R7MTjFWbi=Fex6GhZVfjHNHhSH6DV7ov2UOfxYmo6QCH2g@mail.gmail.com> (raw)
In-Reply-To: <CAHA+R7MHptw8gbA6nqPYzc2vSGEunwKTJmL6kJ81820c7oc6BQ@mail.gmail.com>

On Thu, Mar 12, 2015 at 9:59 AM, Cong Wang <cwang@twopensource.com> wrote:
> On Wed, Mar 11, 2015 at 5:00 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>>
>> If you use mavclan or ipvlan, not all paths will use __dev_forward_skb()
>>
>
> That is intentional, because I am not sure about stacked device
> like macvlan or tunnel, it might make some sense to keep that value.
>
>> So I am guessing you use veth maybe. Who knows.
>>
>
>
> Exactly, otherwise I would probably just change skb_scrub_packet(). ;)

Ok, in some mode macvlan forwards the packets to Rx path too, interesting...

  reply	other threads:[~2015-03-12 17:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11 17:34 Why do we prefer skb->priority to tc filters? Cong Wang
2015-03-11 18:08 ` Cong Wang
2015-03-11 18:25   ` Eric Dumazet
2015-03-11 19:18     ` Cong Wang
2015-03-11 20:09       ` Eric Dumazet
2015-03-11 20:46         ` Cong Wang
2015-03-11 21:47           ` Eric Dumazet
2015-03-11 22:12             ` Cong Wang
2015-03-12  0:00               ` Eric Dumazet
2015-03-12 16:59                 ` Cong Wang
2015-03-12 17:25                   ` Cong Wang [this message]
2015-03-12  7:53             ` Dmitry Sytchev
2015-03-12 17:08               ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHA+R7MTjFWbi=Fex6GhZVfjHNHhSH6DV7ov2UOfxYmo6QCH2g@mail.gmail.com' \
    --to=cwang@twopensource.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.