From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: Re: [PATCH net] net: vxlan: fix crash when interface is created with no group Date: Thu, 27 Mar 2014 13:20:25 -0700 Message-ID: References: <20140326094754.GA19337@zed> <20140325.205324.1845346581147557473.davem@davemloft.net> <20140326175018.GA24065@zed> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: David Stevens , David Miller , netdev , Or Gerlitz To: Mike Rapoport Return-path: Received: from mail-lb0-f177.google.com ([209.85.217.177]:63847 "EHLO mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756679AbaC0UU1 (ORCPT ); Thu, 27 Mar 2014 16:20:27 -0400 Received: by mail-lb0-f177.google.com with SMTP id z11so3016801lbi.36 for ; Thu, 27 Mar 2014 13:20:25 -0700 (PDT) In-Reply-To: <20140326175018.GA24065@zed> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Mar 26, 2014 at 10:50 AM, Mike Rapoport wrote: > > The problem is not only duplication of default destinations, but also > the mis^Wuse of default_dst to distinguish whether IPv4 or IPv6 path > should be taken because there is no explicit specification of the > protocol if neither IFLA_VXLAN_GROUP or IFLA_VXLAN_LOCAL defined at > vxlan_newlink. Moreover, if neither of these attributes is present, the > custom configuration will always use v4 socket regardles of use of > default_dst or fdb entry. It should default to IPv4 for compatibility reason.