On Wed, Aug 6, 2014 at 12:51 PM, Thomas Graf wrote: > On 08/06/14 at 10:52am, Cong Wang wrote: >> >> Looks like we should hold rcu_read_lock() before calling __netlink_diag_dump(). > > netlink_diag_dump() still acquires nl_table_lock which is pointless as > a separate mutex has been introduced to protect mutations. I will send > a patch to RCU'ify it properly. Agreed, but that's likely a net-next material. I think we need the following quick fix for net.