* [PATCH v1] Bluetooth: Fix the HCI to MGMT status conversion table
@ 2021-04-19 23:53 Yu Liu
2021-04-20 2:12 ` [v1] " bluez.test.bot
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Yu Liu @ 2021-04-19 23:53 UTC (permalink / raw)
To: linux-bluetooth, marcel, chromeos-bluetooth-upstreaming
Cc: Yu Liu, Miao-chen Chou, David S. Miller, Jakub Kicinski,
Johan Hedberg, Luiz Augusto von Dentz, linux-kernel, netdev
0x2B, 0x31 and 0x33 are reserved for future use but were not present in
the HCI to MGMT conversion table, this caused the conversion to be
incorrect for the HCI status code greater than 0x2A.
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Signed-off-by: Yu Liu <yudiliu@google.com>
---
Changes in v1:
- Initial change
net/bluetooth/mgmt.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index 40f75b8e1416..b44e19c69c44 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -252,12 +252,15 @@ static const u8 mgmt_status_table[] = {
MGMT_STATUS_TIMEOUT, /* Instant Passed */
MGMT_STATUS_NOT_SUPPORTED, /* Pairing Not Supported */
MGMT_STATUS_FAILED, /* Transaction Collision */
+ MGMT_STATUS_FAILED, /* Reserved for future use */
MGMT_STATUS_INVALID_PARAMS, /* Unacceptable Parameter */
MGMT_STATUS_REJECTED, /* QoS Rejected */
MGMT_STATUS_NOT_SUPPORTED, /* Classification Not Supported */
MGMT_STATUS_REJECTED, /* Insufficient Security */
MGMT_STATUS_INVALID_PARAMS, /* Parameter Out Of Range */
+ MGMT_STATUS_FAILED, /* Reserved for future use */
MGMT_STATUS_BUSY, /* Role Switch Pending */
+ MGMT_STATUS_FAILED, /* Reserved for future use */
MGMT_STATUS_FAILED, /* Slot Violation */
MGMT_STATUS_FAILED, /* Role Switch Failed */
MGMT_STATUS_INVALID_PARAMS, /* EIR Too Large */
--
2.31.1.368.gbe11c130af-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [v1] Bluetooth: Fix the HCI to MGMT status conversion table
2021-04-19 23:53 [PATCH v1] Bluetooth: Fix the HCI to MGMT status conversion table Yu Liu
@ 2021-04-20 2:12 ` bluez.test.bot
2021-04-28 23:05 ` [PATCH v1] " Yu Liu
2021-04-29 7:36 ` Marcel Holtmann
2 siblings, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2021-04-20 2:12 UTC (permalink / raw)
To: linux-bluetooth, yudiliu
[-- Attachment #1: Type: text/plain, Size: 1467 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=469907
---Test result---
##############################
Test: CheckPatch - PASS
##############################
Test: CheckGitLint - PASS
##############################
Test: CheckBuildK - PASS
##############################
Test: CheckTestRunner: Setup - PASS
##############################
Test: CheckTestRunner: l2cap-tester - PASS
Total: 40, Passed: 34 (85.0%), Failed: 0, Not Run: 6
##############################
Test: CheckTestRunner: bnep-tester - PASS
Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0
##############################
Test: CheckTestRunner: mgmt-tester - PASS
Total: 416, Passed: 402 (96.6%), Failed: 0, Not Run: 14
##############################
Test: CheckTestRunner: rfcomm-tester - PASS
Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0
##############################
Test: CheckTestRunner: sco-tester - PASS
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0
##############################
Test: CheckTestRunner: smp-tester - PASS
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0
##############################
Test: CheckTestRunner: userchan-tester - PASS
Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0
---
Regards,
Linux Bluetooth
[-- Attachment #2: l2cap-tester.log --]
[-- Type: application/octet-stream, Size: 43346 bytes --]
[-- Attachment #3: bnep-tester.log --]
[-- Type: application/octet-stream, Size: 3537 bytes --]
[-- Attachment #4: mgmt-tester.log --]
[-- Type: application/octet-stream, Size: 546684 bytes --]
[-- Attachment #5: rfcomm-tester.log --]
[-- Type: application/octet-stream, Size: 11657 bytes --]
[-- Attachment #6: sco-tester.log --]
[-- Type: application/octet-stream, Size: 9892 bytes --]
[-- Attachment #7: smp-tester.log --]
[-- Type: application/octet-stream, Size: 11803 bytes --]
[-- Attachment #8: userchan-tester.log --]
[-- Type: application/octet-stream, Size: 5433 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] Bluetooth: Fix the HCI to MGMT status conversion table
2021-04-19 23:53 [PATCH v1] Bluetooth: Fix the HCI to MGMT status conversion table Yu Liu
2021-04-20 2:12 ` [v1] " bluez.test.bot
@ 2021-04-28 23:05 ` Yu Liu
2021-04-29 7:36 ` Marcel Holtmann
2 siblings, 0 replies; 4+ messages in thread
From: Yu Liu @ 2021-04-28 23:05 UTC (permalink / raw)
To: linux-bluetooth, Marcel Holtmann
Cc: David S. Miller, Jakub Kicinski, Johan Hedberg,
Luiz Augusto von Dentz, linux-kernel, netdev
Ping for attention, thanks.
On Mon, Apr 19, 2021 at 4:53 PM Yu Liu <yudiliu@google.com> wrote:
>
> 0x2B, 0x31 and 0x33 are reserved for future use but were not present in
> the HCI to MGMT conversion table, this caused the conversion to be
> incorrect for the HCI status code greater than 0x2A.
>
> Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
> Signed-off-by: Yu Liu <yudiliu@google.com>
> ---
>
> Changes in v1:
> - Initial change
>
> net/bluetooth/mgmt.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index 40f75b8e1416..b44e19c69c44 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -252,12 +252,15 @@ static const u8 mgmt_status_table[] = {
> MGMT_STATUS_TIMEOUT, /* Instant Passed */
> MGMT_STATUS_NOT_SUPPORTED, /* Pairing Not Supported */
> MGMT_STATUS_FAILED, /* Transaction Collision */
> + MGMT_STATUS_FAILED, /* Reserved for future use */
> MGMT_STATUS_INVALID_PARAMS, /* Unacceptable Parameter */
> MGMT_STATUS_REJECTED, /* QoS Rejected */
> MGMT_STATUS_NOT_SUPPORTED, /* Classification Not Supported */
> MGMT_STATUS_REJECTED, /* Insufficient Security */
> MGMT_STATUS_INVALID_PARAMS, /* Parameter Out Of Range */
> + MGMT_STATUS_FAILED, /* Reserved for future use */
> MGMT_STATUS_BUSY, /* Role Switch Pending */
> + MGMT_STATUS_FAILED, /* Reserved for future use */
> MGMT_STATUS_FAILED, /* Slot Violation */
> MGMT_STATUS_FAILED, /* Role Switch Failed */
> MGMT_STATUS_INVALID_PARAMS, /* EIR Too Large */
> --
> 2.31.1.368.gbe11c130af-goog
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] Bluetooth: Fix the HCI to MGMT status conversion table
2021-04-19 23:53 [PATCH v1] Bluetooth: Fix the HCI to MGMT status conversion table Yu Liu
2021-04-20 2:12 ` [v1] " bluez.test.bot
2021-04-28 23:05 ` [PATCH v1] " Yu Liu
@ 2021-04-29 7:36 ` Marcel Holtmann
2 siblings, 0 replies; 4+ messages in thread
From: Marcel Holtmann @ 2021-04-29 7:36 UTC (permalink / raw)
To: Yu Liu
Cc: Bluetooth Kernel Mailing List, CrosBT Upstreaming,
Miao-chen Chou, David S. Miller, Jakub Kicinski, Johan Hedberg,
Luiz Augusto von Dentz, open list, netdev
Hi Yu,
> 0x2B, 0x31 and 0x33 are reserved for future use but were not present in
> the HCI to MGMT conversion table, this caused the conversion to be
> incorrect for the HCI status code greater than 0x2A.
>
> Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
> Signed-off-by: Yu Liu <yudiliu@google.com>
> ---
>
> Changes in v1:
> - Initial change
>
> net/bluetooth/mgmt.c | 3 +++
> 1 file changed, 3 insertions(+)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-29 7:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-19 23:53 [PATCH v1] Bluetooth: Fix the HCI to MGMT status conversion table Yu Liu
2021-04-20 2:12 ` [v1] " bluez.test.bot
2021-04-28 23:05 ` [PATCH v1] " Yu Liu
2021-04-29 7:36 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.