All of lore.kernel.org
 help / color / mirror / Atom feed
From: Justin Green <greenjustin@chromium.org>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: chunkuang.hu@kernel.org, airlied@linux.ie,
	jason-jh.lin@mediatek.com, justin.yeh@mediatek.com,
	dri-devel@lists.freedesktop.org,
	linux-mediatek@lists.infradead.org, wenst@chromium.org,
	angelogioacchino.delregno@collabora.com
Subject: Re: [PATCH 1/3] drm/mediatek: Refactor pixel format logic
Date: Thu, 2 Feb 2023 15:41:14 -0500	[thread overview]
Message-ID: <CAHC42Rff5Xj_5bJNVozAYnG+ujjZ+R1DjDfWZn4GvsyQV+do_Q@mail.gmail.com> (raw)
In-Reply-To: <15711c23-43c4-86c4-0f56-4a76b5ffea46@gmail.com>

> Yes, I had a comment on the naming in that patch. Never the less, I think if we
> don't need to "overwrite" the value, we should use just one struct for the
> values instead of copying them to the different .c files and give them SoC
> specific names.
I don't have a very strong opinion about this, and in fact that is how
v1 of the patch worked, but Chun-Kuang specifically suggested moving
that struct into the .c files a few versions back. I think it makes
sense if we expect additional skew between the different components
and what pixel formats they support.

WARNING: multiple messages have this Message-ID (diff)
From: Justin Green <greenjustin@chromium.org>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-mediatek@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	 angelogioacchino.delregno@collabora.com,
	jason-jh.lin@mediatek.com,  justin.yeh@mediatek.com,
	wenst@chromium.org, chunkuang.hu@kernel.org,
	 p.zabel@pengutronix.de, airlied@linux.ie, daniel@ffwll.ch,
	 daniel@fooishbar.org
Subject: Re: [PATCH 1/3] drm/mediatek: Refactor pixel format logic
Date: Thu, 2 Feb 2023 15:41:14 -0500	[thread overview]
Message-ID: <CAHC42Rff5Xj_5bJNVozAYnG+ujjZ+R1DjDfWZn4GvsyQV+do_Q@mail.gmail.com> (raw)
In-Reply-To: <15711c23-43c4-86c4-0f56-4a76b5ffea46@gmail.com>

> Yes, I had a comment on the naming in that patch. Never the less, I think if we
> don't need to "overwrite" the value, we should use just one struct for the
> values instead of copying them to the different .c files and give them SoC
> specific names.
I don't have a very strong opinion about this, and in fact that is how
v1 of the patch worked, but Chun-Kuang specifically suggested moving
that struct into the .c files a few versions back. I think it makes
sense if we expect additional skew between the different components
and what pixel formats they support.


  reply	other threads:[~2023-02-02 20:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-01 17:02 [PATCH 0/3 v7] drm/mediatek: Add support for 10-bit overlays Justin Green
2023-02-01 17:02 ` Justin Green
2023-02-01 17:02 ` [PATCH 1/3] drm/mediatek: Refactor pixel format logic Justin Green
2023-02-01 17:02   ` Justin Green
2023-02-02 10:11   ` Matthias Brugger
2023-02-02 10:11     ` Matthias Brugger
2023-02-02 18:59     ` Justin Green
2023-02-02 18:59       ` Justin Green
2023-02-02 20:16       ` Matthias Brugger
2023-02-02 20:16         ` Matthias Brugger
2023-02-02 20:41         ` Justin Green [this message]
2023-02-02 20:41           ` Justin Green
2023-02-03  7:29           ` Matthias Brugger
2023-02-03  7:29             ` Matthias Brugger
2023-02-01 17:02 ` [PATCH 2/3] drm/mediatek: Add support for AR30 and BA30 overlays Justin Green
2023-02-01 17:02   ` Justin Green
2023-02-01 17:02 ` [PATCH 3/3] drm/mediatek: Enable AR30 and BA30 overlays on MT8195 Justin Green
2023-02-01 17:02   ` Justin Green
2023-02-02 10:12   ` Matthias Brugger
2023-02-02 10:12     ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHC42Rff5Xj_5bJNVozAYnG+ujjZ+R1DjDfWZn4GvsyQV+do_Q@mail.gmail.com \
    --to=greenjustin@chromium.org \
    --cc=airlied@linux.ie \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jason-jh.lin@mediatek.com \
    --cc=justin.yeh@mediatek.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=wenst@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.