From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753088AbdC2PRR (ORCPT ); Wed, 29 Mar 2017 11:17:17 -0400 Received: from mail-vk0-f65.google.com ([209.85.213.65]:35059 "EHLO mail-vk0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752739AbdC2PRQ (ORCPT ); Wed, 29 Mar 2017 11:17:16 -0400 MIME-Version: 1.0 X-Originating-IP: [108.49.102.27] In-Reply-To: <3582dff5-b96a-dde7-2d1c-bca7ab4aeb0e@users.sourceforge.net> References: <3582dff5-b96a-dde7-2d1c-bca7ab4aeb0e@users.sourceforge.net> From: Paul Moore Date: Wed, 29 Mar 2017 11:17:09 -0400 Message-ID: Subject: Re: [PATCH 28/46] selinux: Return directly after a failed kzalloc() in user_read() To: SF Markus Elfring Cc: linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, Eric Paris , James Morris , "Serge E. Hallyn" , Stephen Smalley , William Roberts , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 15, 2017 at 10:28 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 22:08:22 +0100 > > Return directly after a call of the function "kzalloc" failed > at the beginning. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/policydb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Merged, thanks. > diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c > index 3e43556e67b8..1c046d39e2a7 100644 > --- a/security/selinux/ss/policydb.c > +++ b/security/selinux/ss/policydb.c > @@ -1542,10 +1542,9 @@ static int user_read(struct policydb *p, struct hashtab *h, void *fp) > __le32 buf[3]; > u32 len; > > - rc = -ENOMEM; > usrdatum = kzalloc(sizeof(*usrdatum), GFP_KERNEL); > if (!usrdatum) > - goto bad; > + return -ENOMEM; > > if (p->policyvers >= POLICYDB_VERSION_BOUNDARY) > to_read = 3; > -- > 2.11.0 > -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Moore Date: Wed, 29 Mar 2017 15:17:09 +0000 Subject: Re: [PATCH 28/46] selinux: Return directly after a failed kzalloc() in user_read() Message-Id: List-Id: References: <3582dff5-b96a-dde7-2d1c-bca7ab4aeb0e@users.sourceforge.net> In-Reply-To: <3582dff5-b96a-dde7-2d1c-bca7ab4aeb0e@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-security-module@vger.kernel.org On Sun, Jan 15, 2017 at 10:28 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 22:08:22 +0100 > > Return directly after a call of the function "kzalloc" failed > at the beginning. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/policydb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Merged, thanks. > diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c > index 3e43556e67b8..1c046d39e2a7 100644 > --- a/security/selinux/ss/policydb.c > +++ b/security/selinux/ss/policydb.c > @@ -1542,10 +1542,9 @@ static int user_read(struct policydb *p, struct hashtab *h, void *fp) > __le32 buf[3]; > u32 len; > > - rc = -ENOMEM; > usrdatum = kzalloc(sizeof(*usrdatum), GFP_KERNEL); > if (!usrdatum) > - goto bad; > + return -ENOMEM; > > if (p->policyvers >= POLICYDB_VERSION_BOUNDARY) > to_read = 3; > -- > 2.11.0 > -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: paul@paul-moore.com (Paul Moore) Date: Wed, 29 Mar 2017 11:17:09 -0400 Subject: [PATCH 28/46] selinux: Return directly after a failed kzalloc() in user_read() In-Reply-To: <3582dff5-b96a-dde7-2d1c-bca7ab4aeb0e@users.sourceforge.net> References: <3582dff5-b96a-dde7-2d1c-bca7ab4aeb0e@users.sourceforge.net> Message-ID: To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Sun, Jan 15, 2017 at 10:28 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 22:08:22 +0100 > > Return directly after a call of the function "kzalloc" failed > at the beginning. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/policydb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Merged, thanks. > diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c > index 3e43556e67b8..1c046d39e2a7 100644 > --- a/security/selinux/ss/policydb.c > +++ b/security/selinux/ss/policydb.c > @@ -1542,10 +1542,9 @@ static int user_read(struct policydb *p, struct hashtab *h, void *fp) > __le32 buf[3]; > u32 len; > > - rc = -ENOMEM; > usrdatum = kzalloc(sizeof(*usrdatum), GFP_KERNEL); > if (!usrdatum) > - goto bad; > + return -ENOMEM; > > if (p->policyvers >= POLICYDB_VERSION_BOUNDARY) > to_read = 3; > -- > 2.11.0 > -- paul moore www.paul-moore.com -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html