From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f65.google.com ([209.85.167.65]:41872 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726270AbeJDILk (ORCPT ); Thu, 4 Oct 2018 04:11:40 -0400 Received: by mail-lf1-f65.google.com with SMTP id q39-v6so5519571lfi.8 for ; Wed, 03 Oct 2018 18:20:47 -0700 (PDT) MIME-Version: 1.0 References: <20180904160632.21210-1-jack@suse.cz> <20180914191328.rljpiakvk4xavrzj@madcap2.tricolour.ca> <20180917165714.GE10257@quack2.suse.cz> In-Reply-To: <20180917165714.GE10257@quack2.suse.cz> From: Paul Moore Date: Wed, 3 Oct 2018 21:20:35 -0400 Message-ID: Subject: Re: [PATCH 0/11 v3] audit: Fix various races when tagging and untagging mounts To: jack@suse.cz Cc: rgb@redhat.com, viro@zeniv.linux.org.uk, linux-audit@redhat.com, linux-fsdevel@vger.kernel.org, amir73il@gmail.com Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Sep 17, 2018 at 12:57 PM Jan Kara wrote: > On Fri 14-09-18 15:13:28, Richard Guy Briggs wrote: > > On 2018-09-04 18:06, Jan Kara wrote: > > > Hello, > > > > Jan, > > > > > this is the third revision of the series that addresses problems I have > > > identified when trying to understand how exactly is kernel/audit_tree.c using > > > generic fsnotify framework. I hope I have understood all the interactions right > > > but careful review is certainly welcome. > > > > I've tried to review it as carefully as I am able. As best I understand > > it, this all looks reasonable and an improvement over the previous > > state. Thanks for the hard work. > > > > FWIW, > > Reviewed-by: Richard Guy Briggs > > Thanks for review! Paul should I send you updated patch 9 with that one > variable renamed or will you do that small change while merging the series? Hi Jan, Thanks again for these patches and your patience; some travel, holidays, and a job change delayed my review. However, everything looks okay to me (minus the one problem I noted in patch 09/11). I've added the patches to audit/working-fsnotify_fixes and I'm going to start stressing them as soon as I get a test kernel built with the idea of merging them into audit/next as soon as the upcoming merge window closes. As far as the variable rename is concerned, that's not something I would prefer to change during a merge, but if you or Richard wanted to submit a renaming patch I would be okay with that in this case. If you do submit the rename patch, please base it on top of this patchset (or audit/working-fsnotify_fixes). Thanks! -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Moore Subject: Re: [PATCH 0/11 v3] audit: Fix various races when tagging and untagging mounts Date: Wed, 3 Oct 2018 21:20:35 -0400 Message-ID: References: <20180904160632.21210-1-jack@suse.cz> <20180914191328.rljpiakvk4xavrzj@madcap2.tricolour.ca> <20180917165714.GE10257@quack2.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com (ext-mx18.extmail.prod.ext.phx2.redhat.com [10.5.110.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B72A166080 for ; Thu, 4 Oct 2018 01:20:49 +0000 (UTC) Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3D54230820CE for ; Thu, 4 Oct 2018 01:20:48 +0000 (UTC) Received: by mail-lf1-f67.google.com with SMTP id q2-v6so5515189lfc.13 for ; Wed, 03 Oct 2018 18:20:48 -0700 (PDT) In-Reply-To: <20180917165714.GE10257@quack2.suse.cz> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: jack@suse.cz Cc: rgb@redhat.com, linux-fsdevel@vger.kernel.org, linux-audit@redhat.com, amir73il@gmail.com, viro@zeniv.linux.org.uk List-Id: linux-audit@redhat.com On Mon, Sep 17, 2018 at 12:57 PM Jan Kara wrote: > On Fri 14-09-18 15:13:28, Richard Guy Briggs wrote: > > On 2018-09-04 18:06, Jan Kara wrote: > > > Hello, > > > > Jan, > > > > > this is the third revision of the series that addresses problems I have > > > identified when trying to understand how exactly is kernel/audit_tree.c using > > > generic fsnotify framework. I hope I have understood all the interactions right > > > but careful review is certainly welcome. > > > > I've tried to review it as carefully as I am able. As best I understand > > it, this all looks reasonable and an improvement over the previous > > state. Thanks for the hard work. > > > > FWIW, > > Reviewed-by: Richard Guy Briggs > > Thanks for review! Paul should I send you updated patch 9 with that one > variable renamed or will you do that small change while merging the series? Hi Jan, Thanks again for these patches and your patience; some travel, holidays, and a job change delayed my review. However, everything looks okay to me (minus the one problem I noted in patch 09/11). I've added the patches to audit/working-fsnotify_fixes and I'm going to start stressing them as soon as I get a test kernel built with the idea of merging them into audit/next as soon as the upcoming merge window closes. As far as the variable rename is concerned, that's not something I would prefer to change during a merge, but if you or Richard wanted to submit a renaming patch I would be okay with that in this case. If you do submit the rename patch, please base it on top of this patchset (or audit/working-fsnotify_fixes). Thanks! -- paul moore www.paul-moore.com