From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A2AFC10DCE for ; Tue, 10 Mar 2020 21:43:23 +0000 (UTC) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E99CD222C3 for ; Tue, 10 Mar 2020 21:43:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SjBfNAF4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E99CD222C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paul-moore.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-audit-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583876601; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=6k2li/cp+NGmPaCmJ1jbaYaavubT8VKomg4NS40JPfY=; b=SjBfNAF40qQwH96F/Vwhd4fsIZmsiDV1t6jK+kPP8XeaSWNGTvb0KBf+hBDCSMT8k8aaFh tYgfjnNBThunBcFjzgrmO1YjSd2iAkHTXDl+H3a5pVEgZx7DZ2hJwytg9cvTZterLVwn5J 5JEWcauk4B/C1BqDWnlm7/JNNw8eXiE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-419-VWlDAND-PjCJ3pxqmiCG6A-1; Tue, 10 Mar 2020 17:43:19 -0400 X-MC-Unique: VWlDAND-PjCJ3pxqmiCG6A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DF59F801E67; Tue, 10 Mar 2020 21:43:13 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D343D5D9CA; Tue, 10 Mar 2020 21:43:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 28A8386A0D; Tue, 10 Mar 2020 21:43:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02ALh57d015548 for ; Tue, 10 Mar 2020 17:43:05 -0400 Received: by smtp.corp.redhat.com (Postfix) id F35C8F4D4B; Tue, 10 Mar 2020 21:43:04 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ED561F84F0 for ; Tue, 10 Mar 2020 21:43:03 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EF8F6101A55D for ; Tue, 10 Mar 2020 21:43:02 +0000 (UTC) Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-195-BvCLXas-Pzefn5q9qAwkfA-1; Tue, 10 Mar 2020 17:43:00 -0400 X-MC-Unique: BvCLXas-Pzefn5q9qAwkfA-1 Received: by mail-ed1-f42.google.com with SMTP id dc19so218760edb.10 for ; Tue, 10 Mar 2020 14:42:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EJML0BofqucT/jZjhfGnVkELRi3YEpRBvc8rWE2xC/Q=; b=CyUg2QHrCbxdP7hWcnymgP2R+pcuV9WbEBx4pf+Ag1ktv27ZwdV85Lb0xS52X5K//D B52cQAj7KqY8i++ZX206m7oxrj8GexY/BQeLKALUrjFhNCjPGmuWLEulOdZ5GUypEpE0 2U/5rKwDrsEcKISvKDlWe+xyUbHE/oTPbnYO5Jqaxi8RRQSr+r4YukbZJ7NAzs1iT5aZ LVbLnIEoR5whoeR5/Fe4xPoaYUU7Sr1Ux4ywwJMNmz+AlAzpNNEbTpC2eNnprZ2RJkF2 uVY4kmb07Nm0YU3tP08+g1zLmN5RUpwMzn1pR/DMn0rJRimjei0JiESbTMdHeZPYDvH5 O9SQ== X-Gm-Message-State: ANhLgQ0SNRQQxsEQtrqxSqHsf6GtqUWQTwiqofi2bQga6yrLuZKBvzQ7 ATcpfooP2vIa+i6VpgbD5VtkMO6vpyqsuWH7IsZJAuY= X-Google-Smtp-Source: ADFU+vtq578lHHSxMBadIdzBgXGMldlBdTWVnCQ+5WrTvvyqBJNkbl0Z8XGBRKDohO9p2i8qt+Lm6Uj3ooWAOrpw8y8= X-Received: by 2002:a17:907:9d8:: with SMTP id bx24mr21404208ejc.271.1583876578608; Tue, 10 Mar 2020 14:42:58 -0700 (PDT) MIME-Version: 1.0 References: <20200222000407.110158-1-casey@schaufler-ca.com> <20200222000407.110158-14-casey@schaufler-ca.com> <42b3a4f0-c6ee-516a-7d10-726222c42b78@schaufler-ca.com> In-Reply-To: From: Paul Moore Date: Tue, 10 Mar 2020 17:42:47 -0400 Message-ID: Subject: Re: [PATCH v15 21/23] Audit: Include object data for all security modules To: Casey Schaufler X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 02ALh57d015548 X-loop: linux-audit@redhat.com Cc: casey.schaufler@intel.com, linux-audit@redhat.com X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Mar 9, 2020 at 7:01 PM Casey Schaufler wrote: > On 3/9/2020 10:59 AM, Paul Moore wrote: > > On Mon, Mar 9, 2020 at 1:45 PM Casey Schaufler wrote: > >> On 3/6/2020 6:31 PM, Paul Moore wrote: > >>> Either way, the "obj=" field should stay where it is, but the > >>> "obj_XXX=" fields need to find their way to the end of the record. > >> As Steve pointed out, there may be a bigger issue here. If the additional > >> fields aren't going to fit in MAX_AUDIT_MESSAGE_LENGTH bytes another > >> format may be required. I had hoped that perhaps obj_selinux= might count > >> as a refinement to obj= and hence not be considered a new field, but > >> it looks like that's not flying. > > Regardless, the field placement guidance remains the same. > > I hear that clearly. End of record. > > > > As far as the record limitation; yes, Steve's audit userspace does > > have a limit, but I do wonder how limiting an 8k record size really is > > for the majority of systems. My guess is "not too bad". > > Two large path names would be the only worrisome case. > It seems that adding multiple labels will rarely be an issue in > practice, but if we can avoid the difference between theory and > practice we'll be ahead. > > > If you are > > concerned about that, I imagine you could always tack on a new record > > to relevant events with additional LSM subj/obj info. > > This seems safest, if doing so would be allowed. I'm open to other suggestions, although I'm struggling to think of options that don't massively break compat with older userspace. -- paul moore www.paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit