From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D930AC433EF for ; Sun, 15 May 2022 23:35:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237036AbiEOXfe (ORCPT ); Sun, 15 May 2022 19:35:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233542AbiEOXfb (ORCPT ); Sun, 15 May 2022 19:35:31 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 286A02AC5B for ; Sun, 15 May 2022 16:35:29 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id j24so3083726wrb.1 for ; Sun, 15 May 2022 16:35:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WPiN/r7HiMX+E0gD/NyxlaBSFfT8UOFIF8dQ5IYINeA=; b=DOSui03D88ZpB/o1amMdo7Bkew8vnXHYL2X4D4OL/XUpCP8eVTH3zro7V07Rp3Tr9o uDZCkusHAGtnreWzbgOZWyoOy7NVCp7pH3k9zKaq5NRy5GiKDrf1Gq6da03wg+vYb+vm gg4tBMzexInFqZOm4f+CJuK7+ksj3v960+ao7kV35ZihLf8UOfEMYUzCQF9++hS2fNiB xo0OcJhIYFUaVIAxxlvbc6JIkUBl3qUtDUfUrT+1zGzz0zrBBHzAETjfxln0ptXeXzT/ GeZUaCjdZBzdNR13DGP2hVb88Z1TkttdvB+Z++/rXRMiY6COkux8ZGSNXv2uGCuNGfd4 BP5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WPiN/r7HiMX+E0gD/NyxlaBSFfT8UOFIF8dQ5IYINeA=; b=Il4Gj3CMiH0DB1SUP1RgMklNlp3jO0z9zbibdtG62hw4Jf6g8x0M3fqDjD6J83dW2b FixLfh/07gs4+hITCRWrnBP3eJX81MqY+z1kKlJi7yAsra1PcbrAqS/khvejUZACm5eh 3XqVnOpqlEhwjBV9lX7sxiCgx48DQH88SiusoYqTah4kGK4aRbe7csHmxu3nbAXJs9zg 1v7FND3nn34pr/BXVvC8nURvK98yTaN9fNTguyBGKGteyvOw08xuXhzP15f1LXLssxmS jvGaJMaUEEv6/oRhpCxy2+vCCpuIXDtZCIEGAKpJd9CPIamhPzoQ4/nIy95xmFklfJvS FwBw== X-Gm-Message-State: AOAM5331sMto1Y5xWyOYE+dcavdNYsxaVcjfSyxofSMLp2yTgCBDFqvH +GcJ5PO8cZHFpNPNTRfueMElww/FgoKh7PVvGv1O X-Google-Smtp-Source: ABdhPJxuYOOfU0Ks/SZbo/L2GWmDeH/U2y3e+Vl13QVKGqg8UoL28NaONP7pLHcz79RXHTJa0UlxQNvVNgpNF01Dod4= X-Received: by 2002:a5d:52ce:0:b0:20c:e030:b05a with SMTP id r14-20020a5d52ce000000b0020ce030b05amr11743818wrv.174.1652657727735; Sun, 15 May 2022 16:35:27 -0700 (PDT) MIME-Version: 1.0 References: <20220515073110.304193-1-sshedi@vmware.com> In-Reply-To: <20220515073110.304193-1-sshedi@vmware.com> From: Paul Moore Date: Sun, 15 May 2022 19:35:16 -0400 Message-ID: Subject: Re: [PATCH 1/2] audit: remove redundant data_len check To: Shreenidhi Shedi Cc: eparis@redhat.com, linux-kernel@vger.kernel.org, linux-audit@redhat.com, Shreenidhi Shedi Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 15, 2022 at 3:31 AM Shreenidhi Shedi wrote: > > data_len is already getting checked if it's less than 2 earlier in this > function. > > Signed-off-by: Shreenidhi Shedi > --- > kernel/audit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, this patch looks okay, but since we are already at v5.18-rc7 this patch will have to wait until after the upcoming merge window as it isn't a critical bug fix. -- paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A119C433EF for ; Sun, 15 May 2022 23:35:41 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-199-3Niod3DXP5qvWa5gm6mFDg-1; Sun, 15 May 2022 19:35:36 -0400 X-MC-Unique: 3Niod3DXP5qvWa5gm6mFDg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BA15F803CB8; Sun, 15 May 2022 23:35:35 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7B7C82024CC8; Sun, 15 May 2022 23:35:35 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 099F21947055; Sun, 15 May 2022 23:35:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 4567D194704D for ; Sun, 15 May 2022 23:35:34 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 245EA9D7B; Sun, 15 May 2022 23:35:34 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2017A9D7A for ; Sun, 15 May 2022 23:35:30 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B918D811E75 for ; Sun, 15 May 2022 23:35:30 +0000 (UTC) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-595-vnOHLw6fNROi2Ws2iDn6-A-1; Sun, 15 May 2022 19:35:29 -0400 X-MC-Unique: vnOHLw6fNROi2Ws2iDn6-A-1 Received: by mail-wr1-f48.google.com with SMTP id g17so195590wrb.11 for ; Sun, 15 May 2022 16:35:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WPiN/r7HiMX+E0gD/NyxlaBSFfT8UOFIF8dQ5IYINeA=; b=e/2+HMnXYLkLLMKk8YgBihu+n0Xq8a4Uc1aax4DWkbbO85Lg1GOvObecYlSL02Si7o klK8zlihrD6c4jOqKwUwVMd3ZOONIH1veuoWDg4zIK0xHatv3u7u1ko/XStBkAccOkfS i59VOlg+nvGnI5PMr1GQBfoPE7UBc+Eh7KgY42/gn4yqKDPLZUyMeFLa7ChcdxA0KcSn x15CovBdE1KwplEzWZup/mXpR0KiN31Fvgt1xzhCLTRfUb5rjrSvj4Z5vZFgPAupmCQo wWc4Bw147duvPuWuBpjzq32INII0O37sqSeLy5DEMA4WAFSL+i0epM5hFGKNDppnImsL Jmuw== X-Gm-Message-State: AOAM532GY6CE3m11y5oDwAT1bUzQRMtA5NsD/rXLYrvLrp2lCCGyI70n 1m5do7LZUSAVC1e4/AAtrUvBRtMS/DuE+Bj7dPib X-Google-Smtp-Source: ABdhPJxuYOOfU0Ks/SZbo/L2GWmDeH/U2y3e+Vl13QVKGqg8UoL28NaONP7pLHcz79RXHTJa0UlxQNvVNgpNF01Dod4= X-Received: by 2002:a5d:52ce:0:b0:20c:e030:b05a with SMTP id r14-20020a5d52ce000000b0020ce030b05amr11743818wrv.174.1652657727735; Sun, 15 May 2022 16:35:27 -0700 (PDT) MIME-Version: 1.0 References: <20220515073110.304193-1-sshedi@vmware.com> In-Reply-To: <20220515073110.304193-1-sshedi@vmware.com> From: Paul Moore Date: Sun, 15 May 2022 19:35:16 -0400 Message-ID: Subject: Re: [PATCH 1/2] audit: remove redundant data_len check To: Shreenidhi Shedi X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shreenidhi Shedi , linux-audit@redhat.com, linux-kernel@vger.kernel.org, eparis@redhat.com Errors-To: linux-audit-bounces@redhat.com Sender: "Linux-audit" X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sun, May 15, 2022 at 3:31 AM Shreenidhi Shedi wrote: > > data_len is already getting checked if it's less than 2 earlier in this > function. > > Signed-off-by: Shreenidhi Shedi > --- > kernel/audit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, this patch looks okay, but since we are already at v5.18-rc7 this patch will have to wait until after the upcoming merge window as it isn't a critical bug fix. -- paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit