* [PATCH] selinux: Remove load size limit
@ 2019-09-21 1:57 zhanglin
2019-10-01 13:36 ` Paul Moore
0 siblings, 1 reply; 2+ messages in thread
From: zhanglin @ 2019-09-21 1:57 UTC (permalink / raw)
To: paul
Cc: sds, eparis, selinux, linux-kernel, xue.zhihong, wang.yi59,
jiang.xuexin, zhanglin
Load size was limited to 64MB, this was legacy limitation due to vmalloc()
which was removed a while ago.
Limiting load size to 64MB is both pointless and affects real world use
cases.
Signed-off-by: zhanglin <zhang.lin16@zte.com.cn>
---
security/selinux/selinuxfs.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c
index f3a5a138a096..4249400e9712 100644
--- a/security/selinux/selinuxfs.c
+++ b/security/selinux/selinuxfs.c
@@ -549,10 +549,6 @@ static ssize_t sel_write_load(struct file *file, const char __user *buf,
if (*ppos != 0)
goto out;
- length = -EFBIG;
- if (count > 64 * 1024 * 1024)
- goto out;
-
length = -ENOMEM;
data = vmalloc(count);
if (!data)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selinux: Remove load size limit
2019-09-21 1:57 [PATCH] selinux: Remove load size limit zhanglin
@ 2019-10-01 13:36 ` Paul Moore
0 siblings, 0 replies; 2+ messages in thread
From: Paul Moore @ 2019-10-01 13:36 UTC (permalink / raw)
To: zhanglin
Cc: Stephen Smalley, Eric Paris, selinux, linux-kernel, xue.zhihong,
wang.yi59, jiang.xuexin
On Fri, Sep 20, 2019 at 9:55 PM zhanglin <zhang.lin16@zte.com.cn> wrote:
> Load size was limited to 64MB, this was legacy limitation due to vmalloc()
> which was removed a while ago.
>
> Limiting load size to 64MB is both pointless and affects real world use
> cases.
>
> Signed-off-by: zhanglin <zhang.lin16@zte.com.cn>
> ---
> security/selinux/selinuxfs.c | 4 ----
> 1 file changed, 4 deletions(-)
I just merged this into selinux/next (thank you!), but I removed the
last sentence in the description that mentioned "real world use cases"
since that appears to be a cut-n-paste artifact and not a reflection
of what we are currently seeing from users.
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-01 13:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-21 1:57 [PATCH] selinux: Remove load size limit zhanglin
2019-10-01 13:36 ` Paul Moore
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.