From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756129AbeDYSvS (ORCPT ); Wed, 25 Apr 2018 14:51:18 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:43934 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755371AbeDYSvP (ORCPT ); Wed, 25 Apr 2018 14:51:15 -0400 X-Google-Smtp-Source: AB8JxZqjboaCrl4yewxQehWeMop7occdfQ9Oe9vjRTdzpjtz9uX8ce15HmBmIu1ZTwJIhzP+EjAObFvLjnwPAMTXyok= MIME-Version: 1.0 X-Originating-IP: [108.20.156.165] In-Reply-To: References: <20180423133015.5455-1-dh.herrmann@gmail.com> From: Paul Moore Date: Wed, 25 Apr 2018 14:51:12 -0400 Message-ID: Subject: Re: [PATCH 0/3] Introduce LSM-hook for socketpair(2) To: James Morris Cc: David Herrmann , linux-kernel@vger.kernel.org, teg@jklm.no, Stephen Smalley , selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org, Eric Paris , "Serge E. Hallyn" , "David S. Miller" , netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 25, 2018 at 2:44 PM, James Morris wrote: > On Mon, 23 Apr 2018, David Herrmann wrote: >> This patch series tries to close this gap and makes both behave the >> same. A new LSM-hook is added which allows LSMs to cache the correct >> peer information on newly created socket-pairs. > > Looks okay to me. > > Once it's respun with the Smack backend and maybe the hook name change, > I'll merge this unless DaveM wants it to go in via his networking tree. Note my objection to the hook placement in patch 2/3; I think we should move the hook out of the AF_UNIX layer and up into the socket layer. -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: paul@paul-moore.com (Paul Moore) Date: Wed, 25 Apr 2018 14:51:12 -0400 Subject: [PATCH 0/3] Introduce LSM-hook for socketpair(2) In-Reply-To: References: <20180423133015.5455-1-dh.herrmann@gmail.com> Message-ID: To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Wed, Apr 25, 2018 at 2:44 PM, James Morris wrote: > On Mon, 23 Apr 2018, David Herrmann wrote: >> This patch series tries to close this gap and makes both behave the >> same. A new LSM-hook is added which allows LSMs to cache the correct >> peer information on newly created socket-pairs. > > Looks okay to me. > > Once it's respun with the Smack backend and maybe the hook name change, > I'll merge this unless DaveM wants it to go in via his networking tree. Note my objection to the hook placement in patch 2/3; I think we should move the hook out of the AF_UNIX layer and up into the socket layer. -- paul moore www.paul-moore.com -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html