From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC53DC4707A for ; Fri, 21 May 2021 20:20:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B281613E1 for ; Fri, 21 May 2021 20:20:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231331AbhEUUVX (ORCPT ); Fri, 21 May 2021 16:21:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230460AbhEUUVJ (ORCPT ); Fri, 21 May 2021 16:21:09 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DD85C06134E for ; Fri, 21 May 2021 13:19:34 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id h16so24653179edr.6 for ; Fri, 21 May 2021 13:19:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sSrJSQySUjx6FPqWl2/q5eAJB4T53E7fGvZWzpBPOis=; b=MjlAT5npheGS9uTNSbjiOXadoRxl/8jmvEI8G9aDhy7xqJUrdNYvGpkA8Xm60gTQkp K1BTWZE6r1FxeohLoTpdGsCICxR7jyT3hPcrIezLSGjSPrEyfdMzPjpvhdY5crrXj9PC ZASC00zQwWpR4VeG7cqgBg0ZjGjrhYqZy+27ZMUEx5VwUPTIk/A9DOkA6TZyuDrRvWl+ FEk48QpMRPHZOZbfa8x1807awJmoQeWYH3h1c4zRDqv5HtJkTwnMWrPLROjBgOSyO482 tVpmtr+pj2RPNNlrZekE6tP+JfVVvamRFyz3wtLUMNYKGfz4Z1EciHFs1ZXFoefUOE0h 1/TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sSrJSQySUjx6FPqWl2/q5eAJB4T53E7fGvZWzpBPOis=; b=MERu4jDTEeCU4MlvPg1fxZBtpaYzg0x6cI5ckgFqr8iTnl6/3ltiuQyzegWcVv0vg9 1XSe5avYJY4Nv6P8VVlVvhrCEinnYuCDIGGOUBbEUykse6tUWIO2kOD9Qp3/3PlMVN+V g+S7Abye45psCuLgeO4RhFoFn4bx8kqplTydweVnVBxTDppPZ+huVewiUeMReI2z/LEu KHwoIiPIcAo7RioEaV6BigMpOMxqmx2M5LPoLjojOLZYLoT3lc99o+hECmjNzKrxtoY0 mu3kc6kn86Z4ZiliyKJxw/+S+OObTvlylaOSp1NPE5+Ue5EMSIZNseNAxZC5kABbF7ro AVYA== X-Gm-Message-State: AOAM531C2Dro39yBnVUlkJqjGOL8VfIz4J1574KW3OG1Z4Gze7oiSH9U c2usMw0wuDd4TbjQr6dR46R92OCPSksSwcrEx7bs X-Google-Smtp-Source: ABdhPJz6+FmIEqBgSBEqq6zFfzmDtBhxn7muf+nqqkYrZjNmBPvdA78mgrLy76fm/YjN7a+/ZdDseuAERhUF84zi9CQ= X-Received: by 2002:aa7:cb48:: with SMTP id w8mr13109201edt.12.1621628373077; Fri, 21 May 2021 13:19:33 -0700 (PDT) MIME-Version: 1.0 References: <20210513200807.15910-1-casey@schaufler-ca.com> <20210513200807.15910-19-casey@schaufler-ca.com> In-Reply-To: <20210513200807.15910-19-casey@schaufler-ca.com> From: Paul Moore Date: Fri, 21 May 2021 16:19:21 -0400 Message-ID: Subject: Re: [PATCH v26 18/25] LSM: security_secid_to_secctx in netlink netfilter To: Casey Schaufler Cc: casey.schaufler@intel.com, James Morris , linux-security-module@vger.kernel.org, selinux@vger.kernel.org, linux-audit@redhat.com, keescook@chromium.org, john.johansen@canonical.com, penguin-kernel@i-love.sakura.ne.jp, Stephen Smalley , linux-kernel@vger.kernel.org, Pablo Neira Ayuso , netdev@vger.kernel.org, netfilter-devel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 13, 2021 at 4:28 PM Casey Schaufler wrote: > > Change netlink netfilter interfaces to use lsmcontext > pointers, and remove scaffolding. > > Reviewed-by: Kees Cook > Reviewed-by: John Johansen > Acked-by: Stephen Smalley > Acked-by: Pablo Neira Ayuso > Signed-off-by: Casey Schaufler > Cc: netdev@vger.kernel.org > Cc: netfilter-devel@vger.kernel.org > --- > net/netfilter/nfnetlink_queue.c | 37 +++++++++++++-------------------- > 1 file changed, 14 insertions(+), 23 deletions(-) Acked-by: Paul Moore -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A07DBC4707A for ; Fri, 21 May 2021 20:19:50 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16EC8613E1 for ; Fri, 21 May 2021 20:19:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16EC8613E1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paul-moore.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-229-69x3OqI-M_-_wT-2bmt7xA-1; Fri, 21 May 2021 16:19:46 -0400 X-MC-Unique: 69x3OqI-M_-_wT-2bmt7xA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EB820803620; Fri, 21 May 2021 20:19:42 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DA8501B528; Fri, 21 May 2021 20:19:42 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B9B1F44A62; Fri, 21 May 2021 20:19:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 14LKJe5L012243 for ; Fri, 21 May 2021 16:19:40 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8FD9C117C2E0; Fri, 21 May 2021 20:19:40 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8A331117C2E1 for ; Fri, 21 May 2021 20:19:37 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3480B833942 for ; Fri, 21 May 2021 20:19:37 +0000 (UTC) Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-280-QdmPVURCNh2b-Ptx_CahTA-1; Fri, 21 May 2021 16:19:34 -0400 X-MC-Unique: QdmPVURCNh2b-Ptx_CahTA-1 Received: by mail-ed1-f54.google.com with SMTP id df21so24677669edb.3 for ; Fri, 21 May 2021 13:19:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sSrJSQySUjx6FPqWl2/q5eAJB4T53E7fGvZWzpBPOis=; b=Y3J++7a20PNKFy7edaJDqVvbKigAyLn3XrvdZ+zk9pVoDyAwXPI9yV6JhM3CNN5vAu mEPlSPCj1llRpvWxwQOAv7vVtikFMu/qkdNFSgcRJOTGOeu9MoceMQU+mVms8WvsVF97 zXO0jAvt9Eolwoqnyj4igG8IRKME49JhldwRsK1isMV3Cpr3cUzFGlOCg8le4jk3RL7x EL6+LYQ1nLqIIMPk8VdkpuIdAT944f61CCKPqbRiF7eiH6bsWFNOFZHcjN9gu62F5oOI snN4jC0Qt5CG0VIw8a67xQwB8BQThvi5FqJDa2kcxMVNG2TIDgn7qaW70YObVQUx9vsy brEQ== X-Gm-Message-State: AOAM530uXWKRzmha0GucSNOZeOwDTAqspIexagnFQgtWb8wvaMR7hetp PDBJnNPmVA/94b/hWDYmYgoTj/e6H9+HS2qTBfRR X-Google-Smtp-Source: ABdhPJz6+FmIEqBgSBEqq6zFfzmDtBhxn7muf+nqqkYrZjNmBPvdA78mgrLy76fm/YjN7a+/ZdDseuAERhUF84zi9CQ= X-Received: by 2002:aa7:cb48:: with SMTP id w8mr13109201edt.12.1621628373077; Fri, 21 May 2021 13:19:33 -0700 (PDT) MIME-Version: 1.0 References: <20210513200807.15910-1-casey@schaufler-ca.com> <20210513200807.15910-19-casey@schaufler-ca.com> In-Reply-To: <20210513200807.15910-19-casey@schaufler-ca.com> From: Paul Moore Date: Fri, 21 May 2021 16:19:21 -0400 Message-ID: Subject: Re: [PATCH v26 18/25] LSM: security_secid_to_secctx in netlink netfilter To: Casey Schaufler X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: linux-audit@redhat.com Cc: john.johansen@canonical.com, selinux@vger.kernel.org, netdev@vger.kernel.org, James Morris , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-audit@redhat.com, netfilter-devel@vger.kernel.org, casey.schaufler@intel.com, Stephen Smalley , Pablo Neira Ayuso X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, May 13, 2021 at 4:28 PM Casey Schaufler wrote: > > Change netlink netfilter interfaces to use lsmcontext > pointers, and remove scaffolding. > > Reviewed-by: Kees Cook > Reviewed-by: John Johansen > Acked-by: Stephen Smalley > Acked-by: Pablo Neira Ayuso > Signed-off-by: Casey Schaufler > Cc: netdev@vger.kernel.org > Cc: netfilter-devel@vger.kernel.org > --- > net/netfilter/nfnetlink_queue.c | 37 +++++++++++++-------------------- > 1 file changed, 14 insertions(+), 23 deletions(-) Acked-by: Paul Moore -- paul moore www.paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit