From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 769DEC43331 for ; Wed, 27 Jan 2021 03:18:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F79B206C1 for ; Wed, 27 Jan 2021 03:18:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235132AbhA0DPp (ORCPT ); Tue, 26 Jan 2021 22:15:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392321AbhAZUG1 (ORCPT ); Tue, 26 Jan 2021 15:06:27 -0500 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D486C061756 for ; Tue, 26 Jan 2021 12:05:45 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id z22so6576438edb.9 for ; Tue, 26 Jan 2021 12:05:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZzjmGy0oL0rvnaJhjHzvUitQdjvDnUa+214czaKdGnA=; b=oF2cQsl0GAPwXBG2Ww0q9O85pkErIVGR2iQFzCl3fyldSMMolS50vS13rcLJUZGn0q pWPzzZN7kJVj6PNIIDihPQ57NR1AUnLEZ7OFW0/nYImJ4O+ZSVaRAzeXPqr1Ou4HQ7Ib u3Bj3rVKwapzmtfGoc1+yAu86eqwhaKzCU8dozKHNLfKgBn5LPOGm3HhuJnY1wVdxqlJ z2Gf7ICdQXPK2WcXlP+fFEcodWWsIEEXXcZYZe9hz1V2UqLzm6WIVW3Ou4BmNQ3zca0o QbwqAxnBI1Kf397ABOuX+Ob4ps7I34H2A15bCd8uRPvhV1pydBKEhcb8/fTV6Pl/1aFl z82g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZzjmGy0oL0rvnaJhjHzvUitQdjvDnUa+214czaKdGnA=; b=ghNJbardo3R9HivRnKQjlMq6nJbBTQlDzTOQCOaMlHEmM7+2AjAq7ziEYtKYjFfj6Z eTqKzsUDqiQTj3/RyfzUSUOqTEByBDlFU4bzadxG7nO3EZyG/k02nU0pt6I6AUbsfMNf qSwMlTL9wSDJN+8F6rz9SupzDq4ARxl8AuboQrtWKbUKF/5kj+194QMW/2Kbhd1n/gNt pQeDnavCw8NkNZwiXdbkF7osqp3P5p7jEU0P0cY+cJOg8VyGOwqd3dtpHwh5u+vAkViF C4/1RGSA/1YeiTeRiYmmC7svuScp1GeTjpBgX5P8GJNnVYluskNF1049mKPPElpxbVrk DhlQ== X-Gm-Message-State: AOAM530c1C16UWELrEDIEVWxKwPx3zzm0UL3MfhSay1sL72Rf3OINoi+ fpqL3YFn48zy1mfKz8RrCIpWG/pQtrW6Dk4qfuFC X-Google-Smtp-Source: ABdhPJyMOLOliiATOkZ4ERhtuxbTd3QWUMvRFlx9Yy9aqe0YyblGN5PjNZyYAGPRFmjGlQK0P3fD+x5QxodPBG51rsw= X-Received: by 2002:a05:6402:54d:: with SMTP id i13mr5868684edx.12.1611691543921; Tue, 26 Jan 2021 12:05:43 -0800 (PST) MIME-Version: 1.0 References: <20210126164108.1958-1-casey@schaufler-ca.com> <20210126164108.1958-22-casey@schaufler-ca.com> <20210126184246.GM1762914@madcap2.tricolour.ca> In-Reply-To: From: Paul Moore Date: Tue, 26 Jan 2021 15:05:32 -0500 Message-ID: Subject: Re: [PATCH v24 21/25] audit: add support for non-syscall auxiliary records To: Casey Schaufler Cc: Richard Guy Briggs , casey.schaufler@intel.com, James Morris , linux-security-module@vger.kernel.org, selinux@vger.kernel.org, linux-audit@redhat.com, keescook@chromium.org, john.johansen@canonical.com, penguin-kernel@i-love.sakura.ne.jp, Stephen Smalley , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 26, 2021 at 1:58 PM Casey Schaufler wrote: > > On 1/26/2021 10:42 AM, Richard Guy Briggs wrote: > > On 2021-01-26 08:41, Casey Schaufler wrote: > >> Standalone audit records have the timestamp and serial number generated > >> on the fly and as such are unique, making them standalone. This new > >> function audit_alloc_local() generates a local audit context that will > >> be used only for a standalone record and its auxiliary record(s). The > >> context is discarded immediately after the local associated records are > >> produced. > >> > >> Signed-off-by: Richard Guy Briggs > >> Signed-off-by: Casey Schaufler > >> Cc: linux-audit@redhat.com > >> To: Richard Guy Briggs > > This has been minorly bothering me for several revisions... Is there a > > way for the development/authorship to be accurately reflected > > if/when this patch is merged before the contid patch set? > > I don't know the right way to do that because I had to pull > some of what was in the original patch out. Any way you would > like it done is fine with me. I'm not sure if there is one perfect way. I typically see either a "From: " line if the author is different from the submitter, or in more complex cases such as this it seems like a simple note giving credit in the description might be the best option. -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E65FC433DB for ; Tue, 26 Jan 2021 20:08:32 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 938B222240 for ; Tue, 26 Jan 2021 20:08:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 938B222240 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paul-moore.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-514-pHB7QDGmPpWarD3k0ZIkBw-1; Tue, 26 Jan 2021 15:08:28 -0500 X-MC-Unique: pHB7QDGmPpWarD3k0ZIkBw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D7BD01005504; Tue, 26 Jan 2021 20:08:24 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 831455D9DE; Tue, 26 Jan 2021 20:08:24 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 738D6180954D; Tue, 26 Jan 2021 20:08:05 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 10QK5oIA026985 for ; Tue, 26 Jan 2021 15:05:50 -0500 Received: by smtp.corp.redhat.com (Postfix) id 3A4261003219; Tue, 26 Jan 2021 20:05:50 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 36732100415A for ; Tue, 26 Jan 2021 20:05:47 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DF35B101A562 for ; Tue, 26 Jan 2021 20:05:47 +0000 (UTC) Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-543-XXLxbNCHNJWiaOqOVr3x0A-1; Tue, 26 Jan 2021 15:05:45 -0500 X-MC-Unique: XXLxbNCHNJWiaOqOVr3x0A-1 Received: by mail-ed1-f50.google.com with SMTP id n6so21257243edt.10 for ; Tue, 26 Jan 2021 12:05:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZzjmGy0oL0rvnaJhjHzvUitQdjvDnUa+214czaKdGnA=; b=CBLkRMFBLRqLj241ENWGmwS+lzWtQpLnYTM6W6AEOm4+xzJ91CNOjI7LV5peQuRzwy RQsnFJTMUoK3+SdiQSSKe/OyQ3qnphMaQRDvTv4Pj9+PUaio54b7dZO3ehbtHQL3/EgZ HZrjIsSL+T5ZQ61iwO0PDCB3BAb3diDEdiA+ctO65yuiqeb19VE7IhtyUtivBss/P8JQ TpPuH3LWAaej+UxAlDGm8X2SxdMq1gWjlxp8ARnEdKq2MYA2T1MdeAhh0GlD/j8V56lV aT/0k2iT2ADZPyN6xVb3X/foNgEB0bwqrHuPwZK80gISos6CK74iYlhOGud+PuyO6obJ QDQw== X-Gm-Message-State: AOAM532JFyXVn/JSMwbX6kbT8Mm6cTzxIha4S8bqNcYp25zHBvmx2VZx CgoAOMHZZQHj/2k4WM1k+UGdFf3aA+ZTtfmuSUnIEdNk/lar X-Google-Smtp-Source: ABdhPJyMOLOliiATOkZ4ERhtuxbTd3QWUMvRFlx9Yy9aqe0YyblGN5PjNZyYAGPRFmjGlQK0P3fD+x5QxodPBG51rsw= X-Received: by 2002:a05:6402:54d:: with SMTP id i13mr5868684edx.12.1611691543921; Tue, 26 Jan 2021 12:05:43 -0800 (PST) MIME-Version: 1.0 References: <20210126164108.1958-1-casey@schaufler-ca.com> <20210126164108.1958-22-casey@schaufler-ca.com> <20210126184246.GM1762914@madcap2.tricolour.ca> In-Reply-To: From: Paul Moore Date: Tue, 26 Jan 2021 15:05:32 -0500 Message-ID: Subject: Re: [PATCH v24 21/25] audit: add support for non-syscall auxiliary records To: Casey Schaufler X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: linux-audit@redhat.com Cc: john.johansen@canonical.com, Richard Guy Briggs , James Morris , linux-kernel@vger.kernel.org, selinux@vger.kernel.org, linux-security-module@vger.kernel.org, linux-audit@redhat.com, casey.schaufler@intel.com, Stephen Smalley X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Jan 26, 2021 at 1:58 PM Casey Schaufler wrote: > > On 1/26/2021 10:42 AM, Richard Guy Briggs wrote: > > On 2021-01-26 08:41, Casey Schaufler wrote: > >> Standalone audit records have the timestamp and serial number generated > >> on the fly and as such are unique, making them standalone. This new > >> function audit_alloc_local() generates a local audit context that will > >> be used only for a standalone record and its auxiliary record(s). The > >> context is discarded immediately after the local associated records are > >> produced. > >> > >> Signed-off-by: Richard Guy Briggs > >> Signed-off-by: Casey Schaufler > >> Cc: linux-audit@redhat.com > >> To: Richard Guy Briggs > > This has been minorly bothering me for several revisions... Is there a > > way for the development/authorship to be accurately reflected > > if/when this patch is merged before the contid patch set? > > I don't know the right way to do that because I had to pull > some of what was in the original patch out. Any way you would > like it done is fine with me. I'm not sure if there is one perfect way. I typically see either a "From: " line if the author is different from the submitter, or in more complex cases such as this it seems like a simple note giving credit in the description might be the best option. -- paul moore www.paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit