From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932268AbdC2PdF (ORCPT ); Wed, 29 Mar 2017 11:33:05 -0400 Received: from mail-vk0-f68.google.com ([209.85.213.68]:35333 "EHLO mail-vk0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932193AbdC2PdC (ORCPT ); Wed, 29 Mar 2017 11:33:02 -0400 MIME-Version: 1.0 X-Originating-IP: [108.49.102.27] In-Reply-To: <9202247d-8f44-8839-cf78-453b6e3b7d1e@users.sourceforge.net> References: <9202247d-8f44-8839-cf78-453b6e3b7d1e@users.sourceforge.net> From: Paul Moore Date: Wed, 29 Mar 2017 11:32:50 -0400 Message-ID: Subject: Re: [PATCH 37/46] selinux: Move an assignment for the variable "rc" in policydb_load_isids() To: SF Markus Elfring Cc: linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, Eric Paris , James Morris , "Serge E. Hallyn" , Stephen Smalley , William Roberts , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 15, 2017 at 10:37 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Jan 2017 11:24:51 +0100 > > A local variable was set to an error code in one case before a concrete > error situation was detected. Thus move the corresponding assignment into > an if branch to indicate a software failure there. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/policydb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Dropped as previously discussed. > diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c > index 7cf635c650dc..faa6ecc2450d 100644 > --- a/security/selinux/ss/policydb.c > +++ b/security/selinux/ss/policydb.c > @@ -897,10 +897,10 @@ int policydb_load_isids(struct policydb *p, struct sidtab *s) > > head = p->ocontexts[OCON_ISID]; > for (c = head; c; c = c->next) { > - rc = -EINVAL; > if (!c->context[0].user) { > printk(KERN_ERR "SELinux: SID %s was never defined.\n", > c->u.name); > + rc = -EINVAL; > goto out; > } > > -- > 2.11.0 > -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Moore Date: Wed, 29 Mar 2017 15:32:50 +0000 Subject: Re: [PATCH 37/46] selinux: Move an assignment for the variable "rc" in policydb_load_isids() Message-Id: List-Id: References: <9202247d-8f44-8839-cf78-453b6e3b7d1e@users.sourceforge.net> In-Reply-To: <9202247d-8f44-8839-cf78-453b6e3b7d1e@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-security-module@vger.kernel.org On Sun, Jan 15, 2017 at 10:37 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Jan 2017 11:24:51 +0100 > > A local variable was set to an error code in one case before a concrete > error situation was detected. Thus move the corresponding assignment into > an if branch to indicate a software failure there. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/policydb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Dropped as previously discussed. > diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c > index 7cf635c650dc..faa6ecc2450d 100644 > --- a/security/selinux/ss/policydb.c > +++ b/security/selinux/ss/policydb.c > @@ -897,10 +897,10 @@ int policydb_load_isids(struct policydb *p, struct sidtab *s) > > head = p->ocontexts[OCON_ISID]; > for (c = head; c; c = c->next) { > - rc = -EINVAL; > if (!c->context[0].user) { > printk(KERN_ERR "SELinux: SID %s was never defined.\n", > c->u.name); > + rc = -EINVAL; > goto out; > } > > -- > 2.11.0 > -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: paul@paul-moore.com (Paul Moore) Date: Wed, 29 Mar 2017 11:32:50 -0400 Subject: [PATCH 37/46] selinux: Move an assignment for the variable "rc" in policydb_load_isids() In-Reply-To: <9202247d-8f44-8839-cf78-453b6e3b7d1e@users.sourceforge.net> References: <9202247d-8f44-8839-cf78-453b6e3b7d1e@users.sourceforge.net> Message-ID: To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Sun, Jan 15, 2017 at 10:37 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Jan 2017 11:24:51 +0100 > > A local variable was set to an error code in one case before a concrete > error situation was detected. Thus move the corresponding assignment into > an if branch to indicate a software failure there. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/policydb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Dropped as previously discussed. > diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c > index 7cf635c650dc..faa6ecc2450d 100644 > --- a/security/selinux/ss/policydb.c > +++ b/security/selinux/ss/policydb.c > @@ -897,10 +897,10 @@ int policydb_load_isids(struct policydb *p, struct sidtab *s) > > head = p->ocontexts[OCON_ISID]; > for (c = head; c; c = c->next) { > - rc = -EINVAL; > if (!c->context[0].user) { > printk(KERN_ERR "SELinux: SID %s was never defined.\n", > c->u.name); > + rc = -EINVAL; > goto out; > } > > -- > 2.11.0 > -- paul moore www.paul-moore.com -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html