From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754242AbdC2PpK (ORCPT ); Wed, 29 Mar 2017 11:45:10 -0400 Received: from mail-vk0-f68.google.com ([209.85.213.68]:35296 "EHLO mail-vk0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752591AbdC2PpH (ORCPT ); Wed, 29 Mar 2017 11:45:07 -0400 MIME-Version: 1.0 X-Originating-IP: [108.49.102.27] In-Reply-To: <9ce64f74-f424-b9c5-605b-a54982888e1a@users.sourceforge.net> References: <9ce64f74-f424-b9c5-605b-a54982888e1a@users.sourceforge.net> From: Paul Moore Date: Wed, 29 Mar 2017 11:45:05 -0400 Message-ID: Subject: Re: [PATCH 43/46] selinux: Use kmalloc_array() in sidtab_init() To: SF Markus Elfring Cc: linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, Eric Paris , James Morris , "Serge E. Hallyn" , Stephen Smalley , William Roberts , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 15, 2017 at 10:43 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Jan 2017 13:13:19 +0100 > > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/sidtab.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Merged, thanks. > diff --git a/security/selinux/ss/sidtab.c b/security/selinux/ss/sidtab.c > index 5840a35155fc..c9533b21942b 100644 > --- a/security/selinux/ss/sidtab.c > +++ b/security/selinux/ss/sidtab.c > @@ -18,7 +18,7 @@ int sidtab_init(struct sidtab *s) > { > int i; > > - s->htable = kmalloc(sizeof(*(s->htable)) * SIDTAB_SIZE, GFP_ATOMIC); > + s->htable = kmalloc_array(SIDTAB_SIZE, sizeof(*s->htable), GFP_ATOMIC); > if (!s->htable) > return -ENOMEM; > for (i = 0; i < SIDTAB_SIZE; i++) > -- > 2.11.0 > -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Moore Date: Wed, 29 Mar 2017 15:45:05 +0000 Subject: Re: [PATCH 43/46] selinux: Use kmalloc_array() in sidtab_init() Message-Id: List-Id: References: <9ce64f74-f424-b9c5-605b-a54982888e1a@users.sourceforge.net> In-Reply-To: <9ce64f74-f424-b9c5-605b-a54982888e1a@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-security-module@vger.kernel.org On Sun, Jan 15, 2017 at 10:43 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Jan 2017 13:13:19 +0100 > > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/sidtab.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Merged, thanks. > diff --git a/security/selinux/ss/sidtab.c b/security/selinux/ss/sidtab.c > index 5840a35155fc..c9533b21942b 100644 > --- a/security/selinux/ss/sidtab.c > +++ b/security/selinux/ss/sidtab.c > @@ -18,7 +18,7 @@ int sidtab_init(struct sidtab *s) > { > int i; > > - s->htable = kmalloc(sizeof(*(s->htable)) * SIDTAB_SIZE, GFP_ATOMIC); > + s->htable = kmalloc_array(SIDTAB_SIZE, sizeof(*s->htable), GFP_ATOMIC); > if (!s->htable) > return -ENOMEM; > for (i = 0; i < SIDTAB_SIZE; i++) > -- > 2.11.0 > -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: paul@paul-moore.com (Paul Moore) Date: Wed, 29 Mar 2017 11:45:05 -0400 Subject: [PATCH 43/46] selinux: Use kmalloc_array() in sidtab_init() In-Reply-To: <9ce64f74-f424-b9c5-605b-a54982888e1a@users.sourceforge.net> References: <9ce64f74-f424-b9c5-605b-a54982888e1a@users.sourceforge.net> Message-ID: To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Sun, Jan 15, 2017 at 10:43 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Jan 2017 13:13:19 +0100 > > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/sidtab.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Merged, thanks. > diff --git a/security/selinux/ss/sidtab.c b/security/selinux/ss/sidtab.c > index 5840a35155fc..c9533b21942b 100644 > --- a/security/selinux/ss/sidtab.c > +++ b/security/selinux/ss/sidtab.c > @@ -18,7 +18,7 @@ int sidtab_init(struct sidtab *s) > { > int i; > > - s->htable = kmalloc(sizeof(*(s->htable)) * SIDTAB_SIZE, GFP_ATOMIC); > + s->htable = kmalloc_array(SIDTAB_SIZE, sizeof(*s->htable), GFP_ATOMIC); > if (!s->htable) > return -ENOMEM; > for (i = 0; i < SIDTAB_SIZE; i++) > -- > 2.11.0 > -- paul moore www.paul-moore.com -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html