From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752022AbdC0SeD (ORCPT ); Mon, 27 Mar 2017 14:34:03 -0400 Received: from mail-vk0-f42.google.com ([209.85.213.42]:34023 "EHLO mail-vk0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751993AbdC0Sdu (ORCPT ); Mon, 27 Mar 2017 14:33:50 -0400 MIME-Version: 1.0 X-Originating-IP: [108.49.102.27] In-Reply-To: <36ca17b3-8afe-cb9c-05bb-d406d37361e6@users.sourceforge.net> References: <36ca17b3-8afe-cb9c-05bb-d406d37361e6@users.sourceforge.net> From: Paul Moore Date: Mon, 27 Mar 2017 14:23:47 -0400 Message-ID: Subject: Re: selinux: Delete an error message for a failed memory allocation in policydb_read() To: SF Markus Elfring Cc: linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, Eric Paris , James Morris , "Serge E. Hallyn" , Stephen Smalley , William Roberts , LKML , kernel-janitors@vger.kernel.org, Wolfram Sang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2RIYxVB006753 On Mon, Mar 27, 2017 at 1:56 AM, SF Markus Elfring wrote: >> …, but I like the error message. > > How do you think about to pass the flag “__GFP_NOWARN” if you like > this information more than the default error reporting of the function “kmalloc”? Possibly, although I would encourage you to just leave it as-is for the moment. Reviewing and merging patches carries a cost, and I would very much prefer to allocate my time/resources on changes that have a more significant impact. I don't want to discourage your from contributing to SELinux development, but I do want to strongly encourage you to contribute more meaningful patches. -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Moore Date: Mon, 27 Mar 2017 18:23:47 +0000 Subject: Re: selinux: Delete an error message for a failed memory allocation in policydb_read() Message-Id: List-Id: References: <36ca17b3-8afe-cb9c-05bb-d406d37361e6@users.sourceforge.net> In-Reply-To: <36ca17b3-8afe-cb9c-05bb-d406d37361e6@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: linux-security-module@vger.kernel.org On Mon, Mar 27, 2017 at 1:56 AM, SF Markus Elfring wrote: >> …, but I like the error message. > > How do you think about to pass the flag “__GFP_NOWARN” if you like > this information more than the default error reporting of the function “kmalloc”? Possibly, although I would encourage you to just leave it as-is for the moment. Reviewing and merging patches carries a cost, and I would very much prefer to allocate my time/resources on changes that have a more significant impact. I don't want to discourage your from contributing to SELinux development, but I do want to strongly encourage you to contribute more meaningful patches. -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: paul@paul-moore.com (Paul Moore) Date: Mon, 27 Mar 2017 14:23:47 -0400 Subject: selinux: Delete an error message for a failed memory allocation in policydb_read() In-Reply-To: <36ca17b3-8afe-cb9c-05bb-d406d37361e6@users.sourceforge.net> References: <36ca17b3-8afe-cb9c-05bb-d406d37361e6@users.sourceforge.net> Message-ID: To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Mon, Mar 27, 2017 at 1:56 AM, SF Markus Elfring wrote: >> ?, but I like the error message. > > How do you think about to pass the flag ?__GFP_NOWARN? if you like > this information more than the default error reporting of the function ?kmalloc?? Possibly, although I would encourage you to just leave it as-is for the moment. Reviewing and merging patches carries a cost, and I would very much prefer to allocate my time/resources on changes that have a more significant impact. I don't want to discourage your from contributing to SELinux development, but I do want to strongly encourage you to contribute more meaningful patches. -- paul moore www.paul-moore.com -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html