From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDAFEECAAA1 for ; Wed, 31 Aug 2022 00:49:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231776AbiHaAtk (ORCPT ); Tue, 30 Aug 2022 20:49:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231876AbiHaAt0 (ORCPT ); Tue, 30 Aug 2022 20:49:26 -0400 Received: from mail-oa1-x2b.google.com (mail-oa1-x2b.google.com [IPv6:2001:4860:4864:20::2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9142AAFACA for ; Tue, 30 Aug 2022 17:49:15 -0700 (PDT) Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-11f34610d4aso10022730fac.9 for ; Tue, 30 Aug 2022 17:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc; bh=iDNoZY/hBvrGVH9LpbmO3buefvxj4JAfYTN2Wri+2DQ=; b=pq9DkG8LD0vyPgq9WEPXiu3U57hBtkreyHiQfOfFNA0Cos7XvxQ/wPHSwUGtZz02d7 mjjT5FVEOvaJ9leHUROlbXUUna04rmTV9RqJLdb1D7sLbEdATfkgnu3GzeFgK4Sg8aVq uAbYTbyCKoY2qJ4A8ENUXYx4V5na9iIYjZGy0nmKN+2lNHSf9/tGbLElX+QezcRa+mzR z4ClE+aqxF2OwjmYvzM4nOBvhsbC20DofQ1+EWeet39lPKxjQJuYOFVpiviJp9vMAY/X 4neqjMpsnVxtABiGkzvKni1j2uTIyPyexUPhFkPzYm5/+bpGUu4iONyCLm2peGlW0lm8 yLKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc; bh=iDNoZY/hBvrGVH9LpbmO3buefvxj4JAfYTN2Wri+2DQ=; b=RN4FlBH0s3fxRXXKWPBkhUpiErOss02Q34daAsRz8pqD30qUVgHfMdxm+qzrjAvV1a CPOCRUL18znTPT1FZsU+30l0G9OheqWgU7QlJBHjdaXyhCPWnopYuSAuLSoaJkt+4VNN bNPPssRL6oeg1ATHUHRSNE1Fj7rhJM8MHw0PHzCgC7Bhin/DOLvPYTaEzIbAe/v4WKrw hAqa5A3jJBPZGBDKHYH0goGFv95dqwCHfhngJ1VkaiGMFhMtQqMJo/HI+V117JfoQ4RN QeehIzmR5eoqfUKfgOcNBACm1Opj4UMF4epa23hOf4Z6UBpgx1VxpgBVblnxLfVFmOge X+gQ== X-Gm-Message-State: ACgBeo3FcIcPG6ASj9xlhKAJ0Tif0r5yfsB2+R1EKbpDFvjV8oNmXuc4 JD9VBa+JZCd+uTgrI9GpljcQV80xkKc+/4eT3YGX X-Google-Smtp-Source: AA6agR7f1XUuWYsXWLmnvTy0fEROtU/LN1joOGlwOIGmh42zEcYAcEHYs30wYP49Fh5gUV322D7byAz3wqmMYGexfko= X-Received: by 2002:a05:6808:3a9:b0:343:4b14:ccce with SMTP id n9-20020a05680803a900b003434b14cccemr262314oie.41.1661906953828; Tue, 30 Aug 2022 17:49:13 -0700 (PDT) MIME-Version: 1.0 References: <20220830105001.68478-1-wuchi.zero@gmail.com> In-Reply-To: From: Paul Moore Date: Tue, 30 Aug 2022 20:49:03 -0400 Message-ID: Subject: Re: [PATCH] audit: remove obvious unnecessary header files To: chi wu Cc: eparis@redhat.com, linux-audit@redhat.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 30, 2022 at 8:20 PM chi wu wrote: > Paul Moore =E4=BA=8E2022=E5=B9=B48=E6=9C=8831=E6=97= =A5=E5=91=A8=E4=B8=89 01:04=E5=86=99=E9=81=93=EF=BC=9A > > > > > > Hi Wuchi, can you explain what process you used to determine that > > these header file includes were unnecessary? > > When reading the code, if I don't found the user of the *.h in the *.c > file,I will think that is unnecessary. For example, #include > in the audit.c, I don't found the use of kthread* in > the file. > But, I just build that without "W=3D1 " , the after test robot show that = I > was wrong. and I don't sure that if it is true to remove some header > files. Yes, I would recommend that you focus your time and energy on other tasks within the Linux Kernel. I'm very happy to see patches which improve the audit subsystem, but I don't believe verifying the header file usage is a good use of time at this point. --=20 paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 776CDECAAA1 for ; Wed, 31 Aug 2022 00:53:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661907195; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=IP0zG+gbZrZI/1URzCWsgIOZsYnCgpYyb7TCgSfeMfY=; b=PfBzngeBmvd9byoiCHeuN4kR0xvBjZJSpKEkhyWB8joypL6Gc/z0WdDzR/Rbk3IqwU/Z4u 6Fv1Fl7GiDdsZEGarzO2zLyHIzxeukWOXt/kM/XCikkOjc7YhKphGKduko1w100EC+/T8E kebeDQnhLPG8k9mKRvjtYlcHyoCug2I= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-145-HSTHWjp_Mnm3WutpzwdwpA-1; Tue, 30 Aug 2022 20:53:12 -0400 X-MC-Unique: HSTHWjp_Mnm3WutpzwdwpA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8D55D1C05EB4; Wed, 31 Aug 2022 00:53:10 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id D07E72166B26; Wed, 31 Aug 2022 00:53:09 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9A9EC1946A42; Wed, 31 Aug 2022 00:53:09 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 167221946A40 for ; Wed, 31 Aug 2022 00:49:17 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id EBE0B2026D64; Wed, 31 Aug 2022 00:49:16 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast07.extmail.prod.ext.rdu2.redhat.com [10.11.55.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E88B92026D4C for ; Wed, 31 Aug 2022 00:49:16 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CCD663C0D864 for ; Wed, 31 Aug 2022 00:49:16 +0000 (UTC) Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-537-6qAUH1PfNi-PMZLNAP_Bcg-1; Tue, 30 Aug 2022 20:49:14 -0400 X-MC-Unique: 6qAUH1PfNi-PMZLNAP_Bcg-1 Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-11e9a7135easo18346026fac.6 for ; Tue, 30 Aug 2022 17:49:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc; bh=iDNoZY/hBvrGVH9LpbmO3buefvxj4JAfYTN2Wri+2DQ=; b=w5wgo4vEJA58/Q2mUpayq31TEVc90FhAQEBZU5hgyU8Fvm5c8NXAxZxtO7kWjxJH3V Zx69fEqB7hAWRpRch2YWkFGJDfCv/LSp5PZVJf0DYKX6FuXqyikTTQHXAKqth/D0/pUS pTSA9VkUJj4/GQrapLoeJuo3AI64Cfx+bjHs8WMQBk94b9FbF+mJzk7WWauhZti19ecb kCg5yjpstrwwvZBfj3l1QazSNv9Dj/WVe+EYhINV/aVjj2Kjf4sauTsGtY9PbCu64T06 lp6JbHZwZRuiJgtSs5ij3vNVevhrCj/Dz+Mm7DyoUX7WpjNV3a6TpEiUlEy7D8ZFYsnK aOAg== X-Gm-Message-State: ACgBeo3eTu4ZIm4ccgBfcOeS8lbbwggqN9u3sKAY2Esi2CDTl20ausaD rq1S6RJs5afW7IvKAbIobZ02BDLwf1OGBouvvczJ X-Google-Smtp-Source: AA6agR7f1XUuWYsXWLmnvTy0fEROtU/LN1joOGlwOIGmh42zEcYAcEHYs30wYP49Fh5gUV322D7byAz3wqmMYGexfko= X-Received: by 2002:a05:6808:3a9:b0:343:4b14:ccce with SMTP id n9-20020a05680803a900b003434b14cccemr262314oie.41.1661906953828; Tue, 30 Aug 2022 17:49:13 -0700 (PDT) MIME-Version: 1.0 References: <20220830105001.68478-1-wuchi.zero@gmail.com> In-Reply-To: From: Paul Moore Date: Tue, 30 Aug 2022 20:49:03 -0400 Message-ID: Subject: Re: [PATCH] audit: remove obvious unnecessary header files To: chi wu X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org, eparis@redhat.com Errors-To: linux-audit-bounces@redhat.com Sender: "Linux-audit" X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 T24gVHVlLCBBdWcgMzAsIDIwMjIgYXQgODoyMCBQTSBjaGkgd3UgPHd1Y2hpLnplcm9AZ21haWwu Y29tPiB3cm90ZToKPiBQYXVsIE1vb3JlIDxwYXVsQHBhdWwtbW9vcmUuY29tPiDkuo4yMDIy5bm0 OOaciDMx5pel5ZGo5LiJIDAxOjA05YaZ6YGT77yaCj4gPgo+ID4KPiA+IEhpIFd1Y2hpLCBjYW4g eW91IGV4cGxhaW4gd2hhdCBwcm9jZXNzIHlvdSB1c2VkIHRvIGRldGVybWluZSB0aGF0Cj4gPiB0 aGVzZSBoZWFkZXIgZmlsZSBpbmNsdWRlcyB3ZXJlIHVubmVjZXNzYXJ5Pwo+Cj4gV2hlbiByZWFk aW5nIHRoZSBjb2RlLCBpZiBJIGRvbid0IGZvdW5kIHRoZSB1c2VyIG9mIHRoZSAqLmggaW4gdGhl ICouYwo+IGZpbGUsSSB3aWxsIHRoaW5rIHRoYXQgaXMgdW5uZWNlc3NhcnkuIEZvciBleGFtcGxl LCAjaW5jbHVkZQo+IDxsaW51eC9rdGhyZWFkLmg+IGluIHRoZSBhdWRpdC5jLCBJIGRvbid0IGZv dW5kIHRoZSB1c2Ugb2Yga3RocmVhZCogaW4KPiB0aGUgZmlsZS4KPiBCdXQsIEkganVzdCBidWls ZCB0aGF0IHdpdGhvdXQgIlc9MSAiICwgdGhlIGFmdGVyIHRlc3Qgcm9ib3Qgc2hvdyB0aGF0IEkK PiB3YXMgd3JvbmcuIGFuZCBJIGRvbid0IHN1cmUgdGhhdCBpZiBpdCBpcyB0cnVlIHRvIHJlbW92 ZSBzb21lIGhlYWRlcgo+IGZpbGVzLgoKWWVzLCBJIHdvdWxkIHJlY29tbWVuZCB0aGF0IHlvdSBm b2N1cyB5b3VyIHRpbWUgYW5kIGVuZXJneSBvbiBvdGhlcgp0YXNrcyB3aXRoaW4gdGhlIExpbnV4 IEtlcm5lbC4gIEknbSB2ZXJ5IGhhcHB5IHRvIHNlZSBwYXRjaGVzIHdoaWNoCmltcHJvdmUgdGhl IGF1ZGl0IHN1YnN5c3RlbSwgYnV0IEkgZG9uJ3QgYmVsaWV2ZSB2ZXJpZnlpbmcgdGhlIGhlYWRl cgpmaWxlIHVzYWdlIGlzIGEgZ29vZCB1c2Ugb2YgdGltZSBhdCB0aGlzIHBvaW50LgoKLS0gCnBh dWwtbW9vcmUuY29tCgotLQpMaW51eC1hdWRpdCBtYWlsaW5nIGxpc3QKTGludXgtYXVkaXRAcmVk aGF0LmNvbQpodHRwczovL2xpc3RtYW4ucmVkaGF0LmNvbS9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWF1ZGl0Cg==