From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754452AbdCWUYj (ORCPT ); Thu, 23 Mar 2017 16:24:39 -0400 Received: from mail-vk0-f67.google.com ([209.85.213.67]:36553 "EHLO mail-vk0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752396AbdCWUYg (ORCPT ); Thu, 23 Mar 2017 16:24:36 -0400 MIME-Version: 1.0 X-Originating-IP: [108.49.102.27] In-Reply-To: <68a423a9-2f89-55f9-fb4c-97dd4df4bb1d@users.sourceforge.net> References: <68a423a9-2f89-55f9-fb4c-97dd4df4bb1d@users.sourceforge.net> From: Paul Moore Date: Thu, 23 Mar 2017 16:24:34 -0400 Message-ID: Subject: Re: [PATCH 01/46] selinux: Use kmalloc_array() in cond_init_bool_indexes() To: SF Markus Elfring Cc: linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, Eric Paris , James Morris , "Serge E. Hallyn" , Stephen Smalley , William Roberts , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 15, 2017 at 9:56 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 10:48:28 +0100 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > * Replace the specification of a data type by a pointer dereference > to make the corresponding size determination a bit safer according to > the Linux coding style convention. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/conditional.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Merged, thanks. Sorry for the delay. > diff --git a/security/selinux/ss/conditional.c b/security/selinux/ss/conditional.c > index 34afeadd9e73..fcfab2635c11 100644 > --- a/security/selinux/ss/conditional.c > +++ b/security/selinux/ss/conditional.c > @@ -176,8 +176,9 @@ void cond_policydb_destroy(struct policydb *p) > int cond_init_bool_indexes(struct policydb *p) > { > kfree(p->bool_val_to_struct); > - p->bool_val_to_struct = > - kmalloc(p->p_bools.nprim * sizeof(struct cond_bool_datum *), GFP_KERNEL); > + p->bool_val_to_struct = kmalloc_array(p->p_bools.nprim, > + sizeof(*p->bool_val_to_struct), > + GFP_KERNEL); > if (!p->bool_val_to_struct) > return -ENOMEM; > return 0; > -- > 2.11.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-security-module" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Moore Date: Thu, 23 Mar 2017 20:24:34 +0000 Subject: Re: [PATCH 01/46] selinux: Use kmalloc_array() in cond_init_bool_indexes() Message-Id: List-Id: References: <68a423a9-2f89-55f9-fb4c-97dd4df4bb1d@users.sourceforge.net> In-Reply-To: <68a423a9-2f89-55f9-fb4c-97dd4df4bb1d@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-security-module@vger.kernel.org On Sun, Jan 15, 2017 at 9:56 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 10:48:28 +0100 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > * Replace the specification of a data type by a pointer dereference > to make the corresponding size determination a bit safer according to > the Linux coding style convention. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/conditional.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Merged, thanks. Sorry for the delay. > diff --git a/security/selinux/ss/conditional.c b/security/selinux/ss/conditional.c > index 34afeadd9e73..fcfab2635c11 100644 > --- a/security/selinux/ss/conditional.c > +++ b/security/selinux/ss/conditional.c > @@ -176,8 +176,9 @@ void cond_policydb_destroy(struct policydb *p) > int cond_init_bool_indexes(struct policydb *p) > { > kfree(p->bool_val_to_struct); > - p->bool_val_to_struct > - kmalloc(p->p_bools.nprim * sizeof(struct cond_bool_datum *), GFP_KERNEL); > + p->bool_val_to_struct = kmalloc_array(p->p_bools.nprim, > + sizeof(*p->bool_val_to_struct), > + GFP_KERNEL); > if (!p->bool_val_to_struct) > return -ENOMEM; > return 0; > -- > 2.11.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-security-module" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: paul@paul-moore.com (Paul Moore) Date: Thu, 23 Mar 2017 16:24:34 -0400 Subject: [PATCH 01/46] selinux: Use kmalloc_array() in cond_init_bool_indexes() In-Reply-To: <68a423a9-2f89-55f9-fb4c-97dd4df4bb1d@users.sourceforge.net> References: <68a423a9-2f89-55f9-fb4c-97dd4df4bb1d@users.sourceforge.net> Message-ID: To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Sun, Jan 15, 2017 at 9:56 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 10:48:28 +0100 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > * Replace the specification of a data type by a pointer dereference > to make the corresponding size determination a bit safer according to > the Linux coding style convention. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/conditional.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Merged, thanks. Sorry for the delay. > diff --git a/security/selinux/ss/conditional.c b/security/selinux/ss/conditional.c > index 34afeadd9e73..fcfab2635c11 100644 > --- a/security/selinux/ss/conditional.c > +++ b/security/selinux/ss/conditional.c > @@ -176,8 +176,9 @@ void cond_policydb_destroy(struct policydb *p) > int cond_init_bool_indexes(struct policydb *p) > { > kfree(p->bool_val_to_struct); > - p->bool_val_to_struct = > - kmalloc(p->p_bools.nprim * sizeof(struct cond_bool_datum *), GFP_KERNEL); > + p->bool_val_to_struct = kmalloc_array(p->p_bools.nprim, > + sizeof(*p->bool_val_to_struct), > + GFP_KERNEL); > if (!p->bool_val_to_struct) > return -ENOMEM; > return 0; > -- > 2.11.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-security-module" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- paul moore www.paul-moore.com -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html