From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933252AbbDILLF (ORCPT ); Thu, 9 Apr 2015 07:11:05 -0400 Received: from mail-ob0-f177.google.com ([209.85.214.177]:35462 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932614AbbDILLA (ORCPT ); Thu, 9 Apr 2015 07:11:00 -0400 MIME-Version: 1.0 X-Originating-IP: [101.170.170.165] In-Reply-To: <1428511002-22329-3-git-send-email-nicolas.dichtel@6wind.com> References: <1428511002-22329-1-git-send-email-nicolas.dichtel@6wind.com> <1428511002-22329-3-git-send-email-nicolas.dichtel@6wind.com> Date: Thu, 9 Apr 2015 07:10:59 -0400 Message-ID: Subject: Re: [PATCH net-next 2/5] selinux/nlmsg: add RTM_GETNSID From: Paul Moore To: Nicolas Dichtel Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 8, 2015 at 12:36 PM, Nicolas Dichtel wrote: > This new command is missing. > > Fixes: 9a9634545c70 ("netns: notify netns id events") > Signed-off-by: Nicolas Dichtel > --- > security/selinux/nlmsgtab.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/security/selinux/nlmsgtab.c b/security/selinux/nlmsgtab.c > index 91228a730801..c8cee0766b60 100644 > --- a/security/selinux/nlmsgtab.c > +++ b/security/selinux/nlmsgtab.c > @@ -74,6 +74,7 @@ static struct nlmsg_perm nlmsg_route_perms[] = > { RTM_DELMDB, NETLINK_ROUTE_SOCKET__NLMSG_WRITE }, > { RTM_GETMDB, NETLINK_ROUTE_SOCKET__NLMSG_READ }, > { RTM_NEWNSID, NETLINK_ROUTE_SOCKET__NLMSG_WRITE }, > + { RTM_DELNSID, NETLINK_ROUTE_SOCKET__NLMSG_READ }, > { RTM_GETNSID, NETLINK_ROUTE_SOCKET__NLMSG_READ }, > }; Can you elaborate a bit on the RTM_DELNSID type? Based only on the name I wonder if it should be treated as a "write" and not a "read" operation. -- paul moore www.paul-moore.com