From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49156C433F5 for ; Thu, 3 Mar 2022 22:27:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236849AbiCCW2X (ORCPT ); Thu, 3 Mar 2022 17:28:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234471AbiCCW2V (ORCPT ); Thu, 3 Mar 2022 17:28:21 -0500 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7EADFD15 for ; Thu, 3 Mar 2022 14:27:34 -0800 (PST) Received: by mail-ed1-x52d.google.com with SMTP id y2so3818668edc.2 for ; Thu, 03 Mar 2022 14:27:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oKHXsyB04tyrJoKYD+RLcWyJjpgay072O5wpIWtKaKA=; b=J1fz7M71dKOpgDo/StLM97I0vmRTW7N5Hrz1DXlgrELKtffMid03VfmO03Xzka4KLN GwypvtaVKYwog4l2KSWvnjxc2Xj7Ts6Q58UP0vgELxuvgFmxHcDjAgWE/NeQkWp0YjCc HkeVx3ndWVcDRnTJIFVeX16Ot+tTQ6HNu+vHH2/QMp+n6U8H9zfHZEnFezZ31A+xaUum 1f4gW/NS+6ocPSJBqY7Tz9BTxmWIs4o5aQiRdtnGVs4ltLsvctuovaQxFIhO/4fjYhyO EmiFBvT7+m41p45AUzn0xL0QfaYDos5G5FCbalRV8cQOIypFO4vvopekgYZGmACIr0Mp odBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oKHXsyB04tyrJoKYD+RLcWyJjpgay072O5wpIWtKaKA=; b=UVJt5k2jqWFqklM/n4HtfLWrrkM6KT3AA1jkxkfJlckDUx28oc3KtE3PsEVbJgCyf3 B5yW6c7gKB9FyFicjgtueAXLoQMpWNTZDATqA8PmgKZxZ1ewCeZ6NKp6PSbTXVjN62dz uOiXna+bdziEff/N8ym6K/pJWfeFK6G5QrKgzRe9h/DMcOvamp2767dPN0VAg8Jf/gcA xpwvX5DvauB66GPAFiiYTgbNxKxPk99Llupo4OTO8XHtyp74h5rslJWZ/k5Obw4sUjvE wDQKvHXAMD608Xwv4+yrxt9ofeGTWFJVoCO2izv0cUsMhfW45S8cY3x6qhBLXrFyJ+d6 jPXA== X-Gm-Message-State: AOAM5316ryVdBamq2BUtQ5ZTmuXqOFveTsHa0ywsNsYfBUx3H28FdB+y SAXmaLtTmjLleDJBznVgnm0MDmxZQSy5A5h4i0WZ X-Google-Smtp-Source: ABdhPJx+2FAptwXLjRrLT4R1TUzNt8nfeE3yEvFAt8uEvg5KRUpu7Sf81EPLXtm8CbNiuakfJdr87xEHHjj0U53GUJg= X-Received: by 2002:a50:fb02:0:b0:40f:bd67:205f with SMTP id d2-20020a50fb02000000b0040fbd67205fmr36237709edq.409.1646346453376; Thu, 03 Mar 2022 14:27:33 -0800 (PST) MIME-Version: 1.0 References: <20220202235323.23929-1-casey@schaufler-ca.com> <20220202235323.23929-25-casey@schaufler-ca.com> <2f32ffa3-7165-f989-b162-4aab162b5027@schaufler-ca.com> In-Reply-To: <2f32ffa3-7165-f989-b162-4aab162b5027@schaufler-ca.com> From: Paul Moore Date: Thu, 3 Mar 2022 17:27:22 -0500 Message-ID: Subject: Re: [PATCH v32 24/28] Audit: Add framework for auxiliary records To: Casey Schaufler Cc: casey.schaufler@intel.com, jmorris@namei.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, linux-audit@redhat.com, keescook@chromium.org, john.johansen@canonical.com, penguin-kernel@i-love.sakura.ne.jp Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: selinux@vger.kernel.org On Wed, Mar 2, 2022 at 5:32 PM Casey Schaufler wrote: > On 2/2/2022 3:53 PM, Casey Schaufler wrote: > > Add a list for auxiliary record data to the audit_buffer structure. > > Add the audit_stamp information to the audit_buffer as there's no > > guarantee that there will be an audit_context containing the stamp > > associated with the event. At audit_log_end() time create auxiliary > > records (none are currently defined) as have been added to the list. > > > > Signed-off-by: Casey Schaufler > > I'm really hoping for either Acks or feedback on this approach. The only callers that make use of this functionality in this patchset is in kernel/audit*.c in patches 25/28 and 26/28, yes? -- paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D55B9C433F5 for ; Thu, 3 Mar 2022 22:29:17 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-472-Yg_DEn9oO22nzcufbsoSdA-1; Thu, 03 Mar 2022 17:29:13 -0500 X-MC-Unique: Yg_DEn9oO22nzcufbsoSdA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3A2501091DA1; Thu, 3 Mar 2022 22:29:09 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CFD1B6929E; Thu, 3 Mar 2022 22:29:08 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5EEF61809C88; Thu, 3 Mar 2022 22:29:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 223MRao0002104 for ; Thu, 3 Mar 2022 17:27:37 -0500 Received: by smtp.corp.redhat.com (Postfix) id B5EAA1427B13; Thu, 3 Mar 2022 22:27:36 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B1DF9141DC2A for ; Thu, 3 Mar 2022 22:27:36 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9987F801E95 for ; Thu, 3 Mar 2022 22:27:36 +0000 (UTC) Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-543-RinocZy7MEGf8-kfHuw7dQ-1; Thu, 03 Mar 2022 17:27:34 -0500 X-MC-Unique: RinocZy7MEGf8-kfHuw7dQ-1 Received: by mail-ed1-f48.google.com with SMTP id p4so8500437edi.1 for ; Thu, 03 Mar 2022 14:27:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oKHXsyB04tyrJoKYD+RLcWyJjpgay072O5wpIWtKaKA=; b=kIVWaxGED0Ustu0yDcL5VTyOVeYFSB6a2KhaMSLL5DoCaerOvYfVLQWC0SwKFFmpch caBuB5147YzAWPAXN6u0dQRyvs6+AFns02vJun7a29MzwgQABdlF8oGl0Orn8DFx99B3 Ngbx3q4zPOJVrOe1NimZwgiLn9iZ0nF722fx0vPhh5o7Ormm0LbUXg818qJaNSAaR2p0 0DRSUTWEtRRc2TwOwbqCv+Jh+ud+EUG/wasgviWMvuc8WM3b3w12YjnSnEhvyTqM3IJC q9YIsC+1r7P11GXsTzO9bGGH1NJSBQwT2db3tWUYwEMJzpmMqwIte691gRqAw8hMBhdP rkTg== X-Gm-Message-State: AOAM530xNZsfN3ERZ+5mbLt3kxtymqdtAxCJ2MAkBafKHgF/GLUV/o1a KIe600hyq6DzaUgtvzP+Cw6w5AGqmxN0509yRkn2 X-Google-Smtp-Source: ABdhPJx+2FAptwXLjRrLT4R1TUzNt8nfeE3yEvFAt8uEvg5KRUpu7Sf81EPLXtm8CbNiuakfJdr87xEHHjj0U53GUJg= X-Received: by 2002:a50:fb02:0:b0:40f:bd67:205f with SMTP id d2-20020a50fb02000000b0040fbd67205fmr36237709edq.409.1646346453376; Thu, 03 Mar 2022 14:27:33 -0800 (PST) MIME-Version: 1.0 References: <20220202235323.23929-1-casey@schaufler-ca.com> <20220202235323.23929-25-casey@schaufler-ca.com> <2f32ffa3-7165-f989-b162-4aab162b5027@schaufler-ca.com> In-Reply-To: <2f32ffa3-7165-f989-b162-4aab162b5027@schaufler-ca.com> From: Paul Moore Date: Thu, 3 Mar 2022 17:27:22 -0500 Message-ID: Subject: Re: [PATCH v32 24/28] Audit: Add framework for auxiliary records To: Casey Schaufler X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-loop: linux-audit@redhat.com Cc: john.johansen@canonical.com, selinux@vger.kernel.org, jmorris@namei.org, linux-security-module@vger.kernel.org, linux-audit@redhat.com, casey.schaufler@intel.com X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Mar 2, 2022 at 5:32 PM Casey Schaufler wrote: > On 2/2/2022 3:53 PM, Casey Schaufler wrote: > > Add a list for auxiliary record data to the audit_buffer structure. > > Add the audit_stamp information to the audit_buffer as there's no > > guarantee that there will be an audit_context containing the stamp > > associated with the event. At audit_log_end() time create auxiliary > > records (none are currently defined) as have been added to the list. > > > > Signed-off-by: Casey Schaufler > > I'm really hoping for either Acks or feedback on this approach. The only callers that make use of this functionality in this patchset is in kernel/audit*.c in patches 25/28 and 26/28, yes? -- paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit