From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91624C433E0 for ; Wed, 20 May 2020 22:24:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D8D92072C for ; Wed, 20 May 2020 22:24:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore-com.20150623.gappssmtp.com header.i=@paul-moore-com.20150623.gappssmtp.com header.b="msVBo6vx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728485AbgETWYg (ORCPT ); Wed, 20 May 2020 18:24:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726847AbgETWYg (ORCPT ); Wed, 20 May 2020 18:24:36 -0400 Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE040C061A0E for ; Wed, 20 May 2020 15:24:35 -0700 (PDT) Received: by mail-ed1-x543.google.com with SMTP id b91so4981214edf.3 for ; Wed, 20 May 2020 15:24:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gSA5WX2rtYW1qr92WeUFtesNCfHgIL2bBAZXuvDm0SU=; b=msVBo6vx1uLY8kixELthZHbZQmWYjR6LF1IP0asJUxfiblGt0twNVtio+IPlD9s69X dslHn7W89LjVlaIduTLjqvnwMoWiIRjsBwC+diTsfQbYQbSFgftrsLRJsfwcOFryamx7 lKrtGGSmAP7yGPH95pSfbNt1PaFVu4mof4iN6z9kimmZ/Bt+fuMdDtaK/0rgudeoulwC NTLW6ZpFcZdwQbTyd5IcOWyiF6kwwdx00mpP5CwgO4bApAJpgB+D+/rkXD/SMxBxm9Ev peaLzBDsTISSXMBWhBu2Mrn0L1dCViPGzWd4jJwTM3abixQPq925CqueoicY9gsf5Wz6 Ymgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gSA5WX2rtYW1qr92WeUFtesNCfHgIL2bBAZXuvDm0SU=; b=bPFoEQTTvIaPta8rYGdMkg3P62qlt6oUsFRd+/mLOiPKkX1TT6YIft1rhLptqYlTt/ PeIB47oeMwEX3fpkx+8JmoCbBhV4VDErp7SPHK2LR/YKD/qfwSAfNUhmq2m4xAhfTm53 LlLRPHL4lRNZM6uv9imaZfdLUu8ORovpH4tRtZ4zssnRmFd/mxV5HQf6TdoFNEuyBUYi F+uDWtkzD9JzVt3Wu8Oq2LcOfyEfIb+kqt22sX9tdyjQXE0wbOvnD+HMEomqFTpPpSum J7w1T+0Q8RWYEO4X/VXGsr503sUUZXYD7Qd21EEiHnbxWzqtReaCOiUaB+vXFjOKvkWr /7+g== X-Gm-Message-State: AOAM533NFoGTyq1WxDYQTY0SHeYDR85pE3bvNQgSE2RNMWWr/u9ZWvVp 4/oR/gR6ZtdF8HvwCt1E4XK6lgraGbzmTjSEQbCe X-Google-Smtp-Source: ABdhPJwyqUoPXRS1K83vaC0amG6iqYApHCZJSf4TceWjICSJ1ftF4STVZFMnk8HOeRoFwUQbHOTEDke4sib5YKcAtW4= X-Received: by 2002:a05:6402:14d3:: with SMTP id f19mr5159480edx.135.1590013474492; Wed, 20 May 2020 15:24:34 -0700 (PDT) MIME-Version: 1.0 References: <6404938413ca29b0e0196dd74bacb9b0c1cb6f42.1589993784.git.rgb@redhat.com> In-Reply-To: <6404938413ca29b0e0196dd74bacb9b0c1cb6f42.1589993784.git.rgb@redhat.com> From: Paul Moore Date: Wed, 20 May 2020 18:24:23 -0400 Message-ID: Subject: Re: [PATCH ghak25 v6a] audit: add subj creds to NETFILTER_CFG record to cover async unregister To: Richard Guy Briggs Cc: Linux-Audit Mailing List , LKML , netfilter-devel@vger.kernel.org, sgrubb@redhat.com, Ondrej Mosnacek , fw@strlen.de, twoerner@redhat.com, Eric Paris , tgraf@infradead.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 20, 2020 at 2:47 PM Richard Guy Briggs wrote: > > Some table unregister actions seem to be initiated by the kernel to > garbage collect unused tables that are not initiated by any userspace > actions. It was found to be necessary to add the subject credentials to > cover this case to reveal the source of these actions. A sample record: > > The uid, auid, tty, ses and exe fields have not been included since they > are in the SYSCALL record and contain nothing useful in the non-user > context. > > Here are two sample orphaned records: > > type=NETFILTER_CFG msg=audit(2020-05-20 12:14:36.505:5) : table=filter family=ipv4 entries=0 op=register pid=1 subj=kernel comm=swapper/0 > > type=NETFILTER_CFG msg=audit(2020-05-20 12:15:27.701:301) : table=nat family=bridge entries=0 op=unregister pid=30 subj=system_u:system_r:kernel_t:s0 comm=kworker/u4:1 > > Signed-off-by: Richard Guy Briggs Merged into audit/next, thanks Richard. -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD3A7C433DF for ; Wed, 20 May 2020 22:24:57 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8617220874 for ; Wed, 20 May 2020 22:24:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HmTBgHUN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8617220874 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paul-moore.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-audit-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590013496; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Q4qOtZdMC7xpNF0M6n8dRUNCANa3mK/jpKcfdYXqhUc=; b=HmTBgHUNFd/jZSid7YXr9DbG+TaNpMVpqm+wfMDOZLBJfuRueP1Wa8Ql3X4vPfpHcp8ghs alXY7EfLEKjze0XHNyN3Dug3XpdxDcSsuzeLLsg4gmHIlBnSOG2gJKiyGG5ckbbPdVGT+x voOdtl5DCqw6dHNyLgqO0TQZFl1hmyQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-142-iEtCxmflM6m6OIcwdoWjIw-1; Wed, 20 May 2020 18:24:54 -0400 X-MC-Unique: iEtCxmflM6m6OIcwdoWjIw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A1842460; Wed, 20 May 2020 22:24:49 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E4D9360C05; Wed, 20 May 2020 22:24:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C4B8F4EDB8; Wed, 20 May 2020 22:24:43 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 04KMOfhD007235 for ; Wed, 20 May 2020 18:24:41 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2DC17202683E; Wed, 20 May 2020 22:24:41 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2A09A2026DFD for ; Wed, 20 May 2020 22:24:39 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 27389811E77 for ; Wed, 20 May 2020 22:24:39 +0000 (UTC) Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-316-Qz0oGpCDOliQT2SyAXayHw-1; Wed, 20 May 2020 18:24:36 -0400 X-MC-Unique: Qz0oGpCDOliQT2SyAXayHw-1 Received: by mail-ed1-f68.google.com with SMTP id l25so4970722edj.4 for ; Wed, 20 May 2020 15:24:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gSA5WX2rtYW1qr92WeUFtesNCfHgIL2bBAZXuvDm0SU=; b=Cd5V4LltzJMkEamy6sgrazzYapP4IY2P/ApvKD5O88O2uRksCCOAlwXfeRtJFJCdPH w/Vu0Fw5M/jOQvImM6Kq7D8d90Bg6ROxNO4UTwRtakb4oVYUVG8Y6okvFaE0NhLuWRLf DOszMF3e4N4JgZGuUv9ebAlNX2+n1ZQwHoCDo3oD9pC/il+xpbXz7lm308WIDiFWOmd3 6RA2Ir3IIM7n2F85rNUl+RvfnmoIZOGweE12UWA8YabkNDQRSntRjjo4ZoKupR4b/ufW c0s3tnmtDcI23KUn1o62nahziSK6030D5q1l/j6U39Vvu3MlO69uxfL5lqpM5R8l1v1W 1o7w== X-Gm-Message-State: AOAM531LdsobuGqLzdKNN+tHwXpzncRM71ENd9q75eqZxG1vTUZRFY3T UZIxigFpDp2Th/vCElF+0R2R63FqpkSvOjEiKUso X-Google-Smtp-Source: ABdhPJwyqUoPXRS1K83vaC0amG6iqYApHCZJSf4TceWjICSJ1ftF4STVZFMnk8HOeRoFwUQbHOTEDke4sib5YKcAtW4= X-Received: by 2002:a05:6402:14d3:: with SMTP id f19mr5159480edx.135.1590013474492; Wed, 20 May 2020 15:24:34 -0700 (PDT) MIME-Version: 1.0 References: <6404938413ca29b0e0196dd74bacb9b0c1cb6f42.1589993784.git.rgb@redhat.com> In-Reply-To: <6404938413ca29b0e0196dd74bacb9b0c1cb6f42.1589993784.git.rgb@redhat.com> From: Paul Moore Date: Wed, 20 May 2020 18:24:23 -0400 Message-ID: Subject: Re: [PATCH ghak25 v6a] audit: add subj creds to NETFILTER_CFG record to cover async unregister To: Richard Guy Briggs X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: linux-audit@redhat.com Cc: fw@strlen.de, LKML , Linux-Audit Mailing List , netfilter-devel@vger.kernel.org, twoerner@redhat.com, Eric Paris , tgraf@infradead.org X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, May 20, 2020 at 2:47 PM Richard Guy Briggs wrote: > > Some table unregister actions seem to be initiated by the kernel to > garbage collect unused tables that are not initiated by any userspace > actions. It was found to be necessary to add the subject credentials to > cover this case to reveal the source of these actions. A sample record: > > The uid, auid, tty, ses and exe fields have not been included since they > are in the SYSCALL record and contain nothing useful in the non-user > context. > > Here are two sample orphaned records: > > type=NETFILTER_CFG msg=audit(2020-05-20 12:14:36.505:5) : table=filter family=ipv4 entries=0 op=register pid=1 subj=kernel comm=swapper/0 > > type=NETFILTER_CFG msg=audit(2020-05-20 12:15:27.701:301) : table=nat family=bridge entries=0 op=unregister pid=30 subj=system_u:system_r:kernel_t:s0 comm=kworker/u4:1 > > Signed-off-by: Richard Guy Briggs Merged into audit/next, thanks Richard. -- paul moore www.paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit